| Message ID | 20201002180838.2047-1-luoyonggang@gmail.com |
|---|---|
| Headers | show |
| Series | Fixes curses on msys2/mingw | expand |
Only one of the 4 patches in this series appears to have been sent. On Sat, Oct 03, 2020 at 02:08:37AM +0800, Yonggang Luo wrote: > V6-V7 > Update the configure script for > * curses: Fixes compiler error that complain don't have langinfo.h on msys2/m= > ingw > > V5-V6 > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the= > m to meson first. > That need the meson 0.56 upstream to fixes the curses detection. > Add > * configure: fixes indent of $meson setup > > Yonggang Luo (4): > configure: fixes indent of $meson setup > curses: Fixes compiler error that complain don't have langinfo.h on > msys2/mingw > curses: Fixes curses compiling errors. > win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE > are defined on msys2/mingw > > configure | 47 +++++---------------------------------- > include/sysemu/os-win32.h | 4 ++-- > ui/curses.c | 14 ++++++------ > util/oslib-win32.c | 4 ++-- > 4 files changed, 16 insertions(+), 53 deletions(-) > > --=20 > 2.28.0.windows.1 > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Mon, Oct 5, 2020 at 4:23 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > > Only one of the 4 patches in this series appears to have been sent. All other are revied and preserve the same, I prefer not disturb by re sending same patches as other contributor suggested > > On Sat, Oct 03, 2020 at 02:08:37AM +0800, Yonggang Luo wrote: > > V6-V7 > > Update the configure script for > > * curses: Fixes compiler error that complain don't have langinfo.h on msys2/m= > > ingw > > > > V5-V6 > > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the= > > m to meson first. > > That need the meson 0.56 upstream to fixes the curses detection. > > Add > > * configure: fixes indent of $meson setup > > > > Yonggang Luo (4): > > configure: fixes indent of $meson setup > > curses: Fixes compiler error that complain don't have langinfo.h on > > msys2/mingw > > curses: Fixes curses compiling errors. > > win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE > > are defined on msys2/mingw > > > > configure | 47 +++++---------------------------------- > > include/sysemu/os-win32.h | 4 ++-- > > ui/curses.c | 14 ++++++------ > > util/oslib-win32.c | 4 ++-- > > 4 files changed, 16 insertions(+), 53 deletions(-) > > > > --=20 > > 2.28.0.windows.1 > > > > > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo <div dir="ltr"><br><br>On Mon, Oct 5, 2020 at 4:23 PM Daniel P. Berrangé <<a href="mailto:berrange@redhat.com">berrange@redhat.com</a>> wrote:<br>><br>> Only one of the 4 patches in this series appears to have been sent.<div>All other are revied and preserve the same, I prefer not disturb by re sending same patches</div><div>as other contributor suggested<br>><br>> On Sat, Oct 03, 2020 at 02:08:37AM +0800, Yonggang Luo wrote:<br>> > V6-V7<br>> > Update the configure script for<br>> > * curses: Fixes compiler error that complain don't have langinfo.h on msys2/m=<br>> > ingw<br>> ><br>> > V5-V6<br>> > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the=<br>> > m to meson first.<br>> > That need the meson 0.56 upstream to fixes the curses detection.<br>> > Add<br>> > * configure: fixes indent of $meson setup<br>> ><br>> > Yonggang Luo (4):<br>> > configure: fixes indent of $meson setup<br>> > curses: Fixes compiler error that complain don't have langinfo.h on<br>> > msys2/mingw<br>> > curses: Fixes curses compiling errors.<br>> > win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE<br>> > are defined on msys2/mingw<br>> ><br>> > configure | 47 +++++----------------------------------<br>> > include/sysemu/os-win32.h | 4 ++--<br>> > ui/curses.c | 14 ++++++------<br>> > util/oslib-win32.c | 4 ++--<br>> > 4 files changed, 16 insertions(+), 53 deletions(-)<br>> ><br>> > --=20<br>> > 2.28.0.windows.1<br>> ><br>> ><br>><br>> Regards,<br>> Daniel<br>> --<br>> |: <a href="https://berrange.com">https://berrange.com</a> -o- <a href="https://www.flickr.com/photos/dberrange">https://www.flickr.com/photos/dberrange</a> :|<br>> |: <a href="https://libvirt.org">https://libvirt.org</a> -o- <a href="https://fstop138.berrange.com">https://fstop138.berrange.com</a> :|<br>> |: <a href="https://entangle-photo.org">https://entangle-photo.org</a> -o- <a href="https://www.instagram.com/dberrange">https://www.instagram.com/dberrange</a> :|<br>><br><br><br>--<br> 此致<br>礼<br>罗勇刚<br>Yours<br> sincerely,<br>Yonggang Luo</div></div>
On Mon, Oct 05, 2020 at 11:31:28PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Mon, Oct 5, 2020 at 4:23 PM Daniel P. Berrangé <berrange@redhat.com> > wrote: > > > > Only one of the 4 patches in this series appears to have been sent. > All other are revied and preserve the same, I prefer not disturb by re > sending same patches as other contributor suggested I don't know where that is suggested, but I think that is very unhelpful. It breaks any kind of automation around fetching patch series. I don't want to have to fetch some patches from version 6 and some patches from version 7 to test the combined work. Every patch series posted should be complete, so contributors arent left wondering which are the correct versions for each patch. > > > > On Sat, Oct 03, 2020 at 02:08:37AM +0800, Yonggang Luo wrote: > > > V6-V7 > > > Update the configure script for > > > * curses: Fixes compiler error that complain don't have langinfo.h on > msys2/m= > > > ingw > > > > > > V5-V6 > > > Dropping configure: Fixes ncursesw detection under msys2/mingw by > convert the= > > > m to meson first. > > > That need the meson 0.56 upstream to fixes the curses detection. > > > Add > > > * configure: fixes indent of $meson setup > > > > > > Yonggang Luo (4): > > > configure: fixes indent of $meson setup > > > curses: Fixes compiler error that complain don't have langinfo.h on > > > msys2/mingw > > > curses: Fixes curses compiling errors. > > > win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE > > > are defined on msys2/mingw > > > > > > configure | 47 +++++---------------------------------- > > > include/sysemu/os-win32.h | 4 ++-- > > > ui/curses.c | 14 ++++++------ > > > util/oslib-win32.c | 4 ++-- > > > 4 files changed, 16 insertions(+), 53 deletions(-) > > > > > > --=20 > > > 2.28.0.windows.1 > > > > > > > > > > Regards, > > Daniel > > -- > > |: https://berrange.com -o- > https://www.flickr.com/photos/dberrange :| > > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > > |: https://entangle-photo.org -o- > https://www.instagram.com/dberrange :| > > > > > -- > 此致 > 礼 > 罗勇刚 > Yours > sincerely, > Yonggang Luo Regards, Daniel
V6-V7 Update the configure script for * curses: Fixes compiler error that complain don't have langinfo.h on msys2/m= ingw V5-V6 Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the= m to meson first. That need the meson 0.56 upstream to fixes the curses detection. Add * configure: fixes indent of $meson setup Yonggang Luo (4): configure: fixes indent of $meson setup curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw curses: Fixes curses compiling errors. win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw configure | 47 +++++---------------------------------- include/sysemu/os-win32.h | 4 ++-- ui/curses.c | 14 ++++++------ util/oslib-win32.c | 4 ++-- 4 files changed, 16 insertions(+), 53 deletions(-) --=20 2.28.0.windows.1