From patchwork Tue Oct 20 08:12:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 302539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE469C433DF for ; Tue, 20 Oct 2020 08:15:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CBC82225F for ; Tue, 20 Oct 2020 08:15:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b8ovdSSb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CBC82225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUmnO-0007bg-9H for qemu-devel@archiver.kernel.org; Tue, 20 Oct 2020 04:15:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUmli-0006MM-LY for qemu-devel@nongnu.org; Tue, 20 Oct 2020 04:13:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:27074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUmle-0001XW-F4 for qemu-devel@nongnu.org; Tue, 20 Oct 2020 04:13:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603181588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8KGz+620VV6OAVDi1Kpt/dPEGi/LYyTvXMAs2/u6pD8=; b=b8ovdSSb+5VT9Ysy7VMDeEH1xCrD61eY23qYiPCV3q4ih0jHDZgWjIaD02RKkS8fXPZ5dj a5lg2XU/x5kwN2+2X3o21fWJs9/NfMhkU/c08yodcIAD1knA9EDRochAjh3AZHbHVYT8jJ RAGyFOU/8BBuw4kjOodbxAU8BNbD/+w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-1ulUW-hGMbm1H1tdepjhfg-1; Tue, 20 Oct 2020 04:13:06 -0400 X-MC-Unique: 1ulUW-hGMbm1H1tdepjhfg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 485261020902; Tue, 20 Oct 2020 08:13:05 +0000 (UTC) Received: from localhost (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3ECAA5C1A3; Tue, 20 Oct 2020 08:13:00 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v3 0/7] qemu-ga: add ssh-{get,add,remove}-authorized-keys Date: Tue, 20 Oct 2020 12:12:50 +0400 Message-Id: <20201020081257.2054548-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:15:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Marc-André Lureau Hi Add new commands to help modify a user .ssh/authorized_keys. Although it's possible already to modify the authorized_keys files via file-{read,write} or exec, the commands are often denied by default, and the logic is left to the client. Let's add specific commands for this job. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1885332 v3: - add "qga: add ssh-get-authorized-keys" & "qga: add *reset argument to ssh-add-authorized-keys" patches - add some fixup! patches to be squashed after review, adding 'if' - added the reviewed-by - misc doc improvements v2: - misc doc improvements - various warnings fixes - fix build for !unix - added reviewed-by Marc-André Lureau (7): glib-compat: add g_unix_get_passwd_entry_qemu() qga: add ssh-{add,remove}-authorized-keys fixup! qga: add ssh-{add,remove}-authorized-keys fixup! qga: add ssh-{add,remove}-authorized-keys qga: add *reset argument to ssh-add-authorized-keys meson: minor simplification qga: add ssh-get-authorized-keys include/glib-compat.h | 26 ++ qga/commands-posix-ssh.c | 516 +++++++++++++++++++++++++++++++++++++++ qga/meson.build | 34 ++- qga/qapi-schema.json | 67 +++++ 4 files changed, 636 insertions(+), 7 deletions(-) create mode 100644 qga/commands-posix-ssh.c -- 2.28.0