mbox series

[PULL,v3,00/28] Block patches

Message ID 20201023152147.1016281-1-stefanha@redhat.com
Headers show
Series Block patches | expand

Message

Stefan Hajnoczi Oct. 23, 2020, 3:21 p.m. UTC 
The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:

  Merge remote-tracking branch 'remotes/kraxel/tags/modules-20201022-pull-request' into staging (2020-10-22 12:33:21 +0100)

are available in the Git repository at:

  https://gitlab.com/stefanha/qemu.git tags/block-pull-request

for you to fetch changes up to 4f193168af097ef664287f4c801724f063a60fc2:

  iotests: add commit top->base cases to 274 (2020-10-23 13:42:16 +0100)

----------------------------------------------------------------
Pull request

v3:
 * Fix linker error on FreeBSD and other !CONFIG_LINUX host OSes [Peter]

----------------------------------------------------------------

Coiby Xu (6):
  libvhost-user: Allow vu_message_read to be replaced
  libvhost-user: remove watch for kick_fd when de-initialize vu-dev
  util/vhost-user-server: generic vhost user server
  block: move logical block size check function to a common utility
    function
  block/export: vhost-user block device backend server
  MAINTAINERS: Add vhost-user block device backend server maintainer

Philippe Mathieu-Daudé (1):
  block/nvme: Add driver statistics for access alignment and hw errors

Stefan Hajnoczi (16):
  util/vhost-user-server: s/fileds/fields/ typo fix
  util/vhost-user-server: drop unnecessary QOM cast
  util/vhost-user-server: drop unnecessary watch deletion
  block/export: consolidate request structs into VuBlockReq
  util/vhost-user-server: drop unused DevicePanicNotifier
  util/vhost-user-server: fix memory leak in vu_message_read()
  util/vhost-user-server: check EOF when reading payload
  util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
  block/export: report flush errors
  block/export: convert vhost-user-blk server to block export API
  util/vhost-user-server: move header to include/
  util/vhost-user-server: use static library in meson.build
  qemu-storage-daemon: avoid compiling blockdev_ss twice
  block: move block exports to libblockdev
  block/export: add iothread and fixed-iothread options
  block/export: add vhost-user-blk multi-queue support

Vladimir Sementsov-Ogievskiy (5):
  block/io: fix bdrv_co_block_status_above
  block/io: bdrv_common_block_status_above: support include_base
  block/io: bdrv_common_block_status_above: support bs == base
  block/io: fix bdrv_is_allocated_above
  iotests: add commit top->base cases to 274

 MAINTAINERS                                |   9 +
 qapi/block-core.json                       |  24 +-
 qapi/block-export.json                     |  36 +-
 block/coroutines.h                         |   2 +
 block/export/vhost-user-blk-server.h       |  19 +
 contrib/libvhost-user/libvhost-user.h      |  21 +
 include/qemu/vhost-user-server.h           |  65 +++
 util/block-helpers.h                       |  19 +
 block/export/export.c                      |  37 +-
 block/export/vhost-user-blk-server.c       | 431 ++++++++++++++++++++
 block/io.c                                 | 132 +++---
 block/nvme.c                               |  27 ++
 block/qcow2.c                              |  16 +-
 contrib/libvhost-user/libvhost-user-glib.c |   2 +-
 contrib/libvhost-user/libvhost-user.c      |  15 +-
 hw/core/qdev-properties-system.c           |  31 +-
 nbd/server.c                               |   2 -
 qemu-nbd.c                                 |  21 +-
 softmmu/vl.c                               |   4 +
 stubs/blk-exp-close-all.c                  |   7 +
 tests/vhost-user-bridge.c                  |   2 +
 tools/virtiofsd/fuse_virtio.c              |   4 +-
 util/block-helpers.c                       |  46 +++
 util/vhost-user-server.c                   | 446 +++++++++++++++++++++
 block/export/meson.build                   |   3 +-
 contrib/libvhost-user/meson.build          |   1 +
 meson.build                                |  22 +-
 nbd/meson.build                            |   2 +
 storage-daemon/meson.build                 |   3 +-
 stubs/meson.build                          |   1 +
 tests/qemu-iotests/274                     |  20 +
 tests/qemu-iotests/274.out                 |  68 ++++
 util/meson.build                           |   4 +
 33 files changed, 1420 insertions(+), 122 deletions(-)
 create mode 100644 block/export/vhost-user-blk-server.h
 create mode 100644 include/qemu/vhost-user-server.h
 create mode 100644 util/block-helpers.h
 create mode 100644 block/export/vhost-user-blk-server.c
 create mode 100644 stubs/blk-exp-close-all.c
 create mode 100644 util/block-helpers.c
 create mode 100644 util/vhost-user-server.c

-- 
2.26.2

Comments

no-reply@patchew.org Oct. 23, 2020, 4:03 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20201023152147.1016281-1-stefanha@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201023152147.1016281-1-stefanha@redhat.com
Subject: [PULL v3 00/28] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201023152147.1016281-1-stefanha@redhat.com -> patchew/20201023152147.1016281-1-stefanha@redhat.com
Switched to a new branch 'test'
38310db iotests: add commit top->base cases to 274
f0671dd block/io: fix bdrv_is_allocated_above
d9c08b8 block/io: bdrv_common_block_status_above: support bs == base
c837bb3 block/io: bdrv_common_block_status_above: support include_base
6451e449 block/io: fix bdrv_co_block_status_above
b1b2eaa block/export: add vhost-user-blk multi-queue support
4cfdc0f block/export: add iothread and fixed-iothread options
21b0ebf block: move block exports to libblockdev
8e28b19 qemu-storage-daemon: avoid compiling blockdev_ss twice
d78e439 util/vhost-user-server: use static library in meson.build
5ed1b1e util/vhost-user-server: move header to include/
4fdb4dc block/export: convert vhost-user-blk server to block export API
1d7b5ba block/export: report flush errors
70c003e util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
6b44703 util/vhost-user-server: check EOF when reading payload
2712e58 util/vhost-user-server: fix memory leak in vu_message_read()
0e740c0 util/vhost-user-server: drop unused DevicePanicNotifier
4f37c8e block/export: consolidate request structs into VuBlockReq
326d4b4 util/vhost-user-server: drop unnecessary watch deletion
f072aef util/vhost-user-server: drop unnecessary QOM cast
dfd5a40 util/vhost-user-server: s/fileds/fields/ typo fix
106a79f MAINTAINERS: Add vhost-user block device backend server maintainer
bcb59a3 block/export: vhost-user block device backend server
c5e218a block: move logical block size check function to a common utility function
c4829fd util/vhost-user-server: generic vhost user server
b7acac2 libvhost-user: remove watch for kick_fd when de-initialize vu-dev
d236c9a libvhost-user: Allow vu_message_read to be replaced
098c6e0 block/nvme: Add driver statistics for access alignment and hw errors

=== OUTPUT BEGIN ===
1/28 Checking commit 098c6e074f94 (block/nvme: Add driver statistics for access alignment and hw errors)
2/28 Checking commit d236c9abc147 (libvhost-user: Allow vu_message_read to be replaced)
WARNING: Block comments use a leading /* on a separate line
#130: FILE: contrib/libvhost-user/libvhost-user.h:395:
+    /* @read_msg: custom method to read vhost-user message

total: 0 errors, 1 warnings, 139 lines checked

Patch 2/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/28 Checking commit b7acac2640e0 (libvhost-user: remove watch for kick_fd when de-initialize vu-dev)
4/28 Checking commit c4829fd6b453 (util/vhost-user-server: generic vhost user server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#87: FILE: util/vhost-user-server.c:48:
+    /* When this is set vu_client_trip will stop new processing vhost-user message */

total: 0 errors, 2 warnings, 500 lines checked

Patch 4/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/28 Checking commit c5e218aa5fc3 (block: move logical block size check function to a common utility function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 5/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/28 Checking commit bcb59a3a37a8 (block/export: vhost-user block device backend server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

WARNING: line over 80 characters
#476: FILE: block/export/vhost-user-blk-server.c:442:
+        blk_remove_aio_context_notifier(vu_block_device->backend, blk_aio_attached,

ERROR: g_free(NULL) is safe this check is probably not required
#536: FILE: block/export/vhost-user-blk-server.c:502:
+    if (vus->node_name) {
+        g_free(vus->node_name);

total: 1 errors, 2 warnings, 714 lines checked

Patch 6/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/28 Checking commit 106a79fb461d (MAINTAINERS: Add vhost-user block device backend server maintainer)
8/28 Checking commit dfd5a4061b05 (util/vhost-user-server: s/fileds/fields/ typo fix)
9/28 Checking commit f072aef0f494 (util/vhost-user-server: drop unnecessary QOM cast)
10/28 Checking commit 326d4b430279 (util/vhost-user-server: drop unnecessary watch deletion)
11/28 Checking commit 4f37c8e08118 (block/export: consolidate request structs into VuBlockReq)
12/28 Checking commit 0e740c0945a8 (util/vhost-user-server: drop unused DevicePanicNotifier)
13/28 Checking commit 2712e5839f92 (util/vhost-user-server: fix memory leak in vu_message_read())
14/28 Checking commit 6b447030ed29 (util/vhost-user-server: check EOF when reading payload)
15/28 Checking commit 70c003e7fe79 (util/vhost-user-server: rework vu_client_trip() coroutine lifecycle)
16/28 Checking commit 1d7b5ba6e09f (block/export: report flush errors)
17/28 Checking commit 4fdb4dcdc4d9 (block/export: convert vhost-user-blk server to block export API)
WARNING: line over 80 characters
#848: FILE: util/vhost-user-server.c:415:
+        error_setg(errp, "Only socket address types 'unix' and 'fd' are supported");

total: 0 errors, 1 warnings, 750 lines checked

Patch 17/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/28 Checking commit 5ed1b1edd9e5 (util/vhost-user-server: move header to include/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46: 
rename from util/vhost-user-server.h

total: 0 errors, 1 warnings, 28 lines checked

Patch 18/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/28 Checking commit d78e43930105 (util/vhost-user-server: use static library in meson.build)
20/28 Checking commit 8e28b1908224 (qemu-storage-daemon: avoid compiling blockdev_ss twice)
21/28 Checking commit 21b0ebf54fe2 (block: move block exports to libblockdev)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#127: 
new file mode 100644

total: 0 errors, 1 warnings, 86 lines checked

Patch 21/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/28 Checking commit 4cfdc0f3e2be (block/export: add iothread and fixed-iothread options)
23/28 Checking commit b1b2eaa78531 (block/export: add vhost-user-blk multi-queue support)
24/28 Checking commit 6451e449c883 (block/io: fix bdrv_co_block_status_above)
25/28 Checking commit c837bb332bb9 (block/io: bdrv_common_block_status_above: support include_base)
26/28 Checking commit d9c08b866289 (block/io: bdrv_common_block_status_above: support bs == base)
27/28 Checking commit f0671dd4d0e9 (block/io: fix bdrv_is_allocated_above)
28/28 Checking commit 38310db03387 (iotests: add commit top->base cases to 274)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201023152147.1016281-1-stefanha@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Oct. 26, 2020, 11:27 a.m. UTC | #2 
On Fri, 23 Oct 2020 at 16:21, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>

> The following changes since commit 4c5b97bfd0dd54dc27717ae8d1cd10e14eef1430:

>

>   Merge remote-tracking branch 'remotes/kraxel/tags/modules-20201022-pull-request' into staging (2020-10-22 12:33:21 +0100)

>

> are available in the Git repository at:

>

>   https://gitlab.com/stefanha/qemu.git tags/block-pull-request

>

> for you to fetch changes up to 4f193168af097ef664287f4c801724f063a60fc2:

>

>   iotests: add commit top->base cases to 274 (2020-10-23 13:42:16 +0100)

>

> ----------------------------------------------------------------

> Pull request

>

> v3:

>  * Fix linker error on FreeBSD and other !CONFIG_LINUX host OSes [Peter]

>

> ----------------------------------------------------------------



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.

-- PMM