mbox series

[v2,0/7] block: permission update fix & refactor

Message ID 20201106124241.16950-1-vsementsov@virtuozzo.com
Headers show
Series block: permission update fix & refactor | expand

Message

Vladimir Sementsov-Ogievskiy Nov. 6, 2020, 12:42 p.m. UTC 
Hi all!

These series supersedes "Fix nested permission update" and includes one
more fix (patch 01) and more improvements.

I think patch 01 is good to have in 5.2, 02 is probably OK for 5.2 and
the others are OK for next release. Still all may be taken to 5.2, up to
block maintainers.

Actually the series is a first part of my work announced in
https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg08386.html
to bring correct order to permission update (topological sort),
update permission only on updated graph (and rollback graph changes),
get rid of .active fields in block jobs.

Supersedes: <20201031123502.4558-1-vsementsov@virtuozzo.com>

v2: all new except for 03:, which uses suggestions by Albert and more
strict version of bdrv_replace_node.

Vladimir Sementsov-Ogievskiy (7):
  block: add forgotten bdrv_abort_perm_update() to
    bdrv_co_invalidate_cache()
  block: add bdrv_replace_node_common()
  block: make bdrv_drop_intermediate() less wrong
  block: add bdrv_refresh_perms() helper
  block: bdrv_set_perm() drop redundant parameters.
  block: bdrv_child_set_perm() drop redundant parameters.
  block: drop tighten_restrictions

 block.c | 256 +++++++++++++++++++++++---------------------------------
 1 file changed, 105 insertions(+), 151 deletions(-)

Comments

Max Reitz Nov. 9, 2020, 2:41 p.m. UTC | #1 
On 06.11.20 13:42, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> These series supersedes "Fix nested permission update" and includes one
> more fix (patch 01) and more improvements.
> 
> I think patch 01 is good to have in 5.2, 02 is probably OK for 5.2 and
> the others are OK for next release. Still all may be taken to 5.2, up to
> block maintainers.
> 
> Actually the series is a first part of my work announced in
> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg08386.html
> to bring correct order to permission update (topological sort),
> update permission only on updated graph (and rollback graph changes),
> get rid of .active fields in block jobs.
> 
> Supersedes: <20201031123502.4558-1-vsementsov@virtuozzo.com>
> 
> v2: all new except for 03:, which uses suggestions by Albert and more
> strict version of bdrv_replace_node.

Thanks, I took 1 through 3 to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

and 4 through 7 to my block-next branch (squashing in the fix for 4, and 
fixing up the resulting conflict in 7):

https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next

Max