From patchwork Wed May 3 09:17:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 678826 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp947902wrs; Wed, 3 May 2023 02:18:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xNj8yxr6iRJybBY+Z0Twh60HmS1vTiE0S4X/HM1PnEFifbHmaFTgyyRJ1j4Z5dqol/b9x X-Received: by 2002:a05:6214:27e6:b0:5ef:67b9:8d37 with SMTP id jt6-20020a05621427e600b005ef67b98d37mr9425868qvb.13.1683105487787; Wed, 03 May 2023 02:18:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683105487; cv=none; d=google.com; s=arc-20160816; b=vpyWQaS+hM8cqE7qRfGzpF53IlpnsQRj36c0MYt3H5G+P1UqY4xyowVeKmnZI5paBt 0nmLW3WNZaha/CuEO3HWSjZC450SxOfDklb1K0AlFLFBu7vHXu5jY/oy6097QnRfCdJY XHlsxuqPsPqWjwnvnGJMC8+mbkv/RvLy2OIHnJR1H/LtEQW85ESynEWm/Wg3yU1Yk+/q TxpuNIbaDmvlMsSeuzq+kiPvpuTqDZCV1kGY36wFMHW5S1QV6gGLVTpZXLAzVsJMMCes B0pYKORjemQlhOuA5mWxsGj8nK89oNUjjq9kv9tYkOUUChzvrCtffuneiRThOfP6TbBt 158A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=l3OH7urWoHKg3VabeYBsA0ZRMxDZKatUQbuechO5qNw=; b=lWvokOesUiUe876tg2bq32BxRHio7spmbJGPu23GiCKcVjZ0qdJ3qoaUdaXN0DP32d uQ2WTfCT7qe1SlYyUao7viOepIgtz/64JT8SPNfRyyPxfWGh+8xKZlPrVZS/1zS8/iI/ eZyuykdDqBbVCqzN1bo+sWnPj4zrE2eiJNK9eVe0OcnZUXZjINVcXsN7D0lnQqr0fxlp m9vs+HfNpUT8FEOTDc3zxy/LznSWoip5SQHmLl9kvlb7u6g9eRhIfsCJqWnHFbZiA27f cmJYJlFzgyDDaUdIfkyEMk7o4517mmJO75c78Zfmc2zmmsSLxpGE9D1fyqUkQmVftmc9 3WEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YmuKDp9G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f13-20020a0562141d2d00b0053b81ec39f4si18179402qvd.462.2023.05.03.02.18.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 May 2023 02:18:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YmuKDp9G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pu8cc-0002jK-IT; Wed, 03 May 2023 05:18:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pu8cb-0002cL-I5 for qemu-devel@nongnu.org; Wed, 03 May 2023 05:18:01 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pu8cZ-0000Lb-K9 for qemu-devel@nongnu.org; Wed, 03 May 2023 05:18:01 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f315712406so15573475e9.0 for ; Wed, 03 May 2023 02:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683105478; x=1685697478; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=l3OH7urWoHKg3VabeYBsA0ZRMxDZKatUQbuechO5qNw=; b=YmuKDp9GZm1If1WeBUbbyXQ7IJSbplU2ZXqkyiDYtrDe+uIbLdEkom47x+GW4us7G8 nTk5BdqwvwfpH6OhQQEBbcqs8WRCFh3nN8Ln+qHafM3InZ7TQkebr9Y8yMki5KKm6YHI 5Kw/769vg0YNgoEzt4oNpctlwov3Dvn5jJ3+N1VXyQ6RES0VHgqSmy0j7EiOfKob7L3T 6gQkIdsDRYv+Qy4S3mK2aCK3w+51U2Zak09inVytl7Q3FhLjBulVZ76m/ESXzmUskQLA bpXsV8GB59jVukMC5TI/RVPSDSsQaTdKO3U5DoJo/j9FqDJrRyNHLmGTEgfScNvQdnCm He5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683105478; x=1685697478; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l3OH7urWoHKg3VabeYBsA0ZRMxDZKatUQbuechO5qNw=; b=OELzxOYfpNlfYPGgD5LnuJlQmlQPNA80eYP8yYIFyHYtb6MgqXaMULMJVycRaZ1xPv V0dsk7PnqgkegX68Y0NaQt7NIFupIJbyOO6GS1lIT5bNAddqREHtz8D3TvZ99sSkRVvd til5euOL36bsJMQA1kSC2Bezc0I1gJ/qPvGltjThKu4s5lSS5I6Tfmuc24QPv2VdD2mq oElhrIGCeeJhsjIh+RVh8g9woSjPW4IgU4tDqDxMTBtSCx3DfqxZyA0oenthSpiStn/2 GYf53hVYjp5Vohvr9FdY8WpD9NCYoML3OTYYCtNRCVkNvaLLpFT/w+uDejUe/I6Rj2Wu T6PQ== X-Gm-Message-State: AC+VfDypCoIrK5eofFKH79ODhkF7asyQGOingH3/Lc95L6Quafw/lfE5 8aFXC/xLcjgVpMEbAtdJZwlwbA== X-Received: by 2002:a5d:6741:0:b0:2f6:3930:fa7f with SMTP id l1-20020a5d6741000000b002f63930fa7fmr1085982wrw.7.1683105477829; Wed, 03 May 2023 02:17:57 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id bl13-20020adfe24d000000b003062d3daf79sm7745595wrb.107.2023.05.03.02.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 02:17:57 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id EEF771FFBB; Wed, 3 May 2023 10:17:56 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org, Stefan Hajnoczi Cc: Marcel Apfelbaum , Kyle Evans , Paolo Bonzini , Riku Voipio , Yanan Wang , Eduardo Habkost , Greg Kurz , Warner Losh , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Christian Schoenebeck , Richard Henderson , Eric Blake , Michael Roth , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v2 00/10] tracing: remove dynamic vcpu state Date: Wed, 3 May 2023 10:17:46 +0100 Message-Id: <20230503091756.1453057-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Hi Stefan, The references dynamic vcpu tracing support was removed when the original TCG trace points where removed. However there was still a legacy of dynamic trace state to track this in cpu.h and extra hash variables to track TBs. While the removed vcpu tracepoints are not in generated code (or helpers) they still bring in a bunch of machinery to manage the state so I've pulled them out. We keep and rename one (cpu_reset) to a static trace points which dump vcpu->index as it is useful to f4bug. While most of the changes are excising bits of the tracing code I've also cleaned up the xxhash function use and simplified the core function to qemu_xxhash6. v2 only has some minor changes to address review comments (c.f. conversion of a tracepoint). Otherwise all the review comments have been addressed and the series is fully review now. Please queue into your tree. Alex Bennée (10): *-user: remove the guest_user_syscall tracepoints trace-events: remove the remaining vcpu trace events trace: remove vcpu_id from the TraceEvent structure scripts/qapi: document the tool that generated the file qapi: make the vcpu parameters deprecated for 8.1 trace: remove code that depends on setting vcpu trace: remove control-vcpu.h tcg: remove the final vestiges of dstate hw/9pfs: use qemu_xxhash4 xxhash: remove qemu_xxhash7 qapi/trace.json | 22 +++---- accel/tcg/tb-hash.h | 6 +- include/exec/exec-all.h | 3 - include/hw/core/cpu.h | 5 -- include/qemu/xxhash.h | 17 ++---- include/user/syscall-trace.h | 4 -- trace/control-internal.h | 10 --- trace/control-vcpu.h | 63 ------------------- trace/control.h | 48 --------------- trace/event-internal.h | 2 - accel/tcg/cpu-exec.c | 7 +-- accel/tcg/tb-maint.c | 5 +- accel/tcg/translate-all.c | 6 -- bsd-user/freebsd/os-syscall.c | 2 - hw/9pfs/9p.c | 4 +- hw/core/cpu-common.c | 6 +- stubs/trace-control.c | 13 ---- trace/control-target.c | 111 +++------------------------------- trace/control.c | 28 --------- trace/qmp.c | 76 +++-------------------- trace/trace-hmp-cmds.c | 17 +----- hw/core/trace-events | 3 + scripts/qapi/gen.py | 4 +- scripts/tracetool/format/c.py | 6 -- scripts/tracetool/format/h.py | 16 +---- trace-events | 50 --------------- 26 files changed, 48 insertions(+), 486 deletions(-) delete mode 100644 trace/control-vcpu.h