mbox series

[v2,0/2] accel/tcg: Fix race condition in tb create/invalidate

Message ID 20230707103611.5906-1-richard.henderson@linaro.org
Headers show
Series accel/tcg: Fix race condition in tb create/invalidate | expand

Message

Richard Henderson July 7, 2023, 10:36 a.m. UTC 
Changes for v2:

Adjust the change to cpu_exec_longjmp_cleanup, which should now survive
user-only testing.  I'm not really happy with it.  I suggested two
alternatives in the block comment, but neither of them are trivial.

Please re-review, if you gave it a glance before.  And if you have
any bright suggestions short of "use real exceptions", I'm all ears.


r~


Richard Henderson (2):
  accel/tcg: Split out cpu_exec_longjmp_cleanup
  accel/tcg: Always lock pages before translation

 accel/tcg/internal.h      |  30 ++++-
 accel/tcg/cpu-exec.c      |  63 ++++++----
 accel/tcg/tb-maint.c      | 242 ++++++++++++++++++++------------------
 accel/tcg/translate-all.c |  43 ++++++-
 accel/tcg/translator.c    |  34 ++++--
 5 files changed, 255 insertions(+), 157 deletions(-)

Comments

Naresh Kamboju July 7, 2023, 12:01 p.m. UTC | #1 
On Fri, 7 Jul 2023 at 16:06, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Changes for v2:
>
> Adjust the change to cpu_exec_longjmp_cleanup, which should now survive
> user-only testing.  I'm not really happy with it.  I suggested two
> alternatives in the block comment, but neither of them are trivial.
>
> Please re-review, if you gave it a glance before.  And if you have
> any bright suggestions short of "use real exceptions", I'm all ears.

Thanks for your patch.
Since, The problem has been reported initially by LKFT, we would run our
LKFT test plans by using tuxtest with latest kernel and get back to you in the
next few days.

- Naresh

>
> r~
>
>
> Richard Henderson (2):
>   accel/tcg: Split out cpu_exec_longjmp_cleanup
>   accel/tcg: Always lock pages before translation
>
>  accel/tcg/internal.h      |  30 ++++-
>  accel/tcg/cpu-exec.c      |  63 ++++++----
>  accel/tcg/tb-maint.c      | 242 ++++++++++++++++++++------------------
>  accel/tcg/translate-all.c |  43 ++++++-
>  accel/tcg/translator.c    |  34 ++++--
>  5 files changed, 255 insertions(+), 157 deletions(-)
>
> --
> 2.34.1
>
>