mbox series

[PATCH-for-9.1,0/3] ui/display: Introduce API to change console orientation

Message ID 20240318100543.78846-1-philmd@linaro.org
Headers show
Series ui/display: Introduce API to change console orientation | expand

Message

Philippe Mathieu-Daudé March 18, 2024, 10:05 a.m. UTC 
Hi,

The idea behind this series is to reduce the use of the
'graphic_rotate' global. It is only used by the Spitz
machine, so we could convert the '-rotate' argument to
a sugar property on the PXA2XX_LCD_TYPE model, but since
the Spitz machine has been deprecated recently (commit
a2531bb855 "Deprecate various old Arm machine types") it
doesn't seem worthwhile. So just extract the API to change
console orientation.

Regards,

Phil.

Philippe Mathieu-Daudé (3):
  ui/console: Introduce API to change console orientation
  hw/display/pxa2xx_lcd: Set rotation angle using
    qemu_console_set_rotate
  ui/console: Add 'rotate_arcdegree' field to allow per-console rotation

 include/ui/console.h    |  3 +++
 ui/console-priv.h       |  1 +
 hw/display/pxa2xx_lcd.c |  1 +
 ui/console.c            | 15 +++++++++++++++
 ui/input.c              |  9 ++++-----
 5 files changed, 24 insertions(+), 5 deletions(-)

Comments

Philippe Mathieu-Daudé March 18, 2024, 10:13 a.m. UTC | #1 
(Forgot to Cc Akihiko)

On 18/3/24 11:05, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> The idea behind this series is to reduce the use of the
> 'graphic_rotate' global. It is only used by the Spitz
> machine, so we could convert the '-rotate' argument to
> a sugar property on the PXA2XX_LCD_TYPE model, but since
> the Spitz machine has been deprecated recently (commit
> a2531bb855 "Deprecate various old Arm machine types") it
> doesn't seem worthwhile. So just extract the API to change
> console orientation.
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (3):
>    ui/console: Introduce API to change console orientation
>    hw/display/pxa2xx_lcd: Set rotation angle using
>      qemu_console_set_rotate
>    ui/console: Add 'rotate_arcdegree' field to allow per-console rotation