mbox series

[v3,0/3] build contrib/plugins using meson

Message ID 20241023212812.1376972-1-pierrick.bouvier@linaro.org
Headers show
Series build contrib/plugins using meson | expand

Message

Pierrick Bouvier Oct. 23, 2024, 9:28 p.m. UTC 
Contrib plugins have been built out of tree so far, thanks to a Makefile.
However, it is quite inconvenient for maintenance, as we may break them,
especially for specific architectures.

First patches are fixing warnings for existing plugins, then we add meson
support, and finally, we remove Makefile for contrib/plugins.

Based on the proposal of Anton Kochkov on associated gitlab issue.
Solves: https://gitlab.com/qemu-project/qemu/-/issues/1710

Plugins are now deactivated by default on 32-bits hosts (since cf2a78), so we
can enable with meson without worrying of warnings when building plugins for 32
bits.

Removed patches for individual plugins.

v2:
- removed warnings fix for 32 bits as they were incorrect. They are not needed
  anymore as plugins are deprecated for 32 bits hosts.

v3:
- do not build lockstep on windows (it uses sys/socket.h)
- build new plugins recently added
- fix warning in cflow plugin
- tested it builds correctly on windows/macos/linux

Pierrick Bouvier (3):
  contrib/plugins/cflow: fix warning
  meson: build contrib/plugins with meson
  contrib/plugins: remove Makefile for contrib/plugins

 configure                   | 18 --------
 Makefile                    | 10 -----
 meson.build                 |  4 ++
 contrib/plugins/cflow.c     |  6 +--
 contrib/plugins/Makefile    | 87 -------------------------------------
 contrib/plugins/meson.build | 28 ++++++++++++
 6 files changed, 35 insertions(+), 118 deletions(-)
 delete mode 100644 contrib/plugins/Makefile
 create mode 100644 contrib/plugins/meson.build

Comments

Alex Bennée Oct. 24, 2024, 10:15 a.m. UTC | #1 
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> Contrib plugins have been built out of tree so far, thanks to a Makefile.
> However, it is quite inconvenient for maintenance, as we may break them,
> especially for specific architectures.
>
> First patches are fixing warnings for existing plugins, then we add meson
> support, and finally, we remove Makefile for contrib/plugins.
>
> Based on the proposal of Anton Kochkov on associated gitlab issue.
> Solves: https://gitlab.com/qemu-project/qemu/-/issues/1710
>
> Plugins are now deactivated by default on 32-bits hosts (since cf2a78), so we
> can enable with meson without worrying of warnings when building plugins for 32
> bits.
>
> Removed patches for individual plugins.

Queued to plugins/next, thanks.
Pierrick Bouvier Nov. 4, 2024, 10:29 p.m. UTC | #2 
Hi Alex,

On 10/24/24 03:15, Alex Bennée wrote:
> Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> 
>> Contrib plugins have been built out of tree so far, thanks to a Makefile.
>> However, it is quite inconvenient for maintenance, as we may break them,
>> especially for specific architectures.
>>
>> First patches are fixing warnings for existing plugins, then we add meson
>> support, and finally, we remove Makefile for contrib/plugins.
>>
>> Based on the proposal of Anton Kochkov on associated gitlab issue.
>> Solves: https://gitlab.com/qemu-project/qemu/-/issues/1710
>>
>> Plugins are now deactivated by default on 32-bits hosts (since cf2a78), so we
>> can enable with meson without worrying of warnings when building plugins for 32
>> bits.
>>
>> Removed patches for individual plugins.
> 
> Queued to plugins/next, thanks.
> 
thanks for queuing it.
Would that be possible to have a PR integrating this for 9.2 release?
It would be convenient, to avoid needing to keep it in sync when new 
plugins are posted.

Thanks,
Pierrick