[00/46] tcg: Remove in-flight mask data from OptContext

Message ID	20241210152401.1823648-1-richard.henderson@linaro.org
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Subject: [PATCH 00/46] tcg: Remove in-flight mask data from OptContext Date: Tue, 10 Dec 2024 09:23:15 -0600 Message-ID: <20241210152401.1823648-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org
Series	tcg: Remove in-flight mask data from OptContext \| expand [00/46] tcg: Remove in-flight mask data from OptContext [01/46] tcg/optimize: Split out finish_bb, finish_ebb [02/46] tcg/optimize: Copy mask writeback to fold_masks [03/46] tcg/optimize: Add fold_masks_zsa, fold_masks_zs, fold_masks_z [04/46] tcg/optimize: Use finish_folding in fold_add, fold_add_vec [05/46] tcg/optimize: Use finish_folding in fold_addsub2 [06/46] tcg/optimize: Use fold_masks_zsa in fold_and [07/46] tcg/optimize: Use fold_masks_zsa in fold_andc [08/46] tcg/optimize: Use fold_masks_zs in fold_bswap [09/46] tcg/optimize: Use fold_masks_z in fold_count_zeros [10/46] tcg/optimize: Use fold_masks_z in fold_ctpop [11/46] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit [12/46] tcg/optimize: Use finish_folding in fold_divide [13/46] tcg/optimize: Use finish_folding in fold_dup, fold_dup2 [14/46] tcg/optimize: Use fold_masks_zs in fold_eqv [15/46] tcg/optimize: Use fold_masks_zsa in fold_extract [16/46] tcg/optimize: Use finish_folding in fold_extract2 [17/46] tcg/optimize: Use fold_masks_zsa in fold_exts [18/46] tcg/optimize: Use fold_masks_zsa in fold_extu [19/46] tcg/optimize: Use fold_masks_zs in fold_movcond [20/46] tcg/optimize: Use finish_folding in fold_mul* [21/46] tcg/optimize: Use fold_masks_zs in fold_nand [22/46] tcg/optimize: Use fold_masks_z in fold_neg_no_const [23/46] tcg/optimize: Use fold_masks_zs in fold_nor [24/46] tcg/optimize: Use fold_masks_zs in fold_not [25/46] tcg/optimize: Use fold_masks_zs in fold_or [26/46] tcg/optimize: Use fold_masks_zs in fold_orc [27/46] tcg/optimize: Use fold_masks_zs in fold_qemu_ld [28/46] tcg/optimize: Return true from fold_qemu_st, fold_tcg_st [29/46] tcg/optimize: Use finish_folding in fold_remainder [30/46] tcg/optimize: Distinguish simplification in fold_setcond_zmask [31/46] tcg/optimize: Use fold_masks_z in fold_setcond [32/46] tcg/optimize: Use fold_masks_zs in fold_negsetcond [33/46] tcg/optimize: Use fold_masks_z in fold_setcond2 [34/46] tcg/optimize: Use finish_folding in fold_cmp_vec [35/46] tcg/optimize: Use finish_folding in fold_cmpsel_vec [36/46] tcg/optimize: Use fold_masks_zsa in fold_sextract [37/46] tcg/optimize: Use fold_masks_zs in fold_shift [38/46] tcg/optimize: Use finish_folding in fold_sub, fold_sub_vec [39/46] tcg/optimize: Use fold_masks_zs in fold_tcg_ld [40/46] tcg/optimize: Use finish_folding in fold_tcg_ld_memcopy [41/46] tcg/optimize: Use fold_masks_zs in fold_xor [42/46] tcg/optimize: Use finish_folding in fold_bitsel_vec [43/46] tcg/optimize: Use finish_folding as default in tcg_optimize [44/46] tcg/optimize: Remove [zsa]_mask from OptContext [45/46] tcg/optimize: Move fold_bitsel_vec into alphabetic sort [46/46] tcg/optimize: Move fold_cmp_vec, fold_cmpsel_vec into alphabetic sort

Message ID

20241210152401.1823648-1-richard.henderson@linaro.org

Headers

Received-SPF: pass (google.com: domain of
 qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as
 permitted sender) client-ip=209.51.188.17;
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 00/46] tcg: Remove in-flight mask data from OptContext
Date: Tue, 10 Dec 2024 09:23:15 -0600
Message-ID: <20241210152401.1823648-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::236;
 envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x236.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org

Series

tcg: Remove in-flight mask data from OptContext | expand

Message

Richard Henderson Dec. 10, 2024, 3:23 p.m. UTC

The desire is to start re-using some of the fold_* functions
while lowering or simplifying operations during tcg_optmize.

Many of these fold_* functions set z_mask, s_mask, and a_mask,
which hang around until the end of the tcg_optmize loop and
are applied by finish_folding.  This disconnect between set
and apply is a problem -- we would no longer be applying the
masks to the correct opcode.

Fix this by making the masks local variables, passed down to
be applied immediately to the opcode being processed.


r~


Richard Henderson (46):
  tcg/optimize: Split out finish_bb, finish_ebb
  tcg/optimize: Copy mask writeback to fold_masks
  tcg/optimize: Add fold_masks_zsa, fold_masks_zs, fold_masks_z
  tcg/optimize: Use finish_folding in fold_add, fold_add_vec
  tcg/optimize: Use finish_folding in fold_addsub2
  tcg/optimize: Use fold_masks_zsa in fold_and
  tcg/optimize: Use fold_masks_zsa in fold_andc
  tcg/optimize: Use fold_masks_zs in fold_bswap
  tcg/optimize: Use fold_masks_z in fold_count_zeros
  tcg/optimize: Use fold_masks_z in fold_ctpop
  tcg/optimize: Use fold_and and fold_masks_z in fold_deposit
  tcg/optimize: Use finish_folding in fold_divide
  tcg/optimize: Use finish_folding in fold_dup, fold_dup2
  tcg/optimize: Use fold_masks_zs in fold_eqv
  tcg/optimize: Use fold_masks_zsa in fold_extract
  tcg/optimize: Use finish_folding in fold_extract2
  tcg/optimize: Use fold_masks_zsa in fold_exts
  tcg/optimize: Use fold_masks_zsa in fold_extu
  tcg/optimize: Use fold_masks_zs in fold_movcond
  tcg/optimize: Use finish_folding in fold_mul*
  tcg/optimize: Use fold_masks_zs in fold_nand
  tcg/optimize: Use fold_masks_z in fold_neg_no_const
  tcg/optimize: Use fold_masks_zs in fold_nor
  tcg/optimize: Use fold_masks_zs in fold_not
  tcg/optimize: Use fold_masks_zs in fold_or
  tcg/optimize: Use fold_masks_zs in fold_orc
  tcg/optimize: Use fold_masks_zs in fold_qemu_ld
  tcg/optimize: Return true from fold_qemu_st, fold_tcg_st
  tcg/optimize: Use finish_folding in fold_remainder
  tcg/optimize: Distinguish simplification in fold_setcond_zmask
  tcg/optimize: Use fold_masks_z in fold_setcond
  tcg/optimize: Use fold_masks_zs in fold_negsetcond
  tcg/optimize: Use fold_masks_z in fold_setcond2
  tcg/optimize: Use finish_folding in fold_cmp_vec
  tcg/optimize: Use finish_folding in fold_cmpsel_vec
  tcg/optimize: Use fold_masks_zsa in fold_sextract
  tcg/optimize: Use fold_masks_zs in fold_shift
  tcg/optimize: Use finish_folding in fold_sub, fold_sub_vec
  tcg/optimize: Use fold_masks_zs in fold_tcg_ld
  tcg/optimize: Use finish_folding in fold_tcg_ld_memcopy
  tcg/optimize: Use fold_masks_zs in fold_xor
  tcg/optimize: Use finish_folding in fold_bitsel_vec
  tcg/optimize: Use finish_folding as default in tcg_optimize
  tcg/optimize: Remove [zsa]_mask from OptContext
  tcg/optimize: Move fold_bitsel_vec into alphabetic sort
  tcg/optimize: Move fold_cmp_vec, fold_cmpsel_vec into alphabetic sort

 tcg/optimize.c | 597 ++++++++++++++++++++++++++-----------------------
 1 file changed, 315 insertions(+), 282 deletions(-)