mbox series

[v4,0/7] hw/boards: Try to make sense of MachineClass::no_sdcard flag

Message ID 20250204200934.65279-1-philmd@linaro.org
Headers show
Series hw/boards: Try to make sense of MachineClass::no_sdcard flag | expand

Message

Philippe Mathieu-Daudé Feb. 4, 2025, 8:09 p.m. UTC 
Invert MachineClass 'no_sdcard' flag logic and rename it
to 'create_default_sdcard_drive' to make sense of this
default value applied to all machines.
We use the OnOffAuto tri-state to catch implicit default
values. Then we toggle the logic and remove invalid uses.
No logical change intended (except the assertion added).

The list of machines using this feature is:

  $ git grep -l 'auto_create_sdcard = true'
  hw/arm/aspeed.c
  hw/arm/bananapi_m2u.c
  hw/arm/cubieboard.c
  hw/arm/exynos4_boards.c
  hw/arm/fby35.c
  hw/arm/imx25_pdk.c
  hw/arm/integratorcp.c
  hw/arm/mcimx6ul-evk.c
  hw/arm/mcimx7d-sabre.c
  hw/arm/npcm7xx_boards.c
  hw/arm/omap_sx1.c
  hw/arm/orangepi.c
  hw/arm/raspi.c
  hw/arm/raspi4b.c
  hw/arm/realview.c
  hw/arm/sabrelite.c
  hw/arm/stellaris.c
  hw/arm/versatilepb.c
  hw/arm/vexpress.c
  hw/arm/xlnx-versal-virt.c
  hw/arm/xlnx-zcu102.c
  hw/riscv/microchip_pfsoc.c
  hw/riscv/sifive_u.c

Since v3:
- Do not remove machines with multiple sd-bus
Since v2:
- Fixed mis-rebase catched by Thomas

Philippe Mathieu-Daudé (7):
  hw/boards: Convert no_sdcard flag to OnOffAuto tri-state
  hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF
  hw/boards: Rename no_sdcard -> auto_create_sdcard
  hw/boards: Remove all invalid uses of auto_create_sdcard=true
  hw/arm: Remove all invalid uses of auto_create_sdcard=true
  hw/riscv: Remove all invalid uses of auto_create_sdcard=true
  hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus

 include/hw/boards.h        |  2 +-
 hw/arm/aspeed.c            | 20 ++++++++++++++++++++
 hw/arm/bananapi_m2u.c      |  1 +
 hw/arm/cubieboard.c        |  1 +
 hw/arm/exynos4_boards.c    |  2 ++
 hw/arm/fby35.c             |  1 +
 hw/arm/imx25_pdk.c         |  1 +
 hw/arm/integratorcp.c      |  1 +
 hw/arm/mcimx6ul-evk.c      |  1 +
 hw/arm/mcimx7d-sabre.c     |  1 +
 hw/arm/npcm7xx_boards.c    |  5 +++++
 hw/arm/omap_sx1.c          |  2 ++
 hw/arm/orangepi.c          |  1 +
 hw/arm/raspi.c             |  5 +++++
 hw/arm/raspi4b.c           |  1 +
 hw/arm/realview.c          |  4 ++++
 hw/arm/sabrelite.c         |  1 +
 hw/arm/stellaris.c         |  1 +
 hw/arm/versatilepb.c       |  2 ++
 hw/arm/vexpress.c          |  2 ++
 hw/arm/xilinx_zynq.c       |  1 -
 hw/arm/xlnx-versal-virt.c  |  1 +
 hw/arm/xlnx-zcu102.c       |  1 +
 hw/core/null-machine.c     |  1 -
 hw/riscv/microchip_pfsoc.c |  1 +
 hw/riscv/sifive_u.c        |  1 +
 hw/s390x/s390-virtio-ccw.c |  1 -
 system/vl.c                | 24 ++++++++++++++++++++----
 28 files changed, 78 insertions(+), 8 deletions(-)

Comments

Philippe Mathieu-Daudé Feb. 10, 2025, 8:37 p.m. UTC | #1 
On 4/2/25 21:09, Philippe Mathieu-Daudé wrote:

> Philippe Mathieu-Daudé (7):
>    hw/boards: Convert no_sdcard flag to OnOffAuto tri-state
>    hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF
>    hw/boards: Rename no_sdcard -> auto_create_sdcard
>    hw/boards: Remove all invalid uses of auto_create_sdcard=true
>    hw/arm: Remove all invalid uses of auto_create_sdcard=true
>    hw/riscv: Remove all invalid uses of auto_create_sdcard=true
>    hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus

Series queued including Markus' description update from v2, thanks!