From patchwork Mon Mar 10 15:14:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 872208 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp1043574wri; Mon, 10 Mar 2025 08:15:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXqt08+/XdLTTR3HMhPmasAvZiFoooUPp0I6Cp9Y5UHZpJEm5zqDqWGPtj28Nq27uzfVh8K3Q==@linaro.org X-Google-Smtp-Source: AGHT+IGQxepM/dFKutC5vfDoQKvStGz4qYvClix1dFK3IMQSL3O0nqdBU24dRI+/GnTnkXevqNui X-Received: by 2002:a05:6214:519a:b0:6d8:f0ba:ea92 with SMTP id 6a1803df08f44-6e90063cf85mr166744956d6.21.1741619745851; Mon, 10 Mar 2025 08:15:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741619745; cv=none; d=google.com; s=arc-20240605; b=Cjcscqz1+I/tZppOAXtF4l3iHxD1a7PJHfVU38d72YjCE1gVQmXEHeu3CtzkIqv74P CZY16ZbRGTyNRof+VpXJdbiCrziROrJ97oZDYFW1mZ8so5iK7qJjUBVN02J0AHEnIJA1 rumqFFa8+tQx5IxjpzsvUg42hAWmZbhdd1n+RnmOqrMrrGtoGpDD5CrRoFM0fUC2dMIp WUACQ/qyP2QA+gwE5ElGGJIn2w/8XbCwnICwhulTQ8crR4Zgq6S/kBFJXkt/GXuiXgvE e4JzOzRUtTJTRvzzzkmIoIGOcqy4Svvno/EOzAv7X9yK+T9GMdZbGQCCUgeO73tfhq/G VZLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=cYRtVdei7pNdl/ANTtkKx+JpRO5AgxaFdT9Rt3FJCQw=; fh=FrXspGF9dqFxfqr7h/opREu8X39lKPmpirjz+1d7KSk=; b=eSbAG0DoeXAK3SLnDGZwzN0iwtlykGVo1nxXmZSw3TP5C4VVYNl2kCb8TFHjhm5q0P hCdf924amRRgBKtP2Pju9Oo5Wq4nsTag4Yorxa69G8D/2VcuNkWb3xmL+uyhGsDp7WF+ CWuKuON7n571ZMY+ibgeVMy2JWkd1K0eV9mSLKjus3wHdtwzsL7FbGORFLCsuywVE3I2 qidohUgECFSxYRF1hHyalDxdNMJ8vcBfxW8Nkwgi3hlaKAdMz7MJHPi79P8hDfZyg4ob BT7fzHZl1pbaCQXM2ecz7drJz2yQ5w6JmNTKf9ab4j9yZBI5pEqUkHqe+OREWx5V2Wfe YF5g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JzMsr0I9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e8f707ce48si91377946d6.95.2025.03.10.08.15.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 08:15:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JzMsr0I9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1treq8-0007MP-UY; Mon, 10 Mar 2025 11:14:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trepk-0006uf-To for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:14:25 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1trepi-00082r-EG for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:14:24 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso10623185e9.3 for ; Mon, 10 Mar 2025 08:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741619657; x=1742224457; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cYRtVdei7pNdl/ANTtkKx+JpRO5AgxaFdT9Rt3FJCQw=; b=JzMsr0I94dh5cXkovmbsySr4cPbi5s1R3S+kQdK5/8rBeqKVriprICN5TWJKFG8If3 9xTa+zSYf9aDVDMbEzNPoO5DVgymCwuw+0f/udIdIyhlFbfm/L5nZ+vSi2dTRnnhm6+a YUSJ6yQ5TokM+dEEUgSjhbc4DImde7s087l1eMEJInCbxyG7/w+XbZGs7B9rdjhxWu+B 0rP7NdppZADQzFT5kM6s13gnJXZrnIzq9oZovWY2pxQ6DW2NsU7DA4pt8Xa7Z/lX5TVf lOlV8rOjQ6sgKqqrrmgq8dsH2gM3QxcKlBvjdN+QKkpQaQJ0X7xtAxMpLHikuB4xLHfx eChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741619657; x=1742224457; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cYRtVdei7pNdl/ANTtkKx+JpRO5AgxaFdT9Rt3FJCQw=; b=dBQnkoCMjV91CJrdMHNTXsCrxQ0XYYsqM3Xm7FwSSNpHCTtk9SWJVFexkC8L57s4ay 86+KAjdfMqyZdJ1IlNHGy4DFHbr6VQS+p3NLOXNdq/EMMFN2wPDtOkI1LFvrE59x/t1H XZ5jA6p92yFj34MQfzuC8BTPWDqEuJuvpyjWhXAbVY/PSTRDPxM+MrwBesQwb55nSwM5 1d7qOfIQqYsZ1A982D170x5ZGVw0xArlqkN0EzcYcaS/HclNYxedGRhXHF5YY14aN7A0 Ju5x6aYuios/r6UJVSr23yvm22EDLehmAxo+QQwiC6sALFx7RTGcgFVy6JNj21k37BfF xTFg== X-Gm-Message-State: AOJu0Yz+Zr1LJhth3vLibYCMarWu9K6AFNgF0cJJnqmrm6vZ2frKrS6Z tEPLq1UGO47MN7L8AqB7UAQcSDbQzxms/YTgux4Jz2Co8BHW7rh5uBK3j6zqgsUH7RkiyRYco8r rE3M= X-Gm-Gg: ASbGncs3ixCenVa7+QGu3bDAyqA13G2p5omF3B8u3Szm3xA/PvTDXdy9ebYJs3d6zs9 TIRVCTU8H7+9nV+6OT8r4j1yGUI5VuRWd8Lu0A64k0ODxl9QTm2snN0n6jsmtBwCjPY3SOxbO+p O+5vHO+aKvw7CWluzGY0aG9egRd/emk4nQMxh+y/sPbEmc+KmYiMi7GEMXnbSDLJM4R1dFg2z6K b45YJ6kz55k+BIGd/pmnwTOzxUm6p9jwbqjgo1b7D/3HMc4Ix3zfElew+o64zG3RH2KmN8zczMe 4ODNqJ3rW5k4wLZyNnkXgFjwar3OpXxZt7dvhh3UzgMicZreYoXd9vCgzi2EBAnrvIc2mQBGNuX 5HA6FUTBTBqtl4l0991s= X-Received: by 2002:a05:600c:1c14:b0:43c:f0ae:da7 with SMTP id 5b1f17b1804b1-43cf0ae15acmr42364365e9.7.1741619657467; Mon, 10 Mar 2025 08:14:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ce5c35709sm89530915e9.19.2025.03.10.08.14.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Mar 2025 08:14:16 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Richard Henderson , Thomas Huth , David Hildenbrand , Anton Johansson , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , Marcel Apfelbaum , Zhao Liu , Christian Borntraeger , Ilya Leoshkevich , Eduardo Habkost , Yanan Wang , Pierrick Bouvier , =?utf-8?q?Alex_Benn=C3=A9e?= , Eric Blake , "Dr. David Alan Gilbert" , Halil Pasic , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Markus Armbruster , Eric Farman Subject: [PATCH v3 0/4] qapi/machine: Make @dump-skeys command generic Date: Mon, 10 Mar 2025 16:14:10 +0100 Message-ID: <20250310151414.11550-1-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. Introduce the TYPE_DUMP_SKEYS_INTERFACE type which provide the qmp_dump_skeys() callback, have it implemented on the CCW machine. Machines not supporting this interface report a QMP GenericError. No HMP change. Since v2: - Use machine interface (Daniel) Since v1 [*]: - No QMP rename / deprecation [*] https://lore.kernel.org/qemu-devel/20240530074544.25444-1-philmd@linaro.org/ Philippe Mathieu-Daudé (4): hw/s390x/skeys: Declare QOM types using DEFINE_TYPES() macro hw/s390x/skeys: Introduce TYPE_DUMP_SKEYS_INTERFACE hw/s390x/ccw: Have CCW machine implement a qmp_dump_skeys() callback qapi/machine: Make @dump-skeys command generic qapi/machine.json | 18 +++++++++++++ qapi/misc-target.json | 19 ------------- include/hw/s390x/storage-keys.h | 16 +++++++++++ hw/core/machine-qmp-cmds.c | 14 ++++++++++ hw/s390x/s390-skeys.c | 47 +++++++++++++++++---------------- hw/s390x/s390-virtio-ccw.c | 3 +++ 6 files changed, 75 insertions(+), 42 deletions(-)