| Message ID | 20250321181549.3331-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | tcg: Move TCG_GUEST_DEFAULT_MO -> TCGCPUOps::guest_default_memory_order | expand |
On 3/21/25 11:15, Philippe Mathieu-Daudé wrote: > Since v1: > - Do not use tcg_ctx in tcg_req_mo (rth) > > Hi, > > In this series we replace the TCG_GUEST_DEFAULT_MO definition > from "cpu-param.h" by a 'guest_default_memory_order' field in > TCGCPUOps. > > Since tcg_req_mo() now accesses tcg_ctx, this impact the > cpu_req_mo() calls in accel/tcg/{cputlb,user-exec}.c. > > The long term goal is to be able to use targets with distinct > guest memory order restrictions. > > Philippe Mathieu-Daudé (7): > tcg: Always define TCG_GUEST_DEFAULT_MO > tcg: Simplify tcg_req_mo() macro > tcg: Define guest_default_memory_order in TCGCPUOps > tcg: Remove use of TCG_GUEST_DEFAULT_MO in tb_gen_code() > tcg: Propagate CPUState argument to cpu_req_mo() > tcg: Have tcg_req_mo() useTCGCPUOps::guest_default_memory_order > tcg: Remove the TCG_GUEST_DEFAULT_MO definition globally Queued to tcg-next, thanks. r~
On 2/4/25 22:00, Richard Henderson wrote: > On 3/21/25 11:15, Philippe Mathieu-Daudé wrote: >> Since v1: >> - Do not use tcg_ctx in tcg_req_mo (rth) >> >> Hi, >> >> In this series we replace the TCG_GUEST_DEFAULT_MO definition >> from "cpu-param.h" by a 'guest_default_memory_order' field in >> TCGCPUOps. >> >> Since tcg_req_mo() now accesses tcg_ctx, this impact the >> cpu_req_mo() calls in accel/tcg/{cputlb,user-exec}.c. >> >> The long term goal is to be able to use targets with distinct >> guest memory order restrictions. >> >> Philippe Mathieu-Daudé (7): >> tcg: Always define TCG_GUEST_DEFAULT_MO >> tcg: Simplify tcg_req_mo() macro >> tcg: Define guest_default_memory_order in TCGCPUOps >> tcg: Remove use of TCG_GUEST_DEFAULT_MO in tb_gen_code() >> tcg: Propagate CPUState argument to cpu_req_mo() >> tcg: Have tcg_req_mo() useTCGCPUOps::guest_default_memory_order >> tcg: Remove the TCG_GUEST_DEFAULT_MO definition globally > > Queued to tcg-next, thanks. Thanks but I neglected to test on linux-user and found a pair of issues, so I'll respin with them addressed.
On 2/4/25 22:27, Philippe Mathieu-Daudé wrote: > On 2/4/25 22:00, Richard Henderson wrote: >> On 3/21/25 11:15, Philippe Mathieu-Daudé wrote: >>> Since v1: >>> - Do not use tcg_ctx in tcg_req_mo (rth) >>> >>> Hi, >>> >>> In this series we replace the TCG_GUEST_DEFAULT_MO definition >>> from "cpu-param.h" by a 'guest_default_memory_order' field in >>> TCGCPUOps. >>> >>> Since tcg_req_mo() now accesses tcg_ctx, this impact the >>> cpu_req_mo() calls in accel/tcg/{cputlb,user-exec}.c. >>> >>> The long term goal is to be able to use targets with distinct >>> guest memory order restrictions. >>> >>> Philippe Mathieu-Daudé (7): >>> tcg: Always define TCG_GUEST_DEFAULT_MO >>> tcg: Simplify tcg_req_mo() macro >>> tcg: Define guest_default_memory_order in TCGCPUOps >>> tcg: Remove use of TCG_GUEST_DEFAULT_MO in tb_gen_code() >>> tcg: Propagate CPUState argument to cpu_req_mo() >>> tcg: Have tcg_req_mo() useTCGCPUOps::guest_default_memory_order >>> tcg: Remove the TCG_GUEST_DEFAULT_MO definition globally >> >> Queued to tcg-next, thanks. > > Thanks but I neglected to test on linux-user and found a pair of issues, > so I'll respin with them addressed. Oops, wrong series (I meant the one about TCGCPUOps::mttcg_supported). This one is OK.
Since v1: - Do not use tcg_ctx in tcg_req_mo (rth) Hi, In this series we replace the TCG_GUEST_DEFAULT_MO definition from "cpu-param.h" by a 'guest_default_memory_order' field in TCGCPUOps. Since tcg_req_mo() now accesses tcg_ctx, this impact the cpu_req_mo() calls in accel/tcg/{cputlb,user-exec}.c. The long term goal is to be able to use targets with distinct guest memory order restrictions. Philippe Mathieu-Daudé (7): tcg: Always define TCG_GUEST_DEFAULT_MO tcg: Simplify tcg_req_mo() macro tcg: Define guest_default_memory_order in TCGCPUOps tcg: Remove use of TCG_GUEST_DEFAULT_MO in tb_gen_code() tcg: Propagate CPUState argument to cpu_req_mo() tcg: Have tcg_req_mo() use TCGCPUOps::guest_default_memory_order tcg: Remove the TCG_GUEST_DEFAULT_MO definition globally docs/devel/multi-thread-tcg.rst | 4 ++-- accel/tcg/internal-target.h | 19 ++++++------------- include/accel/tcg/cpu-ops.h | 8 ++++++++ target/alpha/cpu-param.h | 3 --- target/arm/cpu-param.h | 3 --- target/avr/cpu-param.h | 2 -- target/hppa/cpu-param.h | 8 -------- target/i386/cpu-param.h | 3 --- target/loongarch/cpu-param.h | 2 -- target/microblaze/cpu-param.h | 3 --- target/mips/cpu-param.h | 2 -- target/openrisc/cpu-param.h | 2 -- target/ppc/cpu-param.h | 2 -- target/riscv/cpu-param.h | 2 -- target/s390x/cpu-param.h | 6 ------ target/sparc/cpu-param.h | 23 ----------------------- target/xtensa/cpu-param.h | 3 --- accel/tcg/cputlb.c | 20 ++++++++++---------- accel/tcg/tcg-all.c | 3 --- accel/tcg/translate-all.c | 6 +----- accel/tcg/user-exec.c | 20 ++++++++++---------- target/alpha/cpu.c | 3 +++ target/arm/cpu.c | 3 +++ target/arm/tcg/cpu-v7m.c | 3 +++ target/avr/cpu.c | 1 + target/hexagon/cpu.c | 2 ++ target/hppa/cpu.c | 8 ++++++++ target/i386/tcg/tcg-cpu.c | 5 +++++ target/loongarch/cpu.c | 2 ++ target/m68k/cpu.c | 3 +++ target/microblaze/cpu.c | 3 +++ target/mips/cpu.c | 2 ++ target/openrisc/cpu.c | 2 ++ target/ppc/cpu_init.c | 2 ++ target/riscv/tcg/tcg-cpu.c | 2 ++ target/rx/cpu.c | 3 +++ target/s390x/cpu.c | 6 ++++++ target/sh4/cpu.c | 3 +++ target/sparc/cpu.c | 23 +++++++++++++++++++++++ target/tricore/cpu.c | 2 ++ target/xtensa/cpu.c | 3 +++ 41 files changed, 118 insertions(+), 107 deletions(-)