| Message ID | cover.1594725647.git.pisa@cmp.felk.cvut.cz |
|---|---|
| Headers | show |
| Series | CTU CAN FD core support | expand |
Hello Vikram, thanks much for the patches review. On Tuesday 01 of September 2020 22:01:26 Vikram Garhwal wrote: > Hi Jan, > A couple of comments on this patch. > > On Tue, Jul 14, 2020 at 02:20:14PM +0200, pisa@cmp.felk.cvut.cz wrote: > > From: Jan Charvat <charvj10@fel.cvut.cz> > > @@ -185,13 +204,34 @@ static void can_host_socketcan_connect(CanHostState > > *ch, Error **errp) addr.can_family = AF_CAN; > > memset(&ifr.ifr_name, 0, sizeof(ifr.ifr_name)); > > strcpy(ifr.ifr_name, c->ifname); > > + /* check if the frame fits into the CAN netdevice */ > > if (ioctl(s, SIOCGIFINDEX, &ifr) < 0) { > > error_setg_errno(errp, errno, > > - "SocketCAN host interface %s not available", > > c->ifname); + "SocketCAN host interface %s not > > available", + c->ifname); > > May be this formatting change in a different patch? As this is not related > to CANFD. > > @@ -232,7 +272,8 @@ static char *can_host_socketcan_get_if(Object *obj, > > Error **errp) return g_strdup(c->ifname); > > } > > > > -static void can_host_socketcan_set_if(Object *obj, const char *value, > > Error **errp) +static void can_host_socketcan_set_if(Object *obj, const > > char *value, > > + Error **errp) > > This one also not relevant change for CANFD. Rest of the patch looks good. I am responsible for mentioned lines change in net/can/can_socketcan.c. When I have reviewed patches after Jan Charvat theses submittion, I have done another bunch of rounds to check that the patches as well as the whole net/can and hw/net/can are checkpatch clean. I am not sure if the incorrect formatting sneaked in in my 2018 submission or patcheck became more strict last years. I can separate these changes changes into separate patch if required. By the way, if you or other of your colleagues is willing to participate in net/can and or hw/net/can patches reviews, I would be happy if you join my attempt and we can record that we are available to take care abut these in MAINTAINERS file. Best wishes, Pavel
From: Pavel Pisa <pisa@cmp.felk.cvut.cz> CTU CAN FD is an open source soft core written in VHDL. It originated in 2015 as Ondrej Ille's project at the Department of Measurement of FEE at CTU. Integration for Xilinx Zynq and Intel based SoCs is available as well as support for PCIe integration of the core. The core sources https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core The controller model and QEMU CAN subsystem extension to CAN FD has been implemented in frame of bachelor theses of Jan Charvat. The development branch ctu-canfd in CTU local project repository https://gitlab.fel.cvut.cz/canbus/qemu-canbus More CAN bus related project from Czech Technical University in Prague, Faculty of Electrical Engineering at http://canbus.pages.fel.cvut.cz/ Jan Charvat (5): net/can: Initial host SocketCan support for CAN FD. hw/net/can: sja1000 ignore CAN FD frames net/can: Add can_dlc2len and can_len2dlc for CAN FD. hw/net/can/ctucafd: Add CTU CAN FD core register definitions. hw/net/can: CTU CAN FD IP open hardware core emulation. Pavel Pisa (1): hw/net/can: Documentation for CTU CAN FD IP open hardware core emulation. MAINTAINERS | 8 + docs/can.txt | 113 +++- hw/net/can/Makefile.objs | 3 + hw/net/can/can_sja1000.c | 31 +- hw/net/can/ctu_can_fd_frame.h | 190 +++++++ hw/net/can/ctu_can_fd_regs.h | 972 ++++++++++++++++++++++++++++++++++ hw/net/can/ctucan_core.c | 691 ++++++++++++++++++++++++ hw/net/can/ctucan_core.h | 127 +++++ hw/net/can/ctucan_pci.c | 281 ++++++++++ include/net/can_emu.h | 12 +- net/can/can_core.c | 36 ++ net/can/can_socketcan.c | 47 +- 12 files changed, 2490 insertions(+), 21 deletions(-) create mode 100644 hw/net/can/ctu_can_fd_frame.h create mode 100644 hw/net/can/ctu_can_fd_regs.h create mode 100644 hw/net/can/ctucan_core.c create mode 100644 hw/net/can/ctucan_core.h create mode 100644 hw/net/can/ctucan_pci.c