| Message ID | cover.1602771296.git.qemu_oss@crudebyte.com |
|---|---|
| Headers | show |
| Series | 9p queue 2020-10-15 | expand |
On Thu, 15 Oct 2020 at 22:04, Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > > The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14 13:56:06 +0100) > > are available in the Git repository at: > > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20201015 > > for you to fetch changes up to 97a64ec211d051439b654950ed3f7cffc47d489b: > > tests/9pfs: add local Tmkdir test (2020-10-15 16:11:17 +0200) > > ---------------------------------------------------------------- > 9pfs: add tests using local fs driver > > The currently existing 9pfs test cases are all solely using the 9pfs 'synth' > fileystem driver, which is a very simple and purely simulated (in RAM only) > filesystem. There are issues though where the 'synth' fs driver is not > sufficient. For example the following two bugs need test cases running the > 9pfs 'local' fs driver: > > https://bugs.launchpad.net/qemu/+bug/1336794 > https://bugs.launchpad.net/qemu/+bug/1877384 > > This patch set for that reason introduces 9pfs test cases using the 9pfs > 'local' filesystem driver along to the already existing tests on 'synth'. Build failure, OSX: Compiling C object tests/qtest/libqos/libqos.fa.p/virtio-9p.c.o ../../tests/qtest/libqos/virtio-9p.c:37:17: error: implicit declaration of function 'get_current_dir_name' is invalid in C99 [-Werror,-Wimplicit-function-declaration] char *pwd = get_current_dir_name(); ^ ../../tests/qtest/libqos/virtio-9p.c:37:17: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] ../../tests/qtest/libqos/virtio-9p.c:37:11: error: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Werror,-Wint-conversion] char *pwd = get_current_dir_name(); thanks -- PMM
On Samstag, 17. Oktober 2020 12:50:13 CEST Peter Maydell wrote: > On Thu, 15 Oct 2020 at 22:04, Christian Schoenebeck > > <qemu_oss@crudebyte.com> wrote: > > The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: > > Merge remote-tracking branch > > 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14 > > 13:56:06 +0100)> > > are available in the Git repository at: > > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20201015 > > > > for you to fetch changes up to 97a64ec211d051439b654950ed3f7cffc47d489b: > > tests/9pfs: add local Tmkdir test (2020-10-15 16:11:17 +0200) > > > > ---------------------------------------------------------------- > > 9pfs: add tests using local fs driver > > > > The currently existing 9pfs test cases are all solely using the 9pfs > > 'synth' fileystem driver, which is a very simple and purely simulated (in > > RAM only) filesystem. There are issues though where the 'synth' fs driver > > is not sufficient. For example the following two bugs need test cases > > running the 9pfs 'local' fs driver: > > > > https://bugs.launchpad.net/qemu/+bug/1336794 > > https://bugs.launchpad.net/qemu/+bug/1877384 > > > > This patch set for that reason introduces 9pfs test cases using the 9pfs > > 'local' filesystem driver along to the already existing tests on 'synth'. > > Build failure, OSX: > > Compiling C object tests/qtest/libqos/libqos.fa.p/virtio-9p.c.o > ../../tests/qtest/libqos/virtio-9p.c:37:17: error: implicit > declaration of function 'get_current_dir_name' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > char *pwd = get_current_dir_name(); > ^ > ../../tests/qtest/libqos/virtio-9p.c:37:17: error: this function > declaration is not a prototype [-Werror,-Wstrict-prototypes] > ../../tests/qtest/libqos/virtio-9p.c:37:11: error: incompatible > integer to pointer conversion initializing 'char *' with an expression > of type 'int' [-Werror,-Wint-conversion] > char *pwd = get_current_dir_name(); > > > thanks > -- PMM Oops, get_current_dir_name() is a GNU extension. I just enabled Cirrus-CI to prevent this from happening again. Sorry Peter. Am I supposed to rebase for v2 PRs? Fix for this is currently test running: > index 1524982634..d43647b3b7 100644 > --- a/tests/qtest/libqos/virtio-9p.c > +++ b/tests/qtest/libqos/virtio-9p.c > @@ -34,9 +34,9 @@ static char *concat_path(const char* a, const char* b) > > static void init_local_test_path(void) > { > > - char *pwd = get_current_dir_name(); > + char *pwd = g_get_current_dir(); > > local_test_path = concat_path(pwd, "qtest-9p-local"); > > - free(pwd); > + g_free(pwd); > > } > > /* Creates the directory for the 9pfs 'local' filesystem driver to access. > */ Best regards, Christian Schoenebeck
On Sat, 17 Oct 2020 at 12:55, Christian Schoenebeck <qemu_oss@crudebyte.com> wrote: > Oops, get_current_dir_name() is a GNU extension. I just enabled Cirrus-CI to > prevent this from happening again. Sorry Peter. > > Am I supposed to rebase for v2 PRs? Yeah, just rebase and resend, please. thanks -- PMM
The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14 13:56:06 +0100) are available in the Git repository at: https://github.com/cschoenebeck/qemu.git tags/pull-9p-20201015 for you to fetch changes up to 97a64ec211d051439b654950ed3f7cffc47d489b: tests/9pfs: add local Tmkdir test (2020-10-15 16:11:17 +0200) ---------------------------------------------------------------- 9pfs: add tests using local fs driver The currently existing 9pfs test cases are all solely using the 9pfs 'synth' fileystem driver, which is a very simple and purely simulated (in RAM only) filesystem. There are issues though where the 'synth' fs driver is not sufficient. For example the following two bugs need test cases running the 9pfs 'local' fs driver: https://bugs.launchpad.net/qemu/+bug/1336794 https://bugs.launchpad.net/qemu/+bug/1877384 This patch set for that reason introduces 9pfs test cases using the 9pfs 'local' filesystem driver along to the already existing tests on 'synth'. ---------------------------------------------------------------- Christian Schoenebeck (5): tests/9pfs: change qtest name prefix to synth tests/9pfs: introduce local tests tests/9pfs: wipe local 9pfs test directory tests/9pfs: add virtio_9p_test_path() tests/9pfs: add local Tmkdir test tests/qtest/libqos/virtio-9p.c | 100 +++++++++++++++++++++ tests/qtest/libqos/virtio-9p.h | 10 +++ tests/qtest/virtio-9p-test.c | 197 ++++++++++++++++++++++++++++++++++++----- 3 files changed, 286 insertions(+), 21 deletions(-)