From patchwork Mon Jan 21 12:50:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 14174 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 52F0123E08 for ; Mon, 21 Jan 2013 12:51:04 +0000 (UTC) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by fiordland.canonical.com (Postfix) with ESMTP id 08F46A18850 for ; Mon, 21 Jan 2013 12:51:03 +0000 (UTC) Received: by mail-vc0-f175.google.com with SMTP id fw7so2919845vcb.34 for ; Mon, 21 Jan 2013 04:51:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=b4RGZkS5yPGGXv2hwGqyXpyFXjyXjeC/z6eQ+5pmYMU=; b=YCC1cNH2OkBC4ZMGmCWmZMV/Pf/YzLBf1eOhAyrG6lsb7b1RtAl9vBHsayN5McbTqb EJnhKR9jDWiHuWGCzasmxy5iKgbyFColhdR1j9/kt8pVC1XjjX/mHOZSsvT0B1j8i9Y9 FaV3yQgI+oXE4U8wekndl2r2xjcews9F85zXQm5kDLwQqNYB8an0L0ZiaWrkVU4m8Tgl vce7dppzQ4KjFYtQnA6MlxBkdjzGCpIW/PtftKcfZqZjs7Ltvg5XAUxHL8AqyE8xGzmC 6GOt059hh4sK7XTlGOg7pqmvfAlsv9PnHYHyWbpfZzbSNlPJ/GwWQWNUluAx6ETp0BpX HGnw== X-Received: by 10.220.154.199 with SMTP id p7mr19011097vcw.48.1358772663579; Mon, 21 Jan 2013 04:51:03 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp199549veb; Mon, 21 Jan 2013 04:51:02 -0800 (PST) X-Received: by 10.112.40.197 with SMTP id z5mr7289712lbk.14.1358772659105; Mon, 21 Jan 2013 04:50:59 -0800 (PST) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id tt2si1781630lab.230.2013.01.21.04.50.58 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 04:50:58 -0800 (PST) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1TxGq1-0001w3-5A; Mon, 21 Jan 2013 12:50:57 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Blue Swirl Subject: [PATCH 5/6] hw/smc91c111: Add explicit 'return' rather than relying on fallthrough Date: Mon, 21 Jan 2013 12:50:55 +0000 Message-Id: <1358772656-7406-6-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1358772656-7406-1-git-send-email-peter.maydell@linaro.org> References: <1358772656-7406-1-git-send-email-peter.maydell@linaro.org> X-Gm-Message-State: ALoCoQllfereZkE1nuSoUcWev4BUQV8bwhMZsWFiwN7bevezGBEqIy6CKJeTGZz8zuvEvq292qTd Add an explicit 'return' statement to a case in smc91c111_readb rather than relying on fallthrough to the following case's return statement, for code clarity and to placate static analysers. Signed-off-by: Peter Maydell --- hw/smc91c111.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/smc91c111.c b/hw/smc91c111.c index a34698f..b605069 100644 --- a/hw/smc91c111.c +++ b/hw/smc91c111.c @@ -442,6 +442,7 @@ static void smc91c111_writeb(void *opaque, hwaddr offset, return; case 12: /* Early receive. */ s->ercv = value & 0x1f; + return; case 13: /* Ignore. */ return;