From patchwork Tue Jun 3 17:29:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 31330 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f200.google.com (mail-ob0-f200.google.com [209.85.214.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2F13020AE6 for ; Tue, 3 Jun 2014 17:29:05 +0000 (UTC) Received: by mail-ob0-f200.google.com with SMTP id wo20sf35737619obc.11 for ; Tue, 03 Jun 2014 10:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=p1Nfphpz5Sv1bPtdI3kUZLybBzlHoXLHc1T3alZjrtw=; b=fBgNwF1bFSPrR0IRPrpnZTnUGAN8xSe+tLny2a2H8HuehSJtxwZNcc301GfWw+j5vP 6c163yoky+eq4Tczumk9DhK+bMU9wguCDlJC7txYEqlgMvf3JUDYv29lrQPfkyQkkCwa nxUsEP49VWlwd4aq4V5EtRgh8bY8Cj/gRnTO12UGvQJqpTYirrI78Ml0EAnZJ1idcwso 16M2eqA+9svwDLNo6Ej5vJKq8uaEFIVV1w/J78u8Z//SRQpr2HP8hzT5cvitLc0HYuBv vBOrQJbk37n5wesKvMNPHtGlFAWPED0mWsLkCmmcpi3jrDyU4hTTpysLvLYIlRttf0WV U2JA== X-Gm-Message-State: ALoCoQlUCfGAUyHwYdJyRwjyCUPgy3uvg3ODOlxJyBUwejM9jdbsPkS0tuYg0b4Eqp56fASpXy8M X-Received: by 10.182.80.40 with SMTP id o8mr6341510obx.35.1401816544730; Tue, 03 Jun 2014 10:29:04 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.98.225 with SMTP id o88ls2623750qge.88.gmail; Tue, 03 Jun 2014 10:29:04 -0700 (PDT) X-Received: by 10.52.22.13 with SMTP id z13mr32486132vde.10.1401816544559; Tue, 03 Jun 2014 10:29:04 -0700 (PDT) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) by mx.google.com with ESMTPS id m20si8829314vdh.71.2014.06.03.10.29.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Jun 2014 10:29:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.180 as permitted sender) client-ip=209.85.220.180; Received: by mail-vc0-f180.google.com with SMTP id hq11so5197872vcb.39 for ; Tue, 03 Jun 2014 10:29:04 -0700 (PDT) X-Received: by 10.58.2.74 with SMTP id 10mr3330492ves.61.1401816544355; Tue, 03 Jun 2014 10:29:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp13218vcb; Tue, 3 Jun 2014 10:29:03 -0700 (PDT) X-Received: by 10.180.79.9 with SMTP id f9mr34637672wix.52.1401816543468; Tue, 03 Jun 2014 10:29:03 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id ew15si29745902wid.10.2014.06.03.10.29.02 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 03 Jun 2014 10:29:03 -0700 (PDT) Received-SPF: none (google.com: pm215@archaic.org.uk does not designate permitted sender hosts) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WrsWD-0000P1-3E; Tue, 03 Jun 2014 18:29:01 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org Subject: [PATCH] hw/sd/sd.c: Drop unused sd_acmd_type[] array Date: Tue, 3 Jun 2014 18:29:01 +0100 Message-Id: <1401816541-1522-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Drop the sd_acmd_type[] array: it is never used. (The equivalent sd_cmd_type[] array for normal commands is used to identify those commands whose argument includes the card address in the top 16 bits; but for app commands the card address is passed with the APP_CMD prefix, not with the argument to the app command itself.) Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- clang 3.4 warns about this unused variable. If we ever turn out to need the information it's all in the sd card spec anyway. hw/sd/sd.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 4502ad1..5efe8c1 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -151,17 +151,6 @@ static const sd_cmd_type_t sd_cmd_type[64] = { sd_adtc, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, }; -static const sd_cmd_type_t sd_acmd_type[64] = { - sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_ac, sd_none, - sd_none, sd_none, sd_none, sd_none, sd_none, sd_adtc, sd_none, sd_none, - sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_adtc, sd_ac, - sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, - sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, - sd_none, sd_bcr, sd_ac, sd_none, sd_none, sd_none, sd_none, sd_none, - sd_none, sd_none, sd_none, sd_adtc, sd_none, sd_none, sd_none, sd_none, - sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, sd_none, -}; - static const int sd_cmd_class[64] = { 0, 0, 0, 0, 0, 9, 10, 0, 0, 0, 0, 1, 0, 0, 0, 0, 2, 2, 2, 2, 3, 3, 3, 3, 4, 4, 4, 4, 6, 6, 6, 6,