From patchwork Thu Feb 12 02:59:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Bellows X-Patchwork-Id: 44582 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D7F2621527 for ; Thu, 12 Feb 2015 03:02:20 +0000 (UTC) Received: by mail-lb0-f200.google.com with SMTP id u10sf4666471lbd.3 for ; Wed, 11 Feb 2015 19:02:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=O5rHkCu2QMHxwlFY/U0dRBfWiritGaKToMejf2HPIiw=; b=UAfaI6FSXy7X2qILVm1zi2RPOaRX4mYjyIMzlz8R9gXUzYjkeXAFHN74G8I8jtmB3F A0jM5n9wHBTNUwy/XdwSXlyPN7tpRHYX7XIGRnSKtexIXc1QPRGm9FliXQOKxTjhhpvR 6DojhWLVz+8yYc/UCmurawnxK4SOX7EDphGAPBM620EK5HYKoU9iFUmD3Z63jLHwe7a8 7/b8Vn2xZUNTcoeqV/AoBBQP5IJbTnWPpN73JOuYXvQSpEcoOMwVrpufaoQoiOtkMgAX I3/X0rZNXcBSFnybpgsDEsD5kbMgJuhhwHwRr8oNFKfXj/yc2sPu1Lvmoi3GyLmna6Zu jXGg== X-Gm-Message-State: ALoCoQk/FWQVaDxo/rEIoHT3A88V6be3l+aXyag/ItvIpQmVYVSGH+AbtT2UsL0DZNeut/+d+xze X-Received: by 10.152.29.34 with SMTP id g2mr202671lah.1.1423710139836; Wed, 11 Feb 2015 19:02:19 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.135 with SMTP id s7ls148759las.39.gmail; Wed, 11 Feb 2015 19:02:19 -0800 (PST) X-Received: by 10.152.29.166 with SMTP id l6mr1422828lah.78.1423710139460; Wed, 11 Feb 2015 19:02:19 -0800 (PST) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com. [209.85.217.172]) by mx.google.com with ESMTPS id p1si1959814lbm.107.2015.02.11.19.02.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 19:02:19 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.172 as permitted sender) client-ip=209.85.217.172; Received: by mail-lb0-f172.google.com with SMTP id p9so6205503lbv.3 for ; Wed, 11 Feb 2015 19:02:19 -0800 (PST) X-Received: by 10.152.28.227 with SMTP id e3mr1219858lah.117.1423710139347; Wed, 11 Feb 2015 19:02:19 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp177944lbj; Wed, 11 Feb 2015 19:02:18 -0800 (PST) X-Received: by 10.140.96.201 with SMTP id k67mr4397995qge.102.1423710137923; Wed, 11 Feb 2015 19:02:17 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q67si3515074qgd.39.2015.02.11.19.02.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 11 Feb 2015 19:02:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:47960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLk2j-0000Kd-12 for patch@linaro.org; Wed, 11 Feb 2015 22:02:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLk0H-0005DE-1J for qemu-devel@nongnu.org; Wed, 11 Feb 2015 21:59:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLk0D-0007g2-1o for qemu-devel@nongnu.org; Wed, 11 Feb 2015 21:59:44 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:35692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLk0C-0007fr-Rs for qemu-devel@nongnu.org; Wed, 11 Feb 2015 21:59:40 -0500 Received: by pdbfl12 with SMTP id fl12so8752432pdb.2 for ; Wed, 11 Feb 2015 18:59:40 -0800 (PST) X-Received: by 10.70.101.136 with SMTP id fg8mr2637805pdb.65.1423709980281; Wed, 11 Feb 2015 18:59:40 -0800 (PST) Received: from localhost.localdomain ([210.177.145.249]) by mx.google.com with ESMTPSA id fy8sm2140272pdb.42.2015.02.11.18.59.37 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Feb 2015 18:59:39 -0800 (PST) From: Greg Bellows To: qemu-devel@nongnu.org, peter.maydell@linaro.org, christoffer.dall@linaro.org, alex.bennee@linaro.org Date: Thu, 12 Feb 2015 10:59:06 +0800 Message-Id: <1423709948-7662-3-git-send-email-greg.bellows@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1423709948-7662-1-git-send-email-greg.bellows@linaro.org> References: <1423709948-7662-1-git-send-email-greg.bellows@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.180 Cc: edgar.iglesias@gmail.com, Greg Bellows , a.spyridakis@virtualopensystems.com Subject: [Qemu-devel] [PATCH v5 2/4] target-arm: Add feature parsing to virt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: greg.bellows@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v3 -> v4 - Fix misspelling v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 34d9379..3c37a5e 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -602,15 +602,19 @@ static void machvirt_init(MachineState *machine) MemoryRegion *ram = g_new(MemoryRegion, 1); const char *cpu_model = machine->cpu_model; VirtBoardInfo *vbi; + char **cpustr; if (!cpu_model) { cpu_model = "cortex-a15"; } - vbi = find_machine_info(cpu_model); + /* Separate the actual CPU model name from any appended features */ + cpustr = g_strsplit(cpu_model, ",", 2); + + vbi = find_machine_info(cpustr[0]); if (!vbi) { - error_report("mach-virt: CPU %s not supported", cpu_model); + error_report("mach-virt: CPU %s not supported", cpustr[0]); exit(1); } @@ -624,8 +628,10 @@ static void machvirt_init(MachineState *machine) create_fdt(vbi); for (n = 0; n < smp_cpus; n++) { - ObjectClass *oc = cpu_class_by_name(TYPE_ARM_CPU, cpu_model); + ObjectClass *oc = cpu_class_by_name(TYPE_ARM_CPU, cpustr[0]); + CPUClass *cc = CPU_CLASS(oc); Object *cpuobj; + Error *err = NULL; if (!oc) { fprintf(stderr, "Unable to find CPU definition\n"); @@ -633,6 +639,13 @@ static void machvirt_init(MachineState *machine) } cpuobj = object_new(object_class_get_name(oc)); + /* Handle any CPU options specified by the user */ + cc->parse_features(CPU(cpuobj), cpustr[1], &err); + if (err) { + error_report("%s", error_get_pretty(err)); + exit(1); + } + if (!vms->secure) { object_property_set_bool(cpuobj, false, "has_el3", NULL); } @@ -652,6 +665,7 @@ static void machvirt_init(MachineState *machine) object_property_set_bool(cpuobj, true, "realized", NULL); } + g_strfreev(cpustr); fdt_add_timer_nodes(vbi); fdt_add_cpu_nodes(vbi); fdt_add_psci_node(vbi);