| Message ID | 160309729609.2739814.4996614957953215591.stgit@bahia.lan |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spapr: Error handling fixes and cleanups (round 3) | expand |
On 10/19/20 10:48 AM, Greg Kurz wrote: > The PC_DIMM_ADDR_PROP property is defined as: > > DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), > > Use object_property_get_uint() instead of object_property_get_int(). > > Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/ppc/spapr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 4edd31b86915..115fc52e3b06 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -3572,8 +3572,8 @@ static SpaprDimmState *spapr_recover_pending_dimm_state(SpaprMachineState *ms, > uint64_t addr_start, addr; > int i; > > - addr_start = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP, > - &error_abort); > + addr_start = object_property_get_uint(OBJECT(dimm), PC_DIMM_ADDR_PROP, > + &error_abort); > > addr = addr_start; > for (i = 0; i < nr_lmbs; i++) { > > >
On Mon, Oct 19, 2020 at 10:48:16AM +0200, Greg Kurz wrote: > The PC_DIMM_ADDR_PROP property is defined as: > > DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), > > Use object_property_get_uint() instead of object_property_get_int(). > > Signed-off-by: Greg Kurz <groug@kaod.org> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/ppc/spapr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 4edd31b86915..115fc52e3b06 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -3572,8 +3572,8 @@ static SpaprDimmState *spapr_recover_pending_dimm_state(SpaprMachineState *ms, > uint64_t addr_start, addr; > int i; > > - addr_start = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP, > - &error_abort); > + addr_start = object_property_get_uint(OBJECT(dimm), PC_DIMM_ADDR_PROP, > + &error_abort); > > addr = addr_start; > for (i = 0; i < nr_lmbs; i++) { > > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 4edd31b86915..115fc52e3b06 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3572,8 +3572,8 @@ static SpaprDimmState *spapr_recover_pending_dimm_state(SpaprMachineState *ms, uint64_t addr_start, addr; int i; - addr_start = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP, - &error_abort); + addr_start = object_property_get_uint(OBJECT(dimm), PC_DIMM_ADDR_PROP, + &error_abort); addr = addr_start; for (i = 0; i < nr_lmbs; i++) {
The PC_DIMM_ADDR_PROP property is defined as: DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), Use object_property_get_uint() instead of object_property_get_int(). Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/ppc/spapr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)