From patchwork Mon Feb 6 15:31:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 93452 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1759334qgi; Mon, 6 Feb 2017 07:43:31 -0800 (PST) X-Received: by 10.55.43.149 with SMTP id r21mr10809739qkr.123.1486395811379; Mon, 06 Feb 2017 07:43:31 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r33si730599qta.325.2017.02.06.07.43.31 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 06 Feb 2017 07:43:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1calRz-0006fQ-19 for patch@linaro.org; Mon, 06 Feb 2017 10:43:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1calGD-0005rv-0L for qemu-devel@nongnu.org; Mon, 06 Feb 2017 10:31:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1calGB-00005i-Qk for qemu-devel@nongnu.org; Mon, 06 Feb 2017 10:31:20 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:34989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1calGB-000054-KD for qemu-devel@nongnu.org; Mon, 06 Feb 2017 10:31:19 -0500 Received: by mail-wm0-x22c.google.com with SMTP id b65so125315764wmf.0 for ; Mon, 06 Feb 2017 07:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1KXA5KwXZSok3ABWG8NWl4fzC0thcYoHp+qAltY0myc=; b=G+r6tYfWGbpazId1cx673di5YnF6NHMtbTQMMiMwg2Uw3YbA3QqR3JktDSkrWBdweq nPT7dEO6VNnRX7j5dGy1Ukl4l4RTPkYwYtwJBN0pCbGhaq7HxcU+uRIYN7zInicauwS7 X4KF2CyhfbtxAcGKiEnDjIEcrvdZMbXBd0i2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1KXA5KwXZSok3ABWG8NWl4fzC0thcYoHp+qAltY0myc=; b=lOvkK1T7KLkog2Br8KGVJquYT5lKAqT3CSMKxf75Mu0oL7AHGrIRzBKDHDsByo02Qe KbCDEJN8D28lb3FMfJ7tPxRH2wYJS7ROJrNuH1eYAJPOdeqNXtG7JM/8zIEazkREPDu6 ZiTaglyjOW8ZKHN8Cok+Iw19wD5mbUkx0epHo3Qwex31PZ2/EN8Iiov3Pb6ub/dB+FrK /FD32nFhFZ1MNHAGZjgbJz8EpLAhVUQGApsoEPZt5RNLy0tg8WI4j+wOVv2zGmER1ahH UhrlkwZ5s2j5GW2X5NjulGXNlZx8q4KpUi9QfRvMhgCk2t5oPuSj8QOQMff55bFEvFTu tNsg== X-Gm-Message-State: AMke39k5RtPYJqnwCkvcNIwQ/G8RybsdZPUfoAzupb53KDQyKF/Q2tSx3+WljxOryiK9YuUL X-Received: by 10.223.176.16 with SMTP id f16mr9393548wra.113.1486395078626; Mon, 06 Feb 2017 07:31:18 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id q5sm2073011wrd.32.2017.02.06.07.31.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 07:31:15 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id AAFFD3E2A2E; Mon, 6 Feb 2017 15:31:14 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net Date: Mon, 6 Feb 2017 15:31:04 +0000 Message-Id: <20170206153113.27729-15-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170206153113.27729-1-alex.bennee@linaro.org> References: <20170206153113.27729-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [PATCH v10 14/23] cputlb: tweak qemu_ram_addr_from_host_nofail reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, nikunj@linux.vnet.ibm.com, Peter Crosthwaite , jan.kiszka@siemens.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, cota@braap.org, serge.fdrv@gmail.com, pbonzini@redhat.com, bobby.prani@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= , bamvor.zhangjian@linaro.org, fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This moves the helper function closer to where it is called and updates the error message to report via error_report instead of the deprecated fprintf. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cputlb.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.11.0 diff --git a/cputlb.c b/cputlb.c index af0e65cd2c..94fa9977c5 100644 --- a/cputlb.c +++ b/cputlb.c @@ -246,18 +246,6 @@ void tlb_reset_dirty_range(CPUTLBEntry *tlb_entry, uintptr_t start, } } -static inline ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr) -{ - ram_addr_t ram_addr; - - ram_addr = qemu_ram_addr_from_host(ptr); - if (ram_addr == RAM_ADDR_INVALID) { - fprintf(stderr, "Bad ram pointer %p\n", ptr); - abort(); - } - return ram_addr; -} - void tlb_reset_dirty(CPUState *cpu, ram_addr_t start1, ram_addr_t length) { CPUArchState *env; @@ -469,6 +457,18 @@ static void report_bad_exec(CPUState *cpu, target_ulong addr) log_cpu_state_mask(LOG_GUEST_ERROR, cpu, CPU_DUMP_FPU | CPU_DUMP_CCOP); } +static inline ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr) +{ + ram_addr_t ram_addr; + + ram_addr = qemu_ram_addr_from_host(ptr); + if (ram_addr == RAM_ADDR_INVALID) { + error_report("Bad ram pointer %p", ptr); + abort(); + } + return ram_addr; +} + /* NOTE: this function can trigger an exception */ /* NOTE2: the returned address is not exactly the physical address: it * is actually a ram_addr_t (in system mode; the user mode emulation