From patchwork Tue Jul 11 17:59:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 107411 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp7130obm; Tue, 11 Jul 2017 11:02:36 -0700 (PDT) X-Received: by 10.55.40.218 with SMTP id o87mr1420184qko.50.1499796156073; Tue, 11 Jul 2017 11:02:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499796156; cv=none; d=google.com; s=arc-20160816; b=LZh3vtGVJsDev/fWjYxamEQ2K3rS3PHLg8De+ocV2Gc1FgyHWpNgJgFh4UERJeCxes 2dE4/aDqKF3qdMETEn6q1uIPOgTQ9bi7ChHJKIQnK+rKllxib0NTansJ/h40714kRVbJ MgzlF3h/8/9cGf0GScgqYg/nSnFqF0ZOOvfywucqig1awYs7t1rP7VdIG++UZRlczl0h nim1tHOnlWcPr+wjfsNOhDmIaFx+k/6eSXBFaLa5R9kE1Q08NhpD2hXrqURzKQezFV6n e7WNJtaZPUgYTcN5TerEnwTxxAsW7mdJ5fIJiy3K+wbC4cBJdbAcClvQwLWxO9sIJdLH YFVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=FlaaR0Jjs73VgAMUuW6fKbztHai6vOFa22Y+0NuSm/0=; b=Q/PkhwKAva0PfvkAm5LhiO8fAQQWXia6PoZaecZKGI+RMnxUUAtudM4a2MhLP3f9Cw vVipSExW2Z8A2mIm8P3n/9MBLkrMoiTf3fxMurtFGsrABEQAKjt8s44g3VJKw8S2GXNn D4DjqDXzIfZp9TDCQYzJiz189RB97iXUwa/wla+Y6/SJfbuoeAmFlZIJI7vQeytD2EdM JueDU2RsV1WVsqEvvLpRx7AUOS1TsX+S5+st8K8IaoptJhtvL0d7/bBcGXAWIowpGVYf nZWCKFjVDGEgsxcLe/Vpt+jT7e2pGPUAkte+nm7Uv95UA4cGlKNV97Q5oqByWx/npJpJ BLBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.b=TnvEeZTD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id t64si510765qka.249.2017.07.11.11.02.35 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 11 Jul 2017 11:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.b=TnvEeZTD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUzUX-0003Re-BU for patch@linaro.org; Tue, 11 Jul 2017 14:02:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUzSr-0002UN-DB for qemu-devel@nongnu.org; Tue, 11 Jul 2017 14:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUzSn-0005Dk-9z for qemu-devel@nongnu.org; Tue, 11 Jul 2017 14:00:49 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:34676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUzSm-0005CE-PO for qemu-devel@nongnu.org; Tue, 11 Jul 2017 14:00:45 -0400 Received: by mail-wr0-f175.google.com with SMTP id 77so9556886wrb.1 for ; Tue, 11 Jul 2017 11:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlaaR0Jjs73VgAMUuW6fKbztHai6vOFa22Y+0NuSm/0=; b=TnvEeZTDRhKZgNFqUkHnAKEPhIfyol8wPxZ2lJrmmHfM3VRpg5cRU+y700e89l05aN A28VdGUDbGkQuHbBjVidXcaK5ipNf6L3WQywyNJX6vK26pOARyWKhNKQ/Suo7VMESPT+ CL+o3pElKmZ0LyKMPb03TOBd5swC2PCoHcIl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlaaR0Jjs73VgAMUuW6fKbztHai6vOFa22Y+0NuSm/0=; b=mlkqQPLQlX+2NewoY4mOH/q1vseLSl09nRGEj+fj4xn3NqfkhPfoMcKdnvU454X5t/ K3iA1IvkdPpgbLVb8PT7jQNZT40zfDihjEx0YrYM9ywLFt0UjTmfB4IvPMn/K1M6+feL FZZNbquQRTAhkr8+Xa6QgbXDh1yeEakya7xYSk0J2A1EK51Ds7YCOPoWNymsBsypm71C jwLKcWt6xJ6WEX2O2HgUOBzQp+BmrtWfPdKOaRJZnLuQ2OZ8msfDKrEaYQR6nV3AbvRq 7nHsLByWXOV5RzxzJ7x8TmgCPjxNEo76FJ7ngUHIHiAS4552HIt0p89BxXp9m7iARnMp WDWw== X-Gm-Message-State: AIVw111uJwtl5rGbopFXOZsyf+bhiT73LmrHMmYd0yrX3kvrUlgS19LB SLbLAiK5aIUeByGn X-Received: by 10.223.146.161 with SMTP id 30mr689991wrn.164.1499795983590; Tue, 11 Jul 2017 10:59:43 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id g63sm661442wrd.11.2017.07.11.10.59.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 10:59:40 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 27BEE3E0C03; Tue, 11 Jul 2017 18:59:38 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net, cota@braap.org Date: Tue, 11 Jul 2017 18:59:34 +0100 Message-Id: <20170711175937.23140-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170711175937.23140-1-alex.bennee@linaro.org> References: <20170711175937.23140-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.175 Subject: [Qemu-devel] [PATCH v3 3/6] target/arm/translate.h: expand comment on DISAS_EXIT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:ARM" , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We already have an exit condition, DISAS_UPDATE which will exit the run-loop. Expand on the difference with DISAS_EXIT in the comments. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- target/arm/translate.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.13.0 Reviewed-by: Emilio G. Cota diff --git a/target/arm/translate.h b/target/arm/translate.h index 15d383d9af..12fd79ba8e 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -140,7 +140,10 @@ static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) */ #define DISAS_BX_EXCRET 11 /* For instructions which want an immediate exit to the main loop, - * as opposed to attempting to use lookup_and_goto_ptr. + * as opposed to attempting to use lookup_and_goto_ptr. Unlike + * DISAS_UPDATE this doesn't write the PC on exiting the translation + * loop so you need to ensure something (gen_a64_set_pc_im or runtime + * helper) has done so before we reach return from cpu_tb_exec. */ #define DISAS_EXIT 12