From patchwork Tue Nov 21 21:25:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 119406 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5814362qgn; Tue, 21 Nov 2017 13:31:33 -0800 (PST) X-Google-Smtp-Source: AGs4zMbhbqxmSl7x5B3htLYjZQqHb0i2eSWOR0kw8IPx+vrzeLCx2ePgIIhqUtdaNaqEanHC+vyL X-Received: by 10.37.113.4 with SMTP id m4mr7470483ybc.206.1511299893622; Tue, 21 Nov 2017 13:31:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511299893; cv=none; d=google.com; s=arc-20160816; b=AEjrQWrIoskDa/hUgwoqCwLBWgRXGenECbUpnE8vVhkBUMUHHtVX5Z0/rNHOuXQuiD pLg3R6PNP5vwhT4yrF3SQ+IRl69OyiOIBmNJvjN5Y4xYf+jo8DsinMJJ8KOMpXczrAm5 4a9N/R6/N0QDarKyA4ywkOPXZQ7UltBe3/9WxhXK4sbLt2JvUKfp2UXfsvZyfPNYQRCB gffWMU6VyRsKhi0VWYGA0p16JuiSYZplEXxBIkixjxoPzhAvTFkjMB6+3dLCDy+f+QW3 e/Yyuo4Ud6G6O4EP4+4/ljUpieoHDUmpbmcCwLst5QF4z9GQKPt7WeeGO/9dBbsBBMvI F0Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=hQ/lP9KQaCheo4UPX9JOhyv6XEAkTWCkibaqYs2X2J8=; b=e9UkvyNp/5ddcTkmr7WVFgpDQhj4iqgvnV8CMlwTf8ceyua+QOf14ELnfLzM8KLAH8 BYbfbAoHZJuzGxmgvEICFpGnOY09ackAMfQNe75vcXlbpPpM0g/agkOnYTbKY3dKZaDV P8Ek0PMR+MbsFDJsEpU0JaeZF7vtx6luDnsxXGSjnqz1XvTeG3jy/LfzDUXwOXVr0Ixe vANWaDXDkyM3V0pWuh2txq3xS0agorFopGTE1kT9e6djElN9vbi/I7IAW0C5DJTp2aTR DGF6xuiZxDjdQgGtt5QQAVr+DBAN90pRNnaVHN78NbVJiFdNVd9yo9ePJMlerV4mVwPI +d3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=a328D2hY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id e130si3149071ywh.691.2017.11.21.13.31.33 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 21 Nov 2017 13:31:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=a328D2hY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36587 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHG8j-0006Sf-2c for patch@linaro.org; Tue, 21 Nov 2017 16:31:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHG5A-0004Ok-Nk for qemu-devel@nongnu.org; Tue, 21 Nov 2017 16:27:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHG59-0007jF-KW for qemu-devel@nongnu.org; Tue, 21 Nov 2017 16:27:52 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:38918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHG59-0007ie-Ci for qemu-devel@nongnu.org; Tue, 21 Nov 2017 16:27:51 -0500 Received: by mail-wm0-x243.google.com with SMTP id x63so6255618wmf.4 for ; Tue, 21 Nov 2017 13:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=hQ/lP9KQaCheo4UPX9JOhyv6XEAkTWCkibaqYs2X2J8=; b=a328D2hYF+BNV/h1W16BdCIyOruiWN6SE3xTVS0PJZzlbEoZoVp+s5646/4zswHr50 +kRgoGxeB6iUeJm+twcF/4o4qH76M029e/GG0p1zG7LKJtjJpeTDnGVk6lGAToNY8Txy m4SgkFonpW0+SlsddxEwCUKAUKtf3pJ3CQeWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=hQ/lP9KQaCheo4UPX9JOhyv6XEAkTWCkibaqYs2X2J8=; b=akIMAa49JFDmfa9EoyE3+OBbTgnLdivdK3OTj4ZfYivbTYIDci/XU4GrNU+GvX3BLL ZZKyVnZ5SctY6mgCvCwtPGD0vDEuki4rx28RdN1OHXa3S5zYwkmajCJZrQExLFfS9FDR NkOsXmUmEV8Mpe2al3sscLTxOB9zH+J425L6vxlj4atJ0oYMWQ4SjL6nmgW/CCLihinx WbuYRXE4LhpjDnS2ZyXlatGZabLljP5SCW716/6PH4a0AtM/IWLfp47SiK7BK0yy3dgM v+tdqNeK2hWZDlx2ZVICuQmXPB3lQUyj1CFAzaJ4sUaXfwxeR56Bk9SeaI66DHI+kVN/ pX0Q== X-Gm-Message-State: AJaThX632/x9bHc1UCNKOvAoE90TQaWKvW+RmhVaINXd5U38pTbfS49w 2vPE/S1juf2U1/fzhpTRoeINNnOIA6U= X-Received: by 10.28.14.195 with SMTP id 186mr2384135wmo.56.1511299670144; Tue, 21 Nov 2017 13:27:50 -0800 (PST) Received: from cloudburst.twiddle.net (70.red-37-158-60.dynamicip.rima-tde.net. [37.158.60.70]) by smtp.gmail.com with ESMTPSA id e124sm706517wmg.34.2017.11.21.13.27.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Nov 2017 13:27:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 21 Nov 2017 22:25:19 +0100 Message-Id: <20171121212534.5177-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171121212534.5177-1-richard.henderson@linaro.org> References: <20171121212534.5177-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PATCH v6 11/26] target/arm: Use vector infrastructure for aa64 dup/movi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 83 +++++++++++++++++++--------------------------- 1 file changed, 34 insertions(+), 49 deletions(-) -- 2.13.6 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index bc14c28e71..55a4902fc2 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5846,38 +5846,24 @@ static void disas_simd_across_lanes(DisasContext *s, uint32_t insn) * * size: encoded in imm5 (see ARM ARM LowestSetBit()) */ + static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64) / esize; - int index, i; - TCGv_i64 tmp; + int index = imm5 >> (size + 1); if (size > 3 || (size == 3 && !is_q)) { unallocated_encoding(s); return; } - if (!fp_access_check(s)) { return; } - index = imm5 >> (size + 1); - - tmp = tcg_temp_new_i64(); - read_vec_element(s, tmp, rn, index, size); - - for (i = 0; i < elements; i++) { - write_vec_element(s, tmp, rd, i, size); - } - - if (!is_q) { - clear_vec_high(s, rd); - } - - tcg_temp_free_i64(tmp); + tcg_gen_gvec_dup_mem(size, vec_full_reg_offset(s, rd), + vec_reg_offset(s, rn, index, size), + is_q ? 16 : 8, vec_full_reg_size(s)); } /* DUP (element, scalar) @@ -5926,9 +5912,7 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64)/esize; - int i = 0; + uint32_t dofs, oprsz, maxsz; if (size > 3 || ((size == 3) && !is_q)) { unallocated_encoding(s); @@ -5939,12 +5923,11 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, return; } - for (i = 0; i < elements; i++) { - write_vec_element(s, cpu_reg(s, rn), rd, i, size); - } - if (!is_q) { - clear_vec_high(s, rd); - } + dofs = vec_full_reg_offset(s, rd); + oprsz = is_q ? 16 : 8; + maxsz = vec_full_reg_size(s); + + tcg_gen_gvec_dup_i64(size, dofs, oprsz, maxsz, cpu_reg(s, rn)); } /* INS (Element) @@ -6135,7 +6118,6 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) bool is_neg = extract32(insn, 29, 1); bool is_q = extract32(insn, 30, 1); uint64_t imm = 0; - TCGv_i64 tcg_rd, tcg_imm; int i; if (o2 != 0 || ((cmode == 0xf) && is_neg && !is_q)) { @@ -6217,32 +6199,35 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) imm = ~imm; } - tcg_imm = tcg_const_i64(imm); - tcg_rd = new_tmp_a64(s); + if (!((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9)) { + /* MOVI or MVNI, with MVNI negation handled above. */ + tcg_gen_gvec_dup64i(vec_full_reg_offset(s, rd), is_q ? 16 : 8, + vec_full_reg_size(s), imm); + } else { + TCGv_i64 tcg_imm = tcg_const_i64(imm); + TCGv_i64 tcg_rd = new_tmp_a64(s); - for (i = 0; i < 2; i++) { - int foffs = i ? fp_reg_hi_offset(s, rd) : fp_reg_offset(s, rd, MO_64); + for (i = 0; i < 2; i++) { + int foffs = vec_reg_offset(s, rd, i, MO_64); - if (i == 1 && !is_q) { - /* non-quad ops clear high half of vector */ - tcg_gen_movi_i64(tcg_rd, 0); - } else if ((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9) { - tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); - if (is_neg) { - /* AND (BIC) */ - tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + if (i == 1 && !is_q) { + /* non-quad ops clear high half of vector */ + tcg_gen_movi_i64(tcg_rd, 0); } else { - /* ORR */ - tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); + if (is_neg) { + /* AND (BIC) */ + tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + } else { + /* ORR */ + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + } } - } else { - /* MOVI */ - tcg_gen_mov_i64(tcg_rd, tcg_imm); + tcg_gen_st_i64(tcg_rd, cpu_env, foffs); } - tcg_gen_st_i64(tcg_rd, cpu_env, foffs); - } - tcg_temp_free_i64(tcg_imm); + tcg_temp_free_i64(tcg_imm); + } } /* AdvSIMD scalar copy