From patchwork Tue Jan 16 03:33:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 124594 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp877739lje; Mon, 15 Jan 2018 19:46:24 -0800 (PST) X-Google-Smtp-Source: ACJfBotQRRTkFrcxpES3m/TzPO3WZYwfOadF0xCQNzNBD4txarjR9Ga/GIIQsJXPKMIqO4J3S7Ux X-Received: by 10.37.129.7 with SMTP id o7mr7873787ybk.259.1516074384634; Mon, 15 Jan 2018 19:46:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516074384; cv=none; d=google.com; s=arc-20160816; b=jj2Reiky6K/vtKp9PZTk1wUSy4dpsKK3gVxReuqOnTXWNkzKuAMm63KYtf1AvrOVw6 niA5KxsYF5LpAYxd0WIwpmBAMRgV4thmnPGEqKJLyLn9xfkSBGQdfSZKzh/8Q8WOlh3V kDIuM2JBV3dtKb9Pz1h+BeRJiQgg9HN3CN215Q+qRrjlCQUkwrvCDnuKIKEWV3muX28j g62cquBJq7rmy4/lYCHuOjju8ec+/9rhNTIitWQD8kcr4EbhhE/6ju2s7tjX9x9T+5Os R8QpJ3OYgmRfuuVz0KlNcwNxKzOTbK+16TmEDalySvnC8klzw1ZzSqEV6Y71Kkh6/dGV Hzlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=okhsN7PvAI2tSwB7zlFXSFL3pRM/854PTOSz2h1XJ54=; b=o7XCC58cIEqEuFi5copYHKzjcoEZrwBLYzCKb09QUTHWaICTSKnuub2PUxTYqe7Kd/ Zkp+U0TrLLWa3bLMU83kdfzNdD5mnvGYC4VQgXcf7+A+9C/UQ8mbcbcwIs60TcgCf3vh 21AABO9KaEDPRMTfhKvxKWXQakiJgSeZMutowRsVCUzzW0mB9uc0HTVMzcvpIDXra+0a tk+cFf9UmCeW4Bhzt5ONL/UbdkQvMbTVMZJ7U1CNdGsqZ7aU+eQbHVtDO5sdw52viAKA Us7GXWwMmS4wgxb79+1FZY5scAntRm9k7i7rLxSLXom7mKhThfgbzJ+wh24kLlsm5FHv V/aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ab0/MXTs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 17si272860ywk.247.2018.01.15.19.46.24 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 15 Jan 2018 19:46:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ab0/MXTs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebICd-0006b8-TA for patch@linaro.org; Mon, 15 Jan 2018 22:46:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebI1a-0005MH-Hi for qemu-devel@nongnu.org; Mon, 15 Jan 2018 22:34:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebI1Z-0003O2-LB for qemu-devel@nongnu.org; Mon, 15 Jan 2018 22:34:58 -0500 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:39946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebI1Z-0003Nr-Cm for qemu-devel@nongnu.org; Mon, 15 Jan 2018 22:34:57 -0500 Received: by mail-pl0-x243.google.com with SMTP id 62so5125549pld.7 for ; Mon, 15 Jan 2018 19:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=okhsN7PvAI2tSwB7zlFXSFL3pRM/854PTOSz2h1XJ54=; b=ab0/MXTsK9m/MZSI21BAmC5gvhJ4Z8vH8EWBxiB56W0KpsF4wA4XzhvjmGi/fxU9DG JstNH5zN/V4qwshLJQCU9HzFZMqA5rIfm3ru1xua2DfZsQnAztJ1vYFgkXi1SNnSFb9S xuPtV9V0Ruf0gGXdCI9q64sfAshXwmzJTd8PA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=okhsN7PvAI2tSwB7zlFXSFL3pRM/854PTOSz2h1XJ54=; b=uJGfaHhA/sG29m1vWtuByz+s6JdxRXoYzEyGbyRXpxDb2hcTayDdLzvsQyEwI6/OGu xpjyQ30iXw8rbS03/k1g659UwsjMvUyinyX7FdqCfnGw1KNwhBvAdrEKll7hzer0xFCY 3/oy4dp2csE6OnOXGqomOpSBFic2USeDbG5fzHH1yinywvf7IRxxJo0H3qGMPgVbsrCK J9w2i9A9/T6xJdi03KETqcd7NLwQFJuq5aqysRPJx8PMx3RpsvGvOgAXr/Md26TzOISP NGnXrFAS9aFNXuotZK8mzdI1rDUuTyE5BLVk16amdBUpc4hGO/szPTF7zedfG81qYjt0 yEzw== X-Gm-Message-State: AKGB3mJR9w7kYHDD5OiLoSOCpfWy7PHXIMGyqZlTM7HQug/KGtHPrHW/ wq5g7CVoU8kE9E1U7ySf+ZHLJUKyjjk= X-Received: by 10.84.128.106 with SMTP id 97mr32873782pla.73.1516073696072; Mon, 15 Jan 2018 19:34:56 -0800 (PST) Received: from cloudburst.twiddle.net.com (24-181-135-57.dhcp.knwc.wa.charter.com. [24.181.135.57]) by smtp.gmail.com with ESMTPSA id c83sm1281024pfk.8.2018.01.15.19.34.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jan 2018 19:34:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 15 Jan 2018 19:33:56 -0800 Message-Id: <20180116033404.31532-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180116033404.31532-1-richard.henderson@linaro.org> References: <20180116033404.31532-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PATCH v9 18/26] target/arm: Use vector infrastructure for aa64 dup/movi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 83 +++++++++++++++++++--------------------------- 1 file changed, 34 insertions(+), 49 deletions(-) -- 2.14.3 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index bc14c28e71..55a4902fc2 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5846,38 +5846,24 @@ static void disas_simd_across_lanes(DisasContext *s, uint32_t insn) * * size: encoded in imm5 (see ARM ARM LowestSetBit()) */ + static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64) / esize; - int index, i; - TCGv_i64 tmp; + int index = imm5 >> (size + 1); if (size > 3 || (size == 3 && !is_q)) { unallocated_encoding(s); return; } - if (!fp_access_check(s)) { return; } - index = imm5 >> (size + 1); - - tmp = tcg_temp_new_i64(); - read_vec_element(s, tmp, rn, index, size); - - for (i = 0; i < elements; i++) { - write_vec_element(s, tmp, rd, i, size); - } - - if (!is_q) { - clear_vec_high(s, rd); - } - - tcg_temp_free_i64(tmp); + tcg_gen_gvec_dup_mem(size, vec_full_reg_offset(s, rd), + vec_reg_offset(s, rn, index, size), + is_q ? 16 : 8, vec_full_reg_size(s)); } /* DUP (element, scalar) @@ -5926,9 +5912,7 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, int imm5) { int size = ctz32(imm5); - int esize = 8 << size; - int elements = (is_q ? 128 : 64)/esize; - int i = 0; + uint32_t dofs, oprsz, maxsz; if (size > 3 || ((size == 3) && !is_q)) { unallocated_encoding(s); @@ -5939,12 +5923,11 @@ static void handle_simd_dupg(DisasContext *s, int is_q, int rd, int rn, return; } - for (i = 0; i < elements; i++) { - write_vec_element(s, cpu_reg(s, rn), rd, i, size); - } - if (!is_q) { - clear_vec_high(s, rd); - } + dofs = vec_full_reg_offset(s, rd); + oprsz = is_q ? 16 : 8; + maxsz = vec_full_reg_size(s); + + tcg_gen_gvec_dup_i64(size, dofs, oprsz, maxsz, cpu_reg(s, rn)); } /* INS (Element) @@ -6135,7 +6118,6 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) bool is_neg = extract32(insn, 29, 1); bool is_q = extract32(insn, 30, 1); uint64_t imm = 0; - TCGv_i64 tcg_rd, tcg_imm; int i; if (o2 != 0 || ((cmode == 0xf) && is_neg && !is_q)) { @@ -6217,32 +6199,35 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) imm = ~imm; } - tcg_imm = tcg_const_i64(imm); - tcg_rd = new_tmp_a64(s); + if (!((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9)) { + /* MOVI or MVNI, with MVNI negation handled above. */ + tcg_gen_gvec_dup64i(vec_full_reg_offset(s, rd), is_q ? 16 : 8, + vec_full_reg_size(s), imm); + } else { + TCGv_i64 tcg_imm = tcg_const_i64(imm); + TCGv_i64 tcg_rd = new_tmp_a64(s); - for (i = 0; i < 2; i++) { - int foffs = i ? fp_reg_hi_offset(s, rd) : fp_reg_offset(s, rd, MO_64); + for (i = 0; i < 2; i++) { + int foffs = vec_reg_offset(s, rd, i, MO_64); - if (i == 1 && !is_q) { - /* non-quad ops clear high half of vector */ - tcg_gen_movi_i64(tcg_rd, 0); - } else if ((cmode & 0x9) == 0x1 || (cmode & 0xd) == 0x9) { - tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); - if (is_neg) { - /* AND (BIC) */ - tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + if (i == 1 && !is_q) { + /* non-quad ops clear high half of vector */ + tcg_gen_movi_i64(tcg_rd, 0); } else { - /* ORR */ - tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + tcg_gen_ld_i64(tcg_rd, cpu_env, foffs); + if (is_neg) { + /* AND (BIC) */ + tcg_gen_and_i64(tcg_rd, tcg_rd, tcg_imm); + } else { + /* ORR */ + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_imm); + } } - } else { - /* MOVI */ - tcg_gen_mov_i64(tcg_rd, tcg_imm); + tcg_gen_st_i64(tcg_rd, cpu_env, foffs); } - tcg_gen_st_i64(tcg_rd, cpu_env, foffs); - } - tcg_temp_free_i64(tcg_imm); + tcg_temp_free_i64(tcg_imm); + } } /* AdvSIMD scalar copy