[v4,11/11] target/arm: Fix sqrt_f16 exception raising

Message ID	20180512003217.9105-12-richard.henderson@linaro.org
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 17:32:17 -0700 Message-Id: <20180512003217.9105-12-richard.henderson@linaro.org> In-Reply-To: <20180512003217.9105-1-richard.henderson@linaro.org> References: <20180512003217.9105-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v4 11/11] target/arm: Fix sqrt_f16 exception raising Precedence: list Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	target/arm: Fixups for ARM_FEATURE_V8_FP16 \| expand [v4,00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16 [v4,01/11] target/arm: Implement FMOV (general) for fp16 [v4,02/11] target/arm: Early exit after unallocated_encoding in disas_fp_int_conv [v4,03/11] target/arm: Implement FCVT (scalar, integer) for fp16 [v4,04/11] target/arm: Implement FCVT (scalar, fixed-point) for fp16 [v4,05/11] target/arm: Introduce and use read_fp_hreg [v4,06/11] target/arm: Implement FP data-processing (2 source) for fp16 [v4,07/11] target/arm: Implement FP data-processing (3 source) for fp16 [v4,08/11] target/arm: Implement FCMP for fp16 [v4,09/11] target/arm: Implement FCSEL for fp16 [v4,10/11] target/arm: Implement FMOV (immediate) for fp16 [v4,11/11] target/arm: Fix sqrt_f16 exception raising

Message ID

20180512003217.9105-12-richard.henderson@linaro.org

State

New

Headers

Received-SPF: pass (google.com: domain of
	qemu-devel-bounces+patch=linaro.org@nongnu.org designates
	2001:4830:134:3::11 as permitted sender)
	client-ip=2001:4830:134:3::11; 
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Date: Fri, 11 May 2018 17:32:17 -0700
Message-Id: <20180512003217.9105-12-richard.henderson@linaro.org>
In-Reply-To: <20180512003217.9105-1-richard.henderson@linaro.org>
References: <20180512003217.9105-1-richard.henderson@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH v4 11/11] target/arm: Fix sqrt_f16 exception
	raising
Precedence: list
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-stable@nongnu.org
Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>

Series

target/arm: Fixups for ARM_FEATURE_V8_FP16 | expand

Commit Message

Richard Henderson May 12, 2018, 12:32 a.m. UTC

From: Alex Bennée <alex.bennee@linaro.org>


We are meant to explicitly pass fpst, not cpu_env.

Cc: qemu-stable@nongnu.org
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/arm/translate-a64.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.0

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 35997969b4..a0b0c43d12 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -4976,7 +4976,8 @@  static void handle_fp_1src_half(DisasContext *s, int opcode, int rd, int rn)
         tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000);
         break;
     case 0x3: /* FSQRT */
-        gen_helper_sqrt_f16(tcg_res, tcg_op, cpu_env);
+        fpst = get_fpstatus_ptr(true);
+        gen_helper_sqrt_f16(tcg_res, tcg_op, fpst);
         break;
     case 0x8: /* FRINTN */
     case 0x9: /* FRINTP */

[v4,11/11] target/arm: Fix sqrt_f16 exception raising

Commit Message

Patch