From patchwork Fri Nov 30 21:52:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 152599 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4171937ljp; Fri, 30 Nov 2018 13:59:58 -0800 (PST) X-Google-Smtp-Source: AFSGD/X4g18anPgHk1+LTBuxTAG+rzbO4589odrQ0d/fj2YsqNv8WtSfF4y7HNVcAn1ph51ecgPg X-Received: by 2002:a25:6cc1:: with SMTP id h184-v6mr7097820ybc.33.1543615198102; Fri, 30 Nov 2018 13:59:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543615198; cv=none; d=google.com; s=arc-20160816; b=cGaFaUEl9OcNCauyaWIfYJWF8AH7etbjsBSSlgqV4MtYL7ThZJC28Mpdtq8+QTZjLc y1hwDwfk/3nvKEm9Aq6j6N+rQAOu2YJZ9DJl1sJpKOsQKOhDI9FeXYQ5vJKue8dv8Zz2 CGFFhtYVJJ729vsw3IO8VDU/Lpks+wxviWek/kmZdIZ7j3QRMoZkdoYDm7F8THU/w7xE 9J/bwQ+4vMLh8C4eg5BTuC2BrMCExtEkqqEjuKMQfJF9gf5mEgLzij0tCkQ9OSs4/ka3 Uu6wHs3Y7aQVIZ+zyR6MLpElo07GW0SocG3dOvv8Legf5rw8v7RgGTnBQ9xInb1quCLo txZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=GOgCwhgioTfHog8ldoFAvX8MpaX1vaR4nHbQUwijngY=; b=ftmaZXopyv028m0+AZwR5nItt1jRZv0ShDLZW8VlVpZwXuELXoHSJNVD/hj6xBM8QB SqxidkVjBlghgrdz/oHsktNcbbuA9YULcessEX1gbkapV20F5/Cchhp4onHMMTYdjE0/ wT189OE6x6UrzG+czCFZihcRnGAb7UWzmirGm2QOhcWahBA8moVpBNW/2NSIfQkzEhev 36qax3M9tl4GHFIrkY1XUst/7dOY+40gjaq9+aGt8YjBleqoIRdBOnIN8MVeRX5N27SA NJjRE0uCvgGJuFOY/nbeva7/m95Q88qN4GR4owy8CekcVcnli/Dmm7nLUShLor0hbKgf kHaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=MrRugxC9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id n141-v6si3798425yba.72.2018.11.30.13.59.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 30 Nov 2018 13:59:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=MrRugxC9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqpJ-0008RW-Gl for patch@linaro.org; Fri, 30 Nov 2018 16:59:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqiG-00084J-TV for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSqiG-0007JR-19 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:40 -0500 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:32815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSqiF-0007FD-S4 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:39 -0500 Received: by mail-pf1-x432.google.com with SMTP id c123so3445760pfb.0 for ; Fri, 30 Nov 2018 13:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GOgCwhgioTfHog8ldoFAvX8MpaX1vaR4nHbQUwijngY=; b=MrRugxC9vNXjs4tZMLfEqwLGi4bN/YaVCoO1l8fBe5EX3wA8xf6qLpeGOSJyS5eivK /MASbkwqwRmpXUnoSA41mR8AA2KlTuQ+JE1/LhxBUpk2Zm+bNsMEq//7p6IVMyyMgv0n mP3gfJEGj6Caf1smRqvt1cKx3D6XopF4+EBgw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GOgCwhgioTfHog8ldoFAvX8MpaX1vaR4nHbQUwijngY=; b=kElnswYJIMKimkQ0Xh4RFQbmLnIJBwMAbju613c9DieukSpaOFNVKHUcjsR9tDyFFY qdw7eACvYHdH+wp5cY5tqtkA/d3lFqZLoDW0r43ys0rj3QuMfQRGRta9Tc40A2O12a9o ZrLi+H/OURr4V/QLsg4TtlbbEyJcPUBBFRB4nQ31SQc5MP035vCQ7yc/xDNuBD6S2Rkb zLg+4l/HWu8BhFc1Wmj2dBakmHs93RUliUWfpZYGgqrWFjCcBPPAtOQKiuDAKJmA6RUs KUv5XVQFCQ4W2jhH9aJ29CZRuq9xgb26SnAKhb6vPr6PcX6qy8VV0AH8wvT+t5g0V1Po 2l/w== X-Gm-Message-State: AA+aEWZ34equ2oq7zFP5X3aqqpSH4imV5ELbOBkMBABamuiTxzH/5S2v AyfuRrgXvohyRuncAjYcLLlaMJ/rMSo= X-Received: by 2002:a63:9402:: with SMTP id m2mr5940328pge.93.1543614758349; Fri, 30 Nov 2018 13:52:38 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id a18sm6973967pgj.30.2018.11.30.13.52.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 13:52:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 30 Nov 2018 13:52:17 -0800 Message-Id: <20181130215221.20554-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181130215221.20554-1-richard.henderson@linaro.org> References: <20181130215221.20554-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::432 Subject: [Qemu-devel] [PATCH v3 12/16] tcg/i386: Return false on failure from patch_reloc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.2 Reviewed-by: Alex Bennée diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 5c88f1f36b..28192f4608 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -175,7 +175,7 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type, case R_386_PC32: value -= (uintptr_t)code_ptr; if (value != (int32_t)value) { - tcg_abort(); + return false; } /* FALLTHRU */ case R_386_32: @@ -184,7 +184,7 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type, case R_386_PC8: value -= (uintptr_t)code_ptr; if (value != (int8_t)value) { - tcg_abort(); + return false; } tcg_patch8(code_ptr, value); break;