From patchwork Fri Nov 30 21:52:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 152603 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4175637ljp; Fri, 30 Nov 2018 14:03:21 -0800 (PST) X-Google-Smtp-Source: AFSGD/UZaqz8JzWjAoD0yJflUVc+Rvp1uQa4gif96H+ziAGuIVsDwslOHv43z38wQYRGwXVeT7Cg X-Received: by 2002:a25:f50d:: with SMTP id a13-v6mr7153903ybe.56.1543615401384; Fri, 30 Nov 2018 14:03:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543615401; cv=none; d=google.com; s=arc-20160816; b=nPC0auC8IDHSXQY94P2grPkHOYHZbo/ykwIweN2FtHamPRY9r13C6k+Dzcr8AMSZ7t YvbkY7CUt51SoWHtQ7EAENFF4T6eLPukRHRERScnPODGkKcmx9sarbJHDShndquU3TLU ndCRV6qmnN2fFD9/SYN91+N9aOz4meWT0cbccsXHq6M3mMIzKIKHX9r1Lggn6laoz+fA dXcQKC3EPWW0svAzDPn9syy/XN1qSFUpAYb65vOgmroT9NHV3JffENl+DmSaoClspyVa f5sEGFLzykhk8OneZzcAhEJv0xnwI0OIVjnpSdWzIAFFEhA1vhTaobsH/t7hdF35zJdV PCIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=meIomQO1GtN3dMIndLu+UFeHsb6xbjxNIqoRJl4bs4M=; b=igLDHAd6iFrhaDUDlc6jSIyp4MWviOg+mpY8g1YMYE5XK7SYbdIqYh4HEg2K0lxXJ7 lN/PpmK60UXxxZuWFax6WpHhvf0J36PC/NLEHpoVL0MfHpvjdOHm8gnzAtZSwS5l/kWC SLtecvZMqXixTzJCvxpO/ElAjWdiViTS8z5Gzeuu1QhuyP31Ed3WPTFpcty/HESQkT1w MlE8MILV0/Twf+PqkiVg2oxNJM2E6/ZvQOAAmKNYqejC/3lEjNHGbWpNqNjphRp0KExP MlGDx/vUEpETAGUGcwMHt5dzQcMD/35/WxMZPWHVE92C8aWv+3RjUJbxDuXAaag6MvOQ i3Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=JR4ASTrd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x131si3855561ywd.27.2018.11.30.14.03.21 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 30 Nov 2018 14:03:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=JR4ASTrd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:34794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqsa-0003wX-OZ for patch@linaro.org; Fri, 30 Nov 2018 17:03:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqiC-0007zi-F2 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSqiA-0006vo-Tn for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:36 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:41099) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSqiA-0006tK-O9 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:34 -0500 Received: by mail-pg1-x543.google.com with SMTP id 70so3049139pgh.8 for ; Fri, 30 Nov 2018 13:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=meIomQO1GtN3dMIndLu+UFeHsb6xbjxNIqoRJl4bs4M=; b=JR4ASTrdv+nh4SdxVNJz3aDFiriHArQBIgOYh0tCofkYO+l9q+QLuOphY+AlGXoDu+ 3+ADPDIgcSTyqlxTM/KzhxBkDXAKeqCNM5q3ixpPq1am5Zp+UuqQ/cTnQ7LjUNOL941m Je26snvROIh5sl07huJ6rbiBXLntouwMfAeoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=meIomQO1GtN3dMIndLu+UFeHsb6xbjxNIqoRJl4bs4M=; b=Cb7amY84A04s5Qw5lfbZtn9yPHnApy9MQenA7yCO3HghvzcLzEMSFdyJH5ngA6RVvt fOmNjN5aJS/4C/KxTsjOTrarQgf9/ruWMqTI+tPgU1M2SN3De2PIMkEmqqA/t4n7g43o +EO91WLv6BnoF08kOGck4Gw6lC/LpuULAX+dhZRKXTsEp62BWydL6rRm7KoHYWzGzc8U 6pKUhhsX38+R+EX7JzVUbJtN/jfXPJdqK+vPPSvt0IRbv90zJfIt+h+RU9DdI2c1iD3I n4HODSyYfLoWNp5+mfRhp/toTYCwo8Kn7mYZ3aagswTCCpC7YuDPSUslfReDnnubEGaE rh+w== X-Gm-Message-State: AA+aEWbuYLvldxtRHIGyfKMotEPfGT1g0k7XDDfG56t+IGk9XMDTZ5lH B31JbOtzCjstwTkluP6yI5diAUuKapc= X-Received: by 2002:a63:9306:: with SMTP id b6mr5941075pge.36.1543614753448; Fri, 30 Nov 2018 13:52:33 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id a18sm6973967pgj.30.2018.11.30.13.52.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 13:52:32 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 30 Nov 2018 13:52:13 -0800 Message-Id: <20181130215221.20554-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181130215221.20554-1-richard.henderson@linaro.org> References: <20181130215221.20554-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: [Qemu-devel] [PATCH v3 08/16] tcg/s390: Remove retranslation code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There is no longer a need for preserving branch offset operands, as we no longer re-translate. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.17.2 Reviewed-by: Alex Bennée diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index 17c435ade5..96c344142e 100644 --- a/tcg/s390/tcg-target.inc.c +++ b/tcg/s390/tcg-target.inc.c @@ -1329,13 +1329,11 @@ static void tgen_branch(TCGContext *s, int cc, TCGLabel *l) static void tgen_compare_branch(TCGContext *s, S390Opcode opc, int cc, TCGReg r1, TCGReg r2, TCGLabel *l) { - intptr_t off; + intptr_t off = 0; if (l->has_value) { off = l->u.value_ptr - s->code_ptr; } else { - /* We need to keep the offset unchanged for retranslation. */ - off = s->code_ptr[1]; tcg_out_reloc(s, s->code_ptr + 1, R_390_PC16DBL, l, 2); } @@ -1347,13 +1345,11 @@ static void tgen_compare_branch(TCGContext *s, S390Opcode opc, int cc, static void tgen_compare_imm_branch(TCGContext *s, S390Opcode opc, int cc, TCGReg r1, int i2, TCGLabel *l) { - tcg_target_long off; + tcg_target_long off = 0; if (l->has_value) { off = l->u.value_ptr - s->code_ptr; } else { - /* We need to keep the offset unchanged for retranslation. */ - off = s->code_ptr[1]; tcg_out_reloc(s, s->code_ptr + 1, R_390_PC16DBL, l, 2); } @@ -1696,7 +1692,6 @@ static void tcg_out_qemu_ld(TCGContext* s, TCGReg data_reg, TCGReg addr_reg, base_reg = tcg_out_tlb_read(s, addr_reg, opc, mem_index, 1); - /* We need to keep the offset unchanged for retranslation. */ tcg_out16(s, RI_BRC | (S390_CC_NE << 4)); label_ptr = s->code_ptr; s->code_ptr += 1; @@ -1724,7 +1719,6 @@ static void tcg_out_qemu_st(TCGContext* s, TCGReg data_reg, TCGReg addr_reg, base_reg = tcg_out_tlb_read(s, addr_reg, opc, mem_index, 0); - /* We need to keep the offset unchanged for retranslation. */ tcg_out16(s, RI_BRC | (S390_CC_NE << 4)); label_ptr = s->code_ptr; s->code_ptr += 1;