From patchwork Wed Feb 6 05:06:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 157567 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6006778jaa; Tue, 5 Feb 2019 21:22:23 -0800 (PST) X-Google-Smtp-Source: AHgI3IYdwjHL/WsOZnGPPCO6wEMxiHsqYm1VQEm1j7D8C3cW9AHT928te7mOALa/Ol33ghie+bAe X-Received: by 2002:a25:a3c1:: with SMTP id e59mr7087001ybi.96.1549430543874; Tue, 05 Feb 2019 21:22:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549430543; cv=none; d=google.com; s=arc-20160816; b=Wdwn0UedfRCRrd0UP12mwhbahrUOSxikVRFgFVUZabYGekqjQW+DCmAr8F1AcwD9+h R/dauIjKKW76E1iAQbgSWgCEyRyoLEqS4GTbbzdwSQOd3H67dxPealqtJdXQrVhCjWqS Pxj27lwfUKSCxdbNCSWVyP3xL+wW7JmXC11G/EWEXs8Bq11hL65w7iJFGdZLXBDYT3yA qMncx2pwl9m5lRrm5OFqHGgJK02rPfMOvFr8mz3E4unI1cCmTMJeoz/LVk682lCzZ6CY f5BWuQ2r96H9ND+e9XRBdNCv/mycneE0wXOsZKTdCnOq45TrPqpjqz399JAKVOkg2O1k tTzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=nkppjyPenvrmBKOxVa/5zysVhyVImuZLtfc+WgYdgnm+Ejdiz63GDTJ2clWqcPHwXh uFDwqppV7wzQL66lKqN+fdRKrbkdQJ18NsYnDCYrsduJJLz7eIfWqljmCOXZjeMiIzJI Aa7eBiWBDlyviBIztauaTgz5wBK4m3ApCPwu62ZB08bwTClP8KNvMEMdAeiWVl/3snoV eC1E9rxwXmY2Caaezt+ej0mItsI4rEpZWP/TF7aTx4mqMgp0WNXQAFdzWXaKkDnJLs63 H5+TtzR1d6wEF1BUvY+0HJH7McfUSldbUpP6Sv+1mY9F+LodX2Yfd84M2UyU2Bjr5avf QSPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=s1uu53Oi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b65si3138231ybh.162.2019.02.05.21.22.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 05 Feb 2019 21:22:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=s1uu53Oi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:45233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFfD-0000uT-Bx for patch@linaro.org; Wed, 06 Feb 2019 00:22:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grFbg-0007HS-61 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:18:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grFQU-0003Jf-Ml for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:11 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:50906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grFQU-0003JC-81 for qemu-devel@nongnu.org; Wed, 06 Feb 2019 00:07:10 -0500 Received: by mail-wm1-x32b.google.com with SMTP id z5so1114575wmf.0 for ; Tue, 05 Feb 2019 21:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=s1uu53Oi58ae92wm816ieXZMCV8mktjtoxfkARsF9DMQv8lA0Bp8e8q2NTs3A3nGSh prFfYIy9IfnYB/BsG/hVEUk9eX3g53bd0cpameP7RqxH1Bk+6wQqUR1VclMUQLXq265U QgKKlOSIf3KAptJrvgTAiv/HeoO9yZrSJT5zl+JdKpqxrzlTt//mlhlOa2Cz9fcA3CtG s4FBHglhOPQFw9bT8vftDQBDYgx+6rxdQsz5/Mk43/sc/q30YhOEm/A40NhFrvEWRHzu /qgUjB9Awr15npMdrjos2zl/JdaRd0MwzaZOtGL1Jr1ODffsRS+7d68562VGBE4OfGCy p2Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=84vmGP9Bty50VmJ29TzqnMG7INxyOeuGKn+/z1pdICA=; b=Yek4IZBwphdzeG3InzIrLfbTCGtHSmJxyIV4RILeAymZO1cMiZuzhfQbOppO3Y+4ro r/uA3VGxhtraAbIIJalO4p8ialrZOpgKuJlQqznF9+6TuLWCg9MBJuWJoOrDmXyefd8r 7HErTtPQnPpNw7DsE6Od+RILhweklwkA9ALrE9FHMprhgYwej2e4t+R8ESEuQkYuiCtp rK+8RSM1RqM0sKrRA163guwfshdaYAC9CExM2EORQjH9S8pqSoIYJRlfkmYcgnHjX9zt j8BSt1jW/T5w4acIukxAKWnlLAIKeKhSApdWn7NtJ+mKpG/hHQL4YaI9QUuGKvc6S9se rXkQ== X-Gm-Message-State: AHQUAuZeJVFejDVv6hZq5nmP+5NmKL2V9mC0dWjJzgnF1rXeW9cEdxJH 1Rgj/Tam4CUz6QLqASyP1J+rRw7JDGV1qw== X-Received: by 2002:a1c:c1c9:: with SMTP id r192mr1407868wmf.146.1549429628386; Tue, 05 Feb 2019 21:07:08 -0800 (PST) Received: from cloudburst.twiddle.net (host81-133-38-158.in-addr.btopenworld.com. [81.133.38.158]) by smtp.gmail.com with ESMTPSA id l125sm2343473wml.18.2019.02.05.21.07.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 21:07:07 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 6 Feb 2019 05:06:57 +0000 Message-Id: <20190206050701.11847-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190206050701.11847-1-richard.henderson@linaro.org> References: <20190206050701.11847-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b Subject: [Qemu-devel] [PATCH v2 1/5] target/arm: Rely on optimization within tcg_gen_gvec_or X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Since we're now handling a == b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +----- target/arm/translate-sve.c | 6 +----- target/arm/translate.c | 12 +++--------- 3 files changed, 5 insertions(+), 19 deletions(-) -- 2.17.2 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e002251ac6..a12bfac719 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10648,11 +10648,7 @@ static void disas_simd_3same_logic(DisasContext *s, uint32_t insn) gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_andc, 0); return; case 2: /* ORR */ - if (rn == rm) { /* MOV */ - gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_mov, 0); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); - } + gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_or, 0); return; case 3: /* ORN */ gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_orc, 0); diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index b15b615ceb..3a2eb51566 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -280,11 +280,7 @@ static bool trans_AND_zzz(DisasContext *s, arg_rrr_esz *a) static bool trans_ORR_zzz(DisasContext *s, arg_rrr_esz *a) { - if (a->rn == a->rm) { /* MOV */ - return do_mov_z(s, a->rd, a->rn); - } else { - return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); - } + return do_vector3_z(s, tcg_gen_gvec_or, 0, a->rd, a->rn, a->rm); } static bool trans_EOR_zzz(DisasContext *s, arg_rrr_esz *a) diff --git a/target/arm/translate.c b/target/arm/translate.c index 66cf28c8cb..9d2dba7ed2 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -6294,15 +6294,9 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tcg_gen_gvec_andc(0, rd_ofs, rn_ofs, rm_ofs, vec_size, vec_size); break; - case 2: - if (rn == rm) { - /* VMOV */ - tcg_gen_gvec_mov(0, rd_ofs, rn_ofs, vec_size, vec_size); - } else { - /* VORR */ - tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, - vec_size, vec_size); - } + case 2: /* VORR */ + tcg_gen_gvec_or(0, rd_ofs, rn_ofs, rm_ofs, + vec_size, vec_size); break; case 3: /* VORN */ tcg_gen_gvec_orc(0, rd_ofs, rn_ofs, rm_ofs,