From patchwork Thu Feb 7 11:54:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 157721 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp559155jaa; Thu, 7 Feb 2019 04:03:42 -0800 (PST) X-Google-Smtp-Source: AHgI3IZTSByAMHtTtt/w3OZOcNtz+WGGU5YUxLwstya0GQN152/Mvm2vZ+pnkJpZctbAZHJos1Kl X-Received: by 2002:adf:9061:: with SMTP id h88mr11880126wrh.65.1549541022456; Thu, 07 Feb 2019 04:03:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549541022; cv=none; d=google.com; s=arc-20160816; b=1JhihbJX9ukAmed4TCu4G+kVNHN7BAbkK8mIQMD7csQLOYOUFZPGZ2jZTRxIC+kyK6 ACURAr/KZAFTApmY//dvgRkWxB+Z5piNG41OMbf9ahra55W3n0cCmn/SZU1AgMISirLM gWQu7tCKkhLoduNd2C1pVnyUh62TCQehmSpetbv1usCIfKoNUU6eXZGsZ4+70frpigLk czs6YOk8JpdpIX3oJoirPqHQA7T+vOFvD5yZsYJcfWVNj7voEFBcwIAtN/9XQf0LFXmJ 4yNtr8pQyh8B2sXyvW7Rb+XfLTCfHs954iWlYSQSGparcak+ffs4LiTVpOPlX9dgJU1v c7DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=PuCKXUL4+oocu68rkYJfGVVS8zwKghfOJafnGylPtHg=; b=H/e1USIvePdqfLBqkOd61UKh49Co/fJAeoaxVI5mlqAoVidCXTiZOTKFQs5hK79ZjY oanKiVJdXvVmAPrV0+6OtOrcCX/2JFXg2R+Y8bdnCmmo4ZKGQxe6d8uX9G327ymJ2ICp WYkkh7t/YzlfINNjtRlwngPE4JggKH+defKicqACm+jHGrL4URfu+ylfA7WSzkyaqQWl k73Bssmxmw6VnjtPx5Yv0d/MlI0c1W9DpIINCbCtrzyIT7+h6QOmpiM7XELqurTrvHpn jKEhkxwS2hoIN2533mRo0ADvqjaT82YyniQKLdIoDym6Kk76lBWqmnR61xKL7evESU2e Mm4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZTauMANS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a16si9659745wrf.311.2019.02.07.04.03.42 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Feb 2019 04:03:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZTauMANS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:38529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1griP7-0005v3-DO for patch@linaro.org; Thu, 07 Feb 2019 07:03:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1griGJ-0007Za-G4 for qemu-devel@nongnu.org; Thu, 07 Feb 2019 06:54:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1griGI-0001YA-D4 for qemu-devel@nongnu.org; Thu, 07 Feb 2019 06:54:35 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:38172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1griGI-0001VR-5d for qemu-devel@nongnu.org; Thu, 07 Feb 2019 06:54:34 -0500 Received: by mail-wm1-x343.google.com with SMTP id v26so1309525wmh.3 for ; Thu, 07 Feb 2019 03:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PuCKXUL4+oocu68rkYJfGVVS8zwKghfOJafnGylPtHg=; b=ZTauMANS2HnUsEsYfUgAd1Ekm0+6HpeQwtv0m9baH5m9Oza5JVSb2obGjSohCnKa5g 5k6pnET4RonNYiBFElbodyQADh1k74ErDSH85aEgbXQ4WRah+S8OY35ZFm1wm5VyoK3m +g1GiJ0+AhRGF9+WK0lL7Ujfxu3CiJ7/I+36zgnhSAsdFyhndWpoJ+HI/Grjql56rK9j +ieAZYMVl/BKmMSvYESmbzPnMuwWSWwkfiLmLCoJ7PasE3c75z1MdtmHJ8nvpWxY5OoA kx1v9BXEN+biyfayI6hqv4HKpn/TVUrKuyiVdhqMGGjAdPQRRafS1WN2xwPGL9xfdMu0 M3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PuCKXUL4+oocu68rkYJfGVVS8zwKghfOJafnGylPtHg=; b=eGEu5kyBTgwb9PRjfFvhpVjYTslI2xHrk/Op8NH9YeP/m23lTI2HTtEXgzHCdx91t8 yUEVzKnAaG124nm2ARgtCqaM1XTSt3noSvOIPB6zI88g9Gb8KXdz+ZIbTdQN69lnQ2L6 4wJCuaJF1vEl6a9sYzZEdHlVpv5SbkJ4QwloCMzfbcTcZXxqhC1jUwuxyzeoxaG8Gtz1 Dgj48YvhFua2l1x2l8QDFEZbV/3Pmuaz4NFUSxIRDMeaVlbV2aZ2Up9wo1mlnymO5CpQ tI5LyQQrRzNm3BeUV1m1RoIBV65BS/gVdcGDgpcM71uC1h2iLayzl1oScR2CvNxdWHtF lHXA== X-Gm-Message-State: AHQUAuZJy2GKAKzIUWhNkePCatYQWP1WWmaJZSdWVlPaKzLX5CbO9BSG LZYYsZuoHX0OyC6VlXdzrK5uwbG5vO0PVQ== X-Received: by 2002:a1c:b456:: with SMTP id d83mr7355066wmf.115.1549540465636; Thu, 07 Feb 2019 03:54:25 -0800 (PST) Received: from cloudburst.twiddle.net ([37.205.61.206]) by smtp.gmail.com with ESMTPSA id w16sm34030016wrp.1.2019.02.07.03.54.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Feb 2019 03:54:25 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 7 Feb 2019 11:54:00 +0000 Message-Id: <20190207115400.647-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190207115400.647-1-richard.henderson@linaro.org> References: <20190207115400.647-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH 19/19] target/hppa: Merge translate_one into hppa_tr_translate_insn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: deller@gmx.de, svens@stackframe.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Now that the implementation is entirely within the generated decode function, eliminate the wrapper. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) -- 2.17.2 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index ecec5c42d1..6836fb6245 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3982,13 +3982,6 @@ static bool trans_fmpyfadd_d(DisasContext *ctx, arg_fmpyfadd_d *a) return nullify_end(ctx); } -static void translate_one(DisasContext *ctx, uint32_t insn) -{ - if (!decode(ctx, insn)) { - gen_illegal(ctx); - } -} - static void hppa_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) { DisasContext *ctx = container_of(dcbase, DisasContext, base); @@ -4094,7 +4087,9 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) ret = DISAS_NEXT; } else { ctx->insn = insn; - translate_one(ctx, insn); + if (!decode(ctx, insn)) { + gen_illegal(ctx); + } ret = ctx->base.is_jmp; assert(ctx->null_lab == NULL); }