From patchwork Tue Feb 19 22:29:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 158745 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp4208426jaa; Tue, 19 Feb 2019 14:30:33 -0800 (PST) X-Google-Smtp-Source: AHgI3IbAT4a4Bp/3EVYYclMqkIj2icqbFFsTRYfRcxxpCWUiwXlRmRtw11NTTbbwOryT5pZFvzZ+ X-Received: by 2002:a25:37cd:: with SMTP id e196mr24646703yba.169.1550615433642; Tue, 19 Feb 2019 14:30:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550615433; cv=none; d=google.com; s=arc-20160816; b=E0HEDQrRj0DOosbFgyNqymSGykCcVKBWsoBnVn0fySlaQI2jH0rJ15c5vxjBtqLKn/ uKy2BApMQfJz2ViC4SO77JC4bturzo8Lo2kxPNulhzaQRvKebsbxjMEs0qbLg6bmaC2K S0IyEuo5tR/eU5X0bhKBR3mCS+j4kqeUq7NXYOcQOuQA8B64Z1mVBf5amBwh11UPYi4I 7flu18OZD6CTatlcNEyZhGrNJDir/6YBS1yhfbYzsb7xVbLJZQ4WkbgAJfkxuZ3WnAFh Ee/jOxHLCtyImc6onNbKpyAae2h4FOLXHnyWFxKm8eP+QVhECn/sqYchofT5vCxd1n9q HPsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=k2AAuYT6JQ9tFCWrFoFBERUcp77Pfq3Mf+l9IeSYmIk=; b=UKUYeDJJNwXrE4JOb7mR/aTxTtvDn+P5WLaQxPOccBCVuXYRSJ6bgprtjNiGkVtXf9 H32EuGWuTjqVwEg6GYV6Sw/GWZ2srTIevhxQfynVXMtQHlBNJHiZYdb6dz76sFLXcAJR u0hXIGOWbwZWE5b3oOkKlAli4g94DJehBUczAeip6+Q7fS2OMQPCzhfiAfKSK4lpfJO6 5Mhw3iPJD53kHyMKdmEb5XibnLiY5GVBpRDgz2vmUAduD2JUYYfoURzsrRcCsWuylviz J7zBX0T00sqZlS9hhHRaidiUKOMLSrWziXE1KirCHEjt+SYiWjckO3EDjJicog6TxsRW qr2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ew1BMWsL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s16si9742617ybg.205.2019.02.19.14.30.33 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 19 Feb 2019 14:30:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ew1BMWsL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:55900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwDuL-0000Nj-41 for patch@linaro.org; Tue, 19 Feb 2019 17:30:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwDtw-0000Km-A9 for qemu-devel@nongnu.org; Tue, 19 Feb 2019 17:30:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwDts-0002VF-Mh for qemu-devel@nongnu.org; Tue, 19 Feb 2019 17:30:06 -0500 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:35836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwDtq-0002SG-St for qemu-devel@nongnu.org; Tue, 19 Feb 2019 17:30:04 -0500 Received: by mail-pf1-x441.google.com with SMTP id j5so6379710pfa.2 for ; Tue, 19 Feb 2019 14:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k2AAuYT6JQ9tFCWrFoFBERUcp77Pfq3Mf+l9IeSYmIk=; b=ew1BMWsLnAkcLRspujpyY6XYSs4EHeIs/lpmuBCmNhOvnaII6nCtz9gyQMf7y1CiX7 vjw2sjn2KLxROC3VpYUJgIh4yDy49QB3mSnIA8NiNWvJNAvZv7itIzhffVju+6e8FbBp tTYww6UdsV1DYYo/9WRehKZTFhHudp93GUvKpSbJyWq3R7AVheYiPlgktsMyYWxDhWJ7 S8CxYIYC3jOicQc77F2KDY4FknHHyc2TWdLocMm64+jY2FYGT+2XphQ6Pmr53afNKGCe HFcE34DbXVVitvmeNgOlB9OnWHk/cKzcT5LlMI6t6YWVKaY4oVQsNL9FvKtCBMnzSDd7 iKIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k2AAuYT6JQ9tFCWrFoFBERUcp77Pfq3Mf+l9IeSYmIk=; b=QUksYQLnLVgL86b4j1tryvdvnWY+sCT71hvyrNdc39LHetrkbW1LdVnORfgri9QJwW RyIAwKiQSr7+g3L9CWPD+L0/fmEf7cQXcv4qYkUfsAk5oRo3gisoEYANintTPJikLFg4 NApscFdK4PZ9aN1gKBghj9G2lufgaMqX6UPy1PshjzBi7B+VDtznW03PxLzO/EbFkPex kdqi5W4QQkF/LdLDb7flR3WvxPfzswTirmdS0CVcW1JB/T4alng6PRHFZFkjoxSmenPg H1+Na+KEBKOGAFO0NxICeKzrAGgMHwmgGSgJyglhPiJHocoPWC1tyOuMlO1/3P8/Xxuz Pr6Q== X-Gm-Message-State: AHQUAuZSpRPzx5RypC/lLha1AgGRR3BRG+DURqn3Rf6Y0pIqWdgFvGoe yfdIN2hXs7G9mweP2dlAmr7HLSdTt5U= X-Received: by 2002:a62:9917:: with SMTP id d23mr32631584pfe.88.1550615397737; Tue, 19 Feb 2019 14:29:57 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id 20sm12530778pfs.182.2019.02.19.14.29.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 14:29:56 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 19 Feb 2019 14:29:49 -0800 Message-Id: <20190219222952.22183-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190219222952.22183-1-richard.henderson@linaro.org> References: <20190219222952.22183-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 Subject: [Qemu-devel] [PATCH v5 2/5] target/arm: Implement FMLAL and FMLSL for aarch64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 ++++ target/arm/translate-a64.c | 49 +++++++++++++++++++++++++++++++++++++- 2 files changed, 53 insertions(+), 1 deletion(-) -- 2.17.2 diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 1eea1a408b..69589573e4 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -3356,6 +3356,11 @@ static inline bool isar_feature_aa64_dp(const ARMISARegisters *id) return FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, DP) != 0; } +static inline bool isar_feature_aa64_fhm(const ARMISARegisters *id) +{ + return FIELD_EX64(id->id_aa64isar0, ID_AA64ISAR0, FHM) != 0; +} + static inline bool isar_feature_aa64_jscvt(const ARMISARegisters *id) { return FIELD_EX64(id->id_aa64isar1, ID_AA64ISAR1, JSCVT) != 0; diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c56e878787..d3c8eaf089 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10917,9 +10917,29 @@ static void disas_simd_3same_float(DisasContext *s, uint32_t insn) if (!fp_access_check(s)) { return; } - handle_3same_float(s, size, elements, fpopcode, rd, rn, rm); return; + + case 0x1d: /* FMLAL */ + case 0x3d: /* FMLSL */ + case 0x59: /* FMLAL2 */ + case 0x79: /* FMLSL2 */ + if (size & 1 || !dc_isar_feature(aa64_fhm, s)) { + unallocated_encoding(s); + return; + } + if (fp_access_check(s)) { + int is_s = extract32(insn, 23, 1); + int is_2 = extract32(insn, 29, 1); + int data = (is_2 << 1) | is_s; + tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, rd), + vec_full_reg_offset(s, rn), + vec_full_reg_offset(s, rm), cpu_env, + is_q ? 16 : 8, vec_full_reg_size(s), + data, gen_helper_gvec_fmlal_a64); + } + return; + default: unallocated_encoding(s); return; @@ -12739,6 +12759,17 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) } is_fp = 2; break; + case 0x00: /* FMLAL */ + case 0x04: /* FMLSL */ + case 0x18: /* FMLAL2 */ + case 0x1c: /* FMLSL2 */ + if (is_scalar || size != MO_32 || !dc_isar_feature(aa64_fhm, s)) { + unallocated_encoding(s); + return; + } + size = MO_16; + /* is_fp, but we pass cpu_env not fp_status. */ + break; default: unallocated_encoding(s); return; @@ -12849,6 +12880,22 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) tcg_temp_free_ptr(fpst); } return; + + case 0x00: /* FMLAL */ + case 0x04: /* FMLSL */ + case 0x18: /* FMLAL2 */ + case 0x1c: /* FMLSL2 */ + { + int is_s = extract32(opcode, 2, 1); + int is_2 = u; + int data = (index << 2) | (is_2 << 1) | is_s; + tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, rd), + vec_full_reg_offset(s, rn), + vec_full_reg_offset(s, rm), cpu_env, + is_q ? 16 : 8, vec_full_reg_size(s), + data, gen_helper_gvec_fmlal_idx_a64); + } + return; } if (size == 3) {