From patchwork Thu May 9 22:26:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 163766 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:142:0:0:0:0 with SMTP id j2csp1569989ilr; Thu, 9 May 2019 15:31:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxn6BrF9UF2lusM9JyhNx1Tihc9wpF02jL6PkfUS/We9MgrwT28+hHGJHxxgjaBg8TIfC6L X-Received: by 2002:adf:ec06:: with SMTP id x6mr4776405wrn.159.1557441070645; Thu, 09 May 2019 15:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557441070; cv=none; d=google.com; s=arc-20160816; b=HxSxROsIsafYjQD3TZXyouV2P6B3bryExqheoOvq2FzndOdtzQB+2JDtxBjdtsmNml K2vGzpfsbAj+n7XEZs79Qh5agSE+jVTkDP5Tup/0E2n48u9rG4TwEnqzLh1fPQfpmmWY FqkN/SLiOC0w5GlzV6n5VjRMBNpi5FhDxK+j2mKwgk/jcEF/ptcyYyH+Itzx64uHYx9a FcHi/0gN//gDIt1HwbehB+KYUNe/MGj+6HZrl1RIQRj6YTyvLRRVboJSDZ2BN/Sx6B5P 1+Q0hvI34NP//hddJnXbmfuH/fKxvbQTsqaH391VCJarRaoNYAxklAN/K6lhjwmcg5ry M/8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=t5VoKM+l3Lq9jc+URQ3PZSk53GmjO2/IoQkt1bRH1n8=; b=NlrqZcLvv2rrdhKkEs7OWsyWRVJh9p60tOj9cFbl54t+nMtGNw874Hqv/8Nx8x1NP9 TVKptVF/6VF83drAfSE1ZMxQXXg6C0v7AY32677koSWirWUuqUtyMhqfBiC87Gh0hWAW 6NaqfDtEhq7oRyG3hkJy3qHAPlUvbkpjJ6c2qmWVG0WW1Vi/wMo71TcCPE60w/P6KJeS fw7Ugae9h8z1MyuKHgPVSFP2VeztPjl1p0zQJlxAWDP9krWeL6CDHd7mOUkF/pxJSQwE yHTaUn88niMzagmzbHK5mk+J1X2e4q92WLyR/zzh9Hpym58W9xtXZZFmEDKpTtpryWpB XW5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bQ0N9wvl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c6si2771907wrv.267.2019.05.09.15.31.10 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 09 May 2019 15:31:10 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=bQ0N9wvl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:33498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOrZF-0002RC-BD for patch@linaro.org; Thu, 09 May 2019 18:31:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOrV5-0007iY-DG for qemu-devel@nongnu.org; Thu, 09 May 2019 18:26:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOrV4-0005Ui-49 for qemu-devel@nongnu.org; Thu, 09 May 2019 18:26:51 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:37572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOrV3-0005U2-Ty for qemu-devel@nongnu.org; Thu, 09 May 2019 18:26:50 -0400 Received: by mail-pg1-x541.google.com with SMTP id e6so1924332pgc.4 for ; Thu, 09 May 2019 15:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t5VoKM+l3Lq9jc+URQ3PZSk53GmjO2/IoQkt1bRH1n8=; b=bQ0N9wvliHWfwB6xiRY3293N8XBBGA1FEXdS7WZPjZm3S40hJBRwPQVNbAAmi9FsFT gezc5dhZ0gNxxmkTpCCH8rvp/cpl5xMhud5Ai1BbyFa+QsDeQyuN3Ml0YOecE7d3O0HC saqrymv7VOizP7UhZoeb0Mn97esNq/b3E7Yv6x9rDQ+SasbHkHIjc/5N+haCbXrA3wVx qmaiUrlTvA08Y3NtCde0svxHFsBD0dJfp/VEvjhhZyfLicVVhFdSGdgnV4NlPXC1IMTk dZ7eSX4ZsxuIgcjNYpFPCyQKMKOn35msD261O5p6uiOs15Oh10VK3j9OlsJpAQwISyXZ 7Gpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t5VoKM+l3Lq9jc+URQ3PZSk53GmjO2/IoQkt1bRH1n8=; b=MvDbHwombVSDdki/Jb+8PU2RzuhzbCozL7yDH7Nv/OiWc0x4Y9HOGiQSUQ8oxUR5UF LwgNFAf71fRpKXWv2kHJaISpIuqsWTYpfnsUsqER8Z7LTIe1waciaHhA1J7/iNCDcoRN FdrfY0oY4XNgHG+W4C6JCphy5xEU4SVDDxrnojfdZYwzUVOnj8GZuev33DZJiasuvBOl +pvgjs0cO3kbCxEVLCcBnOhGRsXTyZhWT0zq538OASFI5YBZ8tUdqh4SomSl9i0KgBld oO5un2pbz8M98LGkQBx/JxIkupOMyx/IHVqgv+Y5emFKaouikBcxZUBqnpu7eJXtl1fJ 87Eg== X-Gm-Message-State: APjAAAUp33KkcKfiGURuID62Ax/YT6zlorMMbyA4vP3qGE9c6ugH1xtd umg2yWGaNx6P6LupQaVHegHdsCuZnJA= X-Received: by 2002:a63:7d03:: with SMTP id y3mr8736562pgc.8.1557440808714; Thu, 09 May 2019 15:26:48 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id m2sm4490521pfi.24.2019.05.09.15.26.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 15:26:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 9 May 2019 15:26:16 -0700 Message-Id: <20190509222631.14271-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190509222631.14271-1-richard.henderson@linaro.org> References: <20190509222631.14271-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH v3 12/27] target/mips: Convert to CPUClass::tlb_fill X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aleksandar Markovic Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Note that env->active_tc.PC is removed from the qemu_log as that value is garbage. The PC isn't recovered until cpu_restore_state, called from cpu_loop_exit_restore, called from do_raise_exception_err. Cc: Aleksandar Markovic Cc: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- v2: Split out other mips cleanups to simplify the diff --- target/mips/internal.h | 5 +++-- target/mips/cpu.c | 5 ++--- target/mips/helper.c | 45 ++++++++++++++++++++++------------------- target/mips/op_helper.c | 15 -------------- 4 files changed, 29 insertions(+), 41 deletions(-) -- 2.17.1 diff --git a/target/mips/internal.h b/target/mips/internal.h index 286e3888ab..b2b41a51ab 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -202,8 +202,9 @@ void cpu_mips_start_count(CPUMIPSState *env); void cpu_mips_stop_count(CPUMIPSState *env); /* helper.c */ -int mips_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int size, int rw, - int mmu_idx); +bool mips_cpu_tlb_fill(CPUState *cs, vaddr address, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr); /* op_helper.c */ uint32_t float_class_s(uint32_t arg, float_status *fst); diff --git a/target/mips/cpu.c b/target/mips/cpu.c index e217fb3e36..ebdb834b97 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -197,9 +197,8 @@ static void mips_cpu_class_init(ObjectClass *c, void *data) cc->synchronize_from_tb = mips_cpu_synchronize_from_tb; cc->gdb_read_register = mips_cpu_gdb_read_register; cc->gdb_write_register = mips_cpu_gdb_write_register; -#ifdef CONFIG_USER_ONLY - cc->handle_mmu_fault = mips_cpu_handle_mmu_fault; -#else + cc->tlb_fill = mips_cpu_tlb_fill; +#ifndef CONFIG_USER_ONLY cc->do_unassigned_access = mips_cpu_unassigned_access; cc->do_unaligned_access = mips_cpu_do_unaligned_access; cc->get_phys_page_debug = mips_cpu_get_phys_page_debug; diff --git a/target/mips/helper.c b/target/mips/helper.c index 86e622efb8..3a4917ce7b 100644 --- a/target/mips/helper.c +++ b/target/mips/helper.c @@ -874,31 +874,25 @@ refill: #endif #endif -int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw, - int mmu_idx) +bool mips_cpu_tlb_fill(CPUState *cs, vaddr address, int size, + MMUAccessType access_type, int mmu_idx, + bool probe, uintptr_t retaddr) { MIPSCPU *cpu = MIPS_CPU(cs); CPUMIPSState *env = &cpu->env; #if !defined(CONFIG_USER_ONLY) hwaddr physical; int prot; - int access_type; + int mips_access_type; #endif int ret = TLBRET_BADADDR; -#if 0 - log_cpu_state(cs, 0); -#endif - qemu_log_mask(CPU_LOG_MMU, - "%s pc " TARGET_FMT_lx " ad %" VADDR_PRIx " rw %d mmu_idx %d\n", - __func__, env->active_tc.PC, address, rw, mmu_idx); - /* data access */ #if !defined(CONFIG_USER_ONLY) /* XXX: put correct access by using cpu_restore_state() correctly */ - access_type = ACCESS_INT; - ret = get_physical_address(env, &physical, &prot, - address, rw, access_type, mmu_idx); + mips_access_type = ACCESS_INT; + ret = get_physical_address(env, &physical, &prot, address, + access_type, mips_access_type, mmu_idx); switch (ret) { case TLBRET_MATCH: qemu_log_mask(CPU_LOG_MMU, @@ -915,7 +909,7 @@ int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw, tlb_set_page(cs, address & TARGET_PAGE_MASK, physical & TARGET_PAGE_MASK, prot | PAGE_EXEC, mmu_idx, TARGET_PAGE_SIZE); - return 0; + return true; } #if !defined(TARGET_MIPS64) if ((ret == TLBRET_NOMATCH) && (env->tlb->nb_tlb > 1)) { @@ -926,27 +920,36 @@ int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw, int mode = (env->hflags & MIPS_HFLAG_KSU); bool ret_walker; env->hflags &= ~MIPS_HFLAG_KSU; - ret_walker = page_table_walk_refill(env, address, rw, mmu_idx); + ret_walker = page_table_walk_refill(env, address, access_type, mmu_idx); env->hflags |= mode; if (ret_walker) { - ret = get_physical_address(env, &physical, &prot, - address, rw, access_type, mmu_idx); + ret = get_physical_address(env, &physical, &prot, address, + access_type, mips_access_type, mmu_idx); if (ret == TLBRET_MATCH) { tlb_set_page(cs, address & TARGET_PAGE_MASK, physical & TARGET_PAGE_MASK, prot | PAGE_EXEC, mmu_idx, TARGET_PAGE_SIZE); - return 0; + return true; } } } #endif + if (probe) { + return false; + } #endif - raise_mmu_exception(env, address, rw, ret); - return 1; + raise_mmu_exception(env, address, access_type, ret); + do_raise_exception_err(env, cs->exception_index, env->error_code, retaddr); +} + +#ifndef CONFIG_USER_ONLY +void tlb_fill(CPUState *cs, target_ulong addr, int size, + MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) +{ + mips_cpu_tlb_fill(cs, addr, size, access_type, mmu_idx, false, retaddr); } -#if !defined(CONFIG_USER_ONLY) hwaddr cpu_mips_translate_address(CPUMIPSState *env, target_ulong address, int rw) { hwaddr physical; diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 0f272a5b93..6d86912958 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -2669,21 +2669,6 @@ void mips_cpu_do_unaligned_access(CPUState *cs, vaddr addr, do_raise_exception_err(env, excp, error_code, retaddr); } -void tlb_fill(CPUState *cs, target_ulong addr, int size, - MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) -{ - int ret; - - ret = mips_cpu_handle_mmu_fault(cs, addr, size, access_type, mmu_idx); - if (ret) { - MIPSCPU *cpu = MIPS_CPU(cs); - CPUMIPSState *env = &cpu->env; - - do_raise_exception_err(env, cs->exception_index, - env->error_code, retaddr); - } -} - void mips_cpu_unassigned_access(CPUState *cs, hwaddr addr, bool is_write, bool is_exec, int unused, unsigned size)