From patchwork Sat May 18 19:01:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164447 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp3703851ili; Sat, 18 May 2019 12:08:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1KHTw5BY8cpUK9i+xN/X/2XblIML1UCJQ07XvTa56ynI8ANmuXudYAEhM1UZWM0oCyq2B X-Received: by 2002:a17:906:25c5:: with SMTP id n5mr19921598ejb.110.1558206492027; Sat, 18 May 2019 12:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558206492; cv=none; d=google.com; s=arc-20160816; b=pth/VbYeY0p7CPWkJkBC3Z3IyGnDX3ub3PJ62phxu8ZzT3LwcLyHEnKoqfPf+CgfpL DgPvvlG1yQW01lahAf9/l8ydAjESD17mWQ0AO/o3WGFf0RvBcYOFFA8GBS90DqHpGkHO r56wiKKThJbOYFG0A6aKcuyoph7wu2+YtLxZkHRccy0hyIlY/61X8enzuAX5iARZe+4k KaIG8zDCO4/YJMTFE3uMWiIkWWmT6eg7y53vjMzUm3/YtQ/IKzHfF79pr1yavRJWzukI NI0+BoGrJZGvMfy4vhb6DVB9YZ9LoFR6yZBN65gpZL9p2rbPCGfBPabkxW/k8HQZ6V0E JEOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Dp2wE06ppFvr7SDc7+wjEouETDXh/6Jd86FUlkd8ziE=; b=rfeZ4iy4LanbmOE1xq074RXwtTi/2kt3W8N6ST0WQBpHrJhXF1dk6zlmX7Q94pxWP1 EFpeI9O5muG7y7qpijFq+o/2pSwpLbtct6/HxpsrgTLaYG6ns26rUd/yhtPnFbkyypP7 xVY9G5vXokCi8S5j2MPwMh/EJq3uAWdyNRijypDC+RjHrJGesha2IT2pPIOWvCFIfl1e mTwG0yHb0aEAYinVTfIUFzaqmFGttDOJ9AwyAKquzfawyzFDD1sLqi9u1SVb+KY9geWK ipnadLGV5/BXuzBs0FlzvwI/c0VDOsvpgRPWmag28MbnduP9MKlRZ7Ub8lIIdVQM8JQ6 eo4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Nv8tgCKE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a6si342615edm.208.2019.05.18.12.08.11 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 18 May 2019 12:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Nv8tgCKE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:37611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS4gl-0005lP-09 for patch@linaro.org; Sat, 18 May 2019 15:08:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS4dQ-0002lS-Ja for qemu-devel@nongnu.org; Sat, 18 May 2019 15:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hS4aw-0002dW-2E for qemu-devel@nongnu.org; Sat, 18 May 2019 15:02:11 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:39129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hS4av-0002d6-PR for qemu-devel@nongnu.org; Sat, 18 May 2019 15:02:10 -0400 Received: by mail-pf1-x444.google.com with SMTP id z26so5254362pfg.6 for ; Sat, 18 May 2019 12:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=Dp2wE06ppFvr7SDc7+wjEouETDXh/6Jd86FUlkd8ziE=; b=Nv8tgCKEQwfqnpVeDr/mOFgdZIrwTTm0x6+1Xh722DfqBMm8Ret9tLRopYz0AtyqCm OXrhAXUremVVi2bTpXmmlI1ZtFN/ZIWu+IDF5OFe+kZs3MyCQAIJT7W4Fh/DF2pAwyjH 0IxEy1bGn+li9hUklTdvXoTheFgugsYC/1P40zsHIFvwmYN4HxzdospZeidVANAJ6eEO GFkPEOQBp/RliGa1amqjp48qR4ParxP2JGdm6IPSa7nH72gSpfvNiW0ZWCnNpXFJWqAZ K66L9iqbF26IvlsA7Av3w1GIXYJ8QCLLlrr6G6tw9jKcRqyVcsR/e5OnPiDrrBErqyyb YoCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Dp2wE06ppFvr7SDc7+wjEouETDXh/6Jd86FUlkd8ziE=; b=QgjIrAGQYb262g16/sZZC4wUMmUKC7HnqSYLzrGGlYDzN1XmCTBEilXKneH6N6VBAk cX3FrOg6PMQ7WaLOQl1UfrytQ1DmbHvvYZzXLeaz7EYKExuDJmYhCaIzdW3Bp4LRqliU vpKTq5utAV7Al2jIXC5mJEOVFekpKelUFw1u3+ejhmO9pUKzBTxbRkwjHY5OpYaJg4cP hJr8NLd/LXAllt3IR6rkW/L0a9EQ0zeWXFfew4OtM4oNr9vNWoq0M9sXzephx73jRQbi 07bL2T9QqResKoqTZngUlWvG91HIM3XC6/2whyPUMt6EGbgolp46ahODwCXuDE+lQe/h +8rw== X-Gm-Message-State: APjAAAUnqFMvnqEaK8KNLkyGe6iww6VnmCmgHvEFhjMQVYc62tVW0u6w YL09IO9Uss+YKI88GiuNzuvzQUdA+T8= X-Received: by 2002:aa7:8008:: with SMTP id j8mr69359424pfi.120.1558206128483; Sat, 18 May 2019 12:02:08 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id m9sm2751274pgd.23.2019.05.18.12.02.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 May 2019 12:02:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 18 May 2019 12:01:47 -0700 Message-Id: <20190518190157.21255-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190518190157.21255-1-richard.henderson@linaro.org> References: <20190518190157.21255-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: [Qemu-devel] [PATCH 06/16] tcg: Expand vector minmax using cmp+cmpsel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Provide a generic fallback for the min/max operations. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) -- 2.17.1 diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 004a34935b..501d9630a2 100644 --- a/tcg/tcg-op-vec.c +++ b/tcg/tcg-op-vec.c @@ -120,6 +120,10 @@ bool tcg_can_emit_vecop_list(const TCGOpcode *list, } break; case INDEX_op_cmpsel_vec: + case INDEX_op_smin_vec: + case INDEX_op_smax_vec: + case INDEX_op_umin_vec: + case INDEX_op_umax_vec: if (tcg_can_emit_vec_op(INDEX_op_cmp_vec, type, vece)) { continue; } @@ -632,24 +636,32 @@ void tcg_gen_ussub_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) do_op3_nofail(vece, r, a, b, INDEX_op_ussub_vec); } +static void do_minmax(unsigned vece, TCGv_vec r, TCGv_vec a, + TCGv_vec b, TCGOpcode opc, TCGCond cond) +{ + if (!do_op3(vece, r, a, b, opc)) { + tcg_gen_cmpsel_vec(cond, vece, r, a, b, a, b); + } +} + void tcg_gen_smin_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) { - do_op3_nofail(vece, r, a, b, INDEX_op_smin_vec); + do_minmax(vece, r, a, b, INDEX_op_smin_vec, TCG_COND_LT); } void tcg_gen_umin_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) { - do_op3_nofail(vece, r, a, b, INDEX_op_umin_vec); + do_minmax(vece, r, a, b, INDEX_op_umin_vec, TCG_COND_LTU); } void tcg_gen_smax_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) { - do_op3_nofail(vece, r, a, b, INDEX_op_smax_vec); + do_minmax(vece, r, a, b, INDEX_op_smax_vec, TCG_COND_GT); } void tcg_gen_umax_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) { - do_op3_nofail(vece, r, a, b, INDEX_op_umax_vec); + do_minmax(vece, r, a, b, INDEX_op_umax_vec, TCG_COND_GTU); } void tcg_gen_shlv_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b)