From patchwork Wed Aug 28 19:04:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 172481 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1248589ily; Wed, 28 Aug 2019 13:19:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUI1q2ulP+yPz6ldR7PqIwuKinNOov/aKQeVL97ipsIEs62NadzsY4dfQK00/hnLhXMqWW X-Received: by 2002:a50:9401:: with SMTP id p1mr5984330eda.189.1567023569535; Wed, 28 Aug 2019 13:19:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567023569; cv=none; d=google.com; s=arc-20160816; b=TMvv2n/hDbE9IKdSWF99b5pGPP/jRktnB4EIlkvMacVozU9Qj6TqgVbn/QccMY3bsH 1qT4iigFcWAsn6SA9Que1JKi01YgpCYCwClKbswot/X/Jpnx3b7jYJxu+vVAby0ofXhY OV8LLeHhQXdhGq5wTIQmwXYkfg1IA8BNLLdtdYlL439r3RqFKDz7nfsiGbUu36VnoYt5 a6cyEsyYi/Li1qyjsXOtMBWX0fZ8Y2wQ4u4AGSB9LHKRk5FPnErtN3QHRJI/0O3H3dWy AdDIuWo5ua7o6Wf1RsazMkWUevHLsQbuT2MYz2GzUlXV7LGUQ5AMzPwUJeRTN8Ade8LN CA+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=q6ZBPK/r46XKCIwGfPMSrv2j4FjJhwF0lhuCFM2qD0g=; b=anKJ4u0daOJ1K0YXGZGXtiJr5BxT2RQBXMGlq+S5F6e9Fyqrnt9cKO9/+UrRfwLDuZ 396pP0PBnm4AJdVoDOEZdpE9Semqy5RM/ei5QKWeOUIjE1EOyiS1xbZ11XNUfqbHKkow +jmHoN7bFjjXnfk+fsHjU2sWa+updE2Nf5lO4RKG1hWNwEOa9BkAA3q2q0tCI250gIsV pHoQnrmf47pqqbWvUIwJjbN0sj5Ks0Kz77ndMTKjbjPZ+vbuVJVHAnEahkYojngrKbgk SB+f7KDtX0LRTCPS4KUR20G+8juCZxoHE14hcpOUi9czpsKONTAfF3VMGGcFN44l8bdu SKWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=k7kCCIS7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c15si50597ejd.49.2019.08.28.13.19.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 13:19:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=k7kCCIS7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i34Pf-0002dB-RR for patch@linaro.org; Wed, 28 Aug 2019 16:19:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38787) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i33Gs-0003xQ-9J for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i33Gp-0000hI-9X for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:17 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:45363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i33Go-0000dD-2o for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:14 -0400 Received: by mail-pl1-x644.google.com with SMTP id y8so379891plr.12 for ; Wed, 28 Aug 2019 12:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=q6ZBPK/r46XKCIwGfPMSrv2j4FjJhwF0lhuCFM2qD0g=; b=k7kCCIS7vEOzkHCTGD2WO4hMI8GfkWXqtLwck4aKUq0RgcgPhPhUU+k+Pp4NHn7WGE Ugjr/t0+UFtJ6d9qUm2GY5F8kxxBrmy1m7E0j8b95yRvnlLIZD2ezxzT4ygfXq8szAzd oint15XZvtVhNXNlPqidLPfHKmHPE9hv4rmhfWQkRLtVLoQyGO6Ru6RqE0IPzkGFJ5OO Yfwsi3c5xxozhog1nHJ3O9Iouj/rh2hw+Ju199z0OeES4KCygpGQ67fFHNvZA/ZPN/dI mSYEJL9tkorg/8vem2Gh/vuyOBe6F6wcM4WfHq6vxfRLUVA6PGDKRhHLQy8MEcaSPTMv Phfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=q6ZBPK/r46XKCIwGfPMSrv2j4FjJhwF0lhuCFM2qD0g=; b=V0Bd5Q3C+VywAPz1LSSjVj0nTNJzwLP117ZjPB84wHZgyCrh9ZFDwVK3jiloRjzBtq KrVM7KstAMbXVcIZC42zCkAIeK6Lv93ka61rDvLNZe1IBTVrwReQHPIt8aXJ5GdPthAD ddMLKtAvaM/nXIfhDyiESUh+vbaAycPS7uYJ2UX2LTaliT9R65oeIXypcveit4rEBYYe cTho4hH+IlCyohRDl9h3n1R8DIqVEt2l+MfaoHYa4CWHJU4sx5ksBXuc9UiuNGhCtrck EfCLKEYHL7vC37B/DM48+MMnOCiXZn/thjahLOC0s77mYazlE6VOYG1aZMnE+3SHMBwp Ii7Q== X-Gm-Message-State: APjAAAVC+VQsphv2lediNj5ESW9TZM52ssVBDOvxzDKrKbs0mnXW3hD4 xk81R51o5Ek4QeLnFwkGRKIj+8zn+mg= X-Received: by 2002:a17:902:1a6:: with SMTP id b35mr5655285plb.228.1567019170976; Wed, 28 Aug 2019 12:06:10 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id f27sm2967944pgm.60.2019.08.28.12.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 12:06:10 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 12:04:43 -0700 Message-Id: <20190828190456.30315-57-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190828190456.30315-1-richard.henderson@linaro.org> References: <20190828190456.30315-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH v3 56/69] target/arm: Convert T16, extract X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 14 +------------- target/arm/t16.decode | 10 ++++++++++ 2 files changed, 11 insertions(+), 13 deletions(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/arm/translate.c b/target/arm/translate.c index b7e2c72f35..d06ec48ab9 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10743,21 +10743,9 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) op = (insn >> 8) & 0xf; switch (op) { case 0: /* add/sub (sp, immediate), in decodetree */ + case 2: /* sign/zero extend, in decodetree */ goto illegal_op; - case 2: /* sign/zero extend. */ - ARCH(6); - rd = insn & 7; - rm = (insn >> 3) & 7; - tmp = load_reg(s, rm); - switch ((insn >> 6) & 3) { - case 0: gen_sxth(tmp); break; - case 1: gen_sxtb(tmp); break; - case 2: gen_uxth(tmp); break; - case 3: gen_uxtb(tmp); break; - } - store_reg(s, rd, tmp); - break; case 4: case 5: case 0xc: case 0xd: /* * 0b1011_x10x_xxxx_xxxx diff --git a/target/arm/t16.decode b/target/arm/t16.decode index b425b86795..b5b5086e8a 100644 --- a/target/arm/t16.decode +++ b/target/arm/t16.decode @@ -23,6 +23,7 @@ &s_rrr_shr !extern s rn rd rm rs shty &s_rri_rot !extern s rn rd imm rot &s_rrrr !extern s rd rn rm ra +&rrr_rot !extern rd rn rm rot &ri !extern rd imm &r !extern rm &ldst_rr !extern p w u rn rt rm shimm shtype @@ -173,3 +174,12 @@ BX 0100 0111 0 .... 000 @branchr BLX_r 0100 0111 1 .... 000 @branchr BXNS 0100 0111 0 .... 100 @branchr BLXNS 0100 0111 1 .... 100 @branchr + +# Extend + +@extend .... .... .. rm:3 rd:3 &rrr_rot rn=15 rot=0 + +SXTAH 1011 0010 00 ... ... @extend +SXTAB 1011 0010 01 ... ... @extend +UXTAH 1011 0010 10 ... ... @extend +UXTAB 1011 0010 11 ... ... @extend