From patchwork Wed Aug 28 19:04:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 172483 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1252159ily; Wed, 28 Aug 2019 13:23:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwciZWZfp/95uPvGu4GKIugCUJKzrKUuEEEzF2ZSg0CrebLkS4KET5P+51/+tQbEMZriFb6 X-Received: by 2002:a17:906:e215:: with SMTP id gf21mr4948304ejb.213.1567023795991; Wed, 28 Aug 2019 13:23:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567023795; cv=none; d=google.com; s=arc-20160816; b=n/kxUG0p/0XgJoJwm8jzr0QMTVJLCPmZY3xx+JUxhJxR02yQCFQR6QTRQ3Z5AjsepX 1WGQRQ9CjkGKHjEg/luq6/29vXnpW/VcKEqBuu3ccm9JoeYpGn+az7ardnZtvhVzmfpb soWOAVqEYCa+NjdwjrBKgSK0mBxkWUc1UeM2ygqZcm3PlC1MBys/7X1drA/BssnjI0Mn VV0Qndv/9iOiZ3gbdRqtDOEwQ9vCWe7/ZWoNdfosWWZVvVkgZnIPP6xMWf59eu8vTuGX LFxn6pEdylvsbS42m1FQznrBoqmHuCNgkhNF0ogpeye5ua89a31neru3Fx0kITF/Hz1c YP0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=xx52JC6MANGMEBBAfqEp/mRO3ZRBD9ucqNlmZ54oyt8=; b=TsD9fs6qKFd+O6NpFje3dY+FR52gOCGguN4mPSHwz2ksMjA5OCdB9+Vvk7AWBKQdJa 2R88ypJS8kPd2WWji8Gz1LdCkQ8Oit2B5d3XVA59suqXOYMWn5xJTKBWKworclAskYll X6px3hAwvz7Tx4L1AexGRE1VW6CD94rtQmUHbQBg5v5cEO0zkDNUtVd7zn5yl5wxvo5M GZ8kTAYUR7VVIZqJfr6BcdfTGjPYpenFRiFayYyug7WGDUCp71LSdhBkaw/Qajpdym6d g0LsKSmj9kIf9FbQ944S3pZ0+f9W+eDkcbQDgGZFJrVZnvokktBAGmOb3Vk73/y2wfPb Kerg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CgZsatjT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c20si35727ejk.345.2019.08.28.13.23.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 13:23:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CgZsatjT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i34TK-0006cd-P7 for patch@linaro.org; Wed, 28 Aug 2019 16:23:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38845) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i33Gu-0003ze-Mu for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i33Gs-0000ix-23 for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:19 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:38703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i33Gp-0000gV-8T for qemu-devel@nongnu.org; Wed, 28 Aug 2019 15:06:15 -0400 Received: by mail-pg1-x52d.google.com with SMTP id e11so224308pga.5 for ; Wed, 28 Aug 2019 12:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xx52JC6MANGMEBBAfqEp/mRO3ZRBD9ucqNlmZ54oyt8=; b=CgZsatjTMnGY6El4ng2xbpq1IVLnbLN6zm0b5U6wzXR5EQY5ssnXPpWI747kkrLX9r yKtJGuMsEa/8ecuZnRM3c569t7zNqKpDLKW/uSjZ7TRWVAlDpULv1Q7sKsqUPxGRKfq4 blvTw2xX+7rxfuNExyoYiJ8eE+DmnSYu9RzYax8Vk2G/2XR4vrxdIuYC4XYflmi3DEqc e4+fE2Ksq0/LdITyOrxrrJY53PJDakVzJeAJwQfoJJxWJlpLeVjWo87BWer8U7THUW0l OqDK6EFMseTIYS4rYEF3epvZgPTYwBOLK1NiW9LVDHHV9Vr/kxM4Ghjt7HrIOrnGZDsT +xCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xx52JC6MANGMEBBAfqEp/mRO3ZRBD9ucqNlmZ54oyt8=; b=UatXHAdHWI1iosdjLFHS5MVWManOWZuAaCL+9jptSMI9DljsuXrUdnOJaA+LeNdNfx eHhGWjhVvzpPWMHSLtTbwHy0bE4Cxq166X6Ea/JFWEjXiOoYCAMU0hTFBWwxy17kYjsf VcgBPqTY0l3N1+oTXIL+nj/PmfpOdUhpaFWQ9W4019h8k4FioLnxjQM6WwKH5y4mdnBe 0VVNTpgPFgfb40VNy4MFjBaQvhpSFl7TIO2RkexY08Lp3dwO1gXzokIhfvq/utP4KpWz Q+Uzy5tOmAIUioIz/vlC37QyR8u7WVDgGup4sEiGM2CIBlkyrOCNJUAYLbKy5/k9LIc2 +1Yg== X-Gm-Message-State: APjAAAVUxS76WuIyK3CnqENfZXMaiWSPy/dWjjPVz4iU+b/YYZah3BO1 mnu7NbJwEAGOpu1uCfplGrjJD2yB4eY= X-Received: by 2002:a65:6846:: with SMTP id q6mr4827170pgt.150.1567019173561; Wed, 28 Aug 2019 12:06:13 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id f27sm2967944pgm.60.2019.08.28.12.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 12:06:12 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 12:04:45 -0700 Message-Id: <20190828190456.30315-59-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190828190456.30315-1-richard.henderson@linaro.org> References: <20190828190456.30315-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52d Subject: [Qemu-devel] [PATCH v3 58/69] target/arm: Convert T16, Reverse bytes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.c | 18 +++--------------- target/arm/t16.decode | 9 +++++++++ 2 files changed, 12 insertions(+), 15 deletions(-) -- 2.17.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 1dacae1a5b..ec5b095bd1 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10707,7 +10707,7 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t insn) static void disas_thumb_insn(DisasContext *s, uint32_t insn) { - uint32_t val, op, rm, rn, rd, shift, cond; + uint32_t val, op, rm, rd, shift, cond; int32_t offset; int i; TCGv_i32 tmp; @@ -10904,20 +10904,8 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) break; } - /* Otherwise this is rev */ - ARCH(6); - rn = (insn >> 3) & 0x7; - rd = insn & 0x7; - tmp = load_reg(s, rn); - switch (op1) { - case 0: tcg_gen_bswap32_i32(tmp, tmp); break; - case 1: gen_rev16(tmp, tmp); break; - case 3: gen_revsh(tmp, tmp); break; - default: - g_assert_not_reached(); - } - store_reg(s, rd, tmp); - break; + /* Otherwise this is rev, in decodetree */ + goto illegal_op; } case 6: /* setend, cps; in decodetree */ diff --git a/target/arm/t16.decode b/target/arm/t16.decode index 032902a1f4..19a442b894 100644 --- a/target/arm/t16.decode +++ b/target/arm/t16.decode @@ -24,6 +24,7 @@ &s_rri_rot !extern s rn rd imm rot &s_rrrr !extern s rd rn rm ra &rrr_rot !extern rd rn rm rot +&rr !extern rd rm &ri !extern rd imm &r !extern rm &ldst_rr !extern p w u rn rt rm shimm shtype @@ -195,3 +196,11 @@ SETEND 1011 0110 010 1 E:1 000 &setend CPS 1011 0110 011 . 0 A:1 I:1 F:1 &cps mode=0 M=0 %imod CPS_v7m 1011 0110 011 im:1 00 I:1 F:1 } + +# Reverse bytes + +@rdm .... .... .. rm:3 rd:3 &rr + +REV 1011 1010 00 ... ... @rdm +REV16 1011 1010 01 ... ... @rdm +REVSH 1011 1010 11 ... ... @rdm