From patchwork Wed Aug 28 23:16:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 172511 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp1420372ily; Wed, 28 Aug 2019 16:21:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzSeDSA78a24ZO2ntCNNDLXQnuTl4jrzMd5INbpw3abVYOZQ0g59znMKHEfpKML03VgjCz X-Received: by 2002:ac8:36da:: with SMTP id b26mr7272494qtc.284.1567034503552; Wed, 28 Aug 2019 16:21:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567034503; cv=none; d=google.com; s=arc-20160816; b=HeLFQsBOkjbxrRMQxgdMwTHTHJYS6mca1jLH8q/y/sdjUuFKUgwsu64bVBGCa4lEmU +gTsLJoorIwbY3+sfSAWsBBFSabXpOEqIgni6AsNN38Nj7LbBYtRos6+ZZ7muENq8osl r4cssjlBRJTNSGVRZcAOQGLxAC4QvgYxX06Fm75Mz9gkUIjyyf6er5zSCyOqKv0t+KU8 Az86Irgg3Vqt2tgYPJTioxze+m9Te7BY2jxp8uLGOp5mcSY4rjuNBHy9bFhElHVlV4C/ kJlW603ewnIW5k5Wf2Rhe3t/YAr8VPHoJHW4VBJkFK8rgW4lweieZzVZhryYWA8kO6dF Uu1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Gm01TIX2dgmE2RJ8CmJz1CGP7nGYi+1YuaceKCL3Jzs=; b=U/Xas5WXLR/pCbzk2wF83zvkKSH7hb5FnGVbnYdF16ElIkAyBoh10HPWJaNuqab5DG 9eB676B8c9Wsq2IZe+zRO4Jwh0h0mKAsXbvgltDG6288lCYP2sggzX5/gAjksDgeNDDn zRzLN/nMqRNY8/bzZ2/pB6X3mgrnvdT7H4fByNJf9BKUWdpYA8OjhqaUaKU79elwOpsD +htMQAsf8XyuguV8AqnPlOo+ltjOq8tNgCsteN6GUkVQkghCmKQn/nE8Epa1to+fOccq FdFVE7jQvLoH97Bm5ZBZOAUK6hH5FO5d6thcZ0ZVtDQCR6DwSkpxHJwZ3AFKi46XYMMA T6TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=orlrpns2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s39si570562qts.69.2019.08.28.16.21.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Aug 2019 16:21:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=orlrpns2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:43626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i37G2-0007e9-IX for patch@linaro.org; Wed, 28 Aug 2019 19:21:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52344) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i37BW-0004FK-S3 for qemu-devel@nongnu.org; Wed, 28 Aug 2019 19:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i37BV-0008H5-Uo for qemu-devel@nongnu.org; Wed, 28 Aug 2019 19:17:02 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:38780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i37BV-0008Gn-Oc for qemu-devel@nongnu.org; Wed, 28 Aug 2019 19:17:01 -0400 Received: by mail-pg1-x541.google.com with SMTP id e11so516530pga.5 for ; Wed, 28 Aug 2019 16:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gm01TIX2dgmE2RJ8CmJz1CGP7nGYi+1YuaceKCL3Jzs=; b=orlrpns2pUjBuMAHKF+faUFWHNQVF3WdegcMszTxlLr2nXp0hsLQ2IMUCoxy56T5GL gXfV+6fhHvTTfsDMLurG0ZWuoVflCrBHeaN6Dpq5ShbfLfrPYdzk07NoMaAxWPSCe8FE dk7qnKC/SDU1vi4/zJRoe+cAgit/sXFpk0851sxCTWSgo/fSzQm6JpVEB6G8OmRlO48O LLCiqZo3juMV1Tf/LvYXvlPf4v475mE4wvcA5LLsQisW/ybuapygUwA30P7ISW6MP9JX aXLntQ5Ffa+9/UOCHTifLlE9UxhViphb52IUvXDzFm7xbmDxixULjaPpQ963U4OE4bON fDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Gm01TIX2dgmE2RJ8CmJz1CGP7nGYi+1YuaceKCL3Jzs=; b=a4BibgxAnsSsSPyb/Qsz3M7dgmEKoiVjdesxKl04DGS/MyetPtIfl7laIauaJf86Ur omIcUDmKoRnsgxukKMjKUHWL3Zb/H21ywOX2GKoiDVZobYRgk7foQHWmX+U3vNykgkfl NCTdZLiat/uOW/lcCg47qhZaVjod/vea+lpLToEq0DVpWqvfC8IqlDdh7VTEnjfGMEpY /RLnzfiDWPFfxgzxlkQeNbF4ZAQngBh/pU6W7458x96dG3bhcI0hEbin87V3RJlUUDwK 04HztF/4J0BLa9GfLNN7EVjeE3A1WPdH4d1hkF3NhJo1tFOpj6Xbjf6XgCr/8tp/eex2 JTkw== X-Gm-Message-State: APjAAAVYDVK4zg4DjoqJ7tNTstmrRFtRMlH3LFtMlYfytTljKf98aqqZ guxoxdmzV+OJ64TYT7hi3mHD7z7WWbY= X-Received: by 2002:a63:ed50:: with SMTP id m16mr5525536pgk.209.1567034220394; Wed, 28 Aug 2019 16:17:00 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id s5sm485197pfm.97.2019.08.28.16.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 16:16:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 28 Aug 2019 16:16:49 -0700 Message-Id: <20190828231651.17176-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190828231651.17176-1-richard.henderson@linaro.org> References: <20190828231651.17176-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH v2 6/8] cputlb: Remove double-alignment in store_helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We have already aligned page2 to the start of the next page. There is no reason to do that a second time. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 7fb67d2f05..d0f8db33a2 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1518,8 +1518,7 @@ store_helper(CPUArchState *env, target_ulong addr, uint64_t val, entry2 = tlb_entry(env, mmu_idx, page2); tlb_addr2 = tlb_addr_write(entry2); if (!tlb_hit_page(tlb_addr2, page2) - && !victim_tlb_hit(env, mmu_idx, index2, tlb_off, - page2 & TARGET_PAGE_MASK)) { + && !victim_tlb_hit(env, mmu_idx, index2, tlb_off, page2)) { tlb_fill(env_cpu(env), page2, size2, MMU_DATA_STORE, mmu_idx, retaddr); }