From patchwork Thu Sep 12 18:30:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 173724 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp2507112ilq; Thu, 12 Sep 2019 11:32:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAxCvO4Ag+pMkGoGgZEpIZlE9T/GFNhDddfaW5auDd0fkThnYzAJi0XecevcxUrRzU86Wi X-Received: by 2002:a17:906:31c3:: with SMTP id f3mr36489816ejf.296.1568313173706; Thu, 12 Sep 2019 11:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568313173; cv=none; d=google.com; s=arc-20160816; b=PrFsrYerWww1O9ZK6XrmM+s4sFcNZy8XbzJ7ts8UhWgPvbeZNVErY0yC4Uw6tAgEy5 oJ546D4B5dLJwFnnyj0IHgDn1IrLBLgCqxGj+7qSkhK96YApNTuTUINU3v4QHCoqmNnY Tdc4uWcZvTAm7W1vXH8D7XIKHKk5a3ZY+8mNx/VzFSH9214S8C+iyqtm92P7ZGEqJeRZ AnIXR20At9N/W1YsRU9EkCUY3s/zHuk2DUaUypPzvlGAzVHwxNW9XD6mlpBO7NhkzrGC +FtDUtns3uUAjU6gDfvqOP53yYdIvyAIZMY3i4I6Gt9zFow95nApmmintBDbpG4/cshr xIVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature; bh=Vtjd35BPZakeIT6rdGzEIxB/QlMjv0TxGabTZRgNM8I=; b=YLsENVAAEqfy9kp0Bizja1M+FnHO2Q/MrDj12vw75wTnIoN8I6pktybon1jTbbRd39 J3wSq9iIJfs8f/8ea0v3q4lmPJ893qZ/5GkbyeHza45fyOLj430J+8ZGay1gpL3Qx9Pe W9DiRwlYZsgJ5dYkjfqerzs7FRJCIuysefqIPXLqS6U4rud0Q++stsgOh/s/xbuzyM/f FLlL+zODAJGStb9aQ/+Ec6Tx84K/+6+KoYemSXMPwPDSlKTrksP+d+WHw6WKCqLo9ZBa GRvtcxpohzrTV1nWgaE2Ia4/XE7Qa5/1ZIIhAT5K86xdFSAeCiwkXEsaLbfQ85LTiN8z xUAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IQzd8xNM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n22si13772521ejy.235.2019.09.12.11.32.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2019 11:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IQzd8xNM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8Ttk-0001wa-JS for patch@linaro.org; Thu, 12 Sep 2019 14:32:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57265) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8TsA-0001wA-TQ for qemu-devel@nongnu.org; Thu, 12 Sep 2019 14:31:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8Ts8-0008UJ-SN for qemu-devel@nongnu.org; Thu, 12 Sep 2019 14:31:13 -0400 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]:44291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8Ts6-0008Lu-Jw for qemu-devel@nongnu.org; Thu, 12 Sep 2019 14:31:12 -0400 Received: by mail-qt1-x842.google.com with SMTP id u40so30768141qth.11 for ; Thu, 12 Sep 2019 11:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Vtjd35BPZakeIT6rdGzEIxB/QlMjv0TxGabTZRgNM8I=; b=IQzd8xNMzyZuJaSrZQ1AHLSVDDljKBXeGGcnfSSK4uhK2XE5gQIN9EHj3k5E9TjY5T TkSH/uUffv+QvtAX/HNr7uruCP2v0FuCZZAbxu1ND2c52Ype2df2dtXn1eIAJggqXeDT iY96ZD+2ZQwel7l9LzYe6YD2G7sNv2dRHJGggDOJXx66Tp6RXN2giOpqc5SxF5SMlowx Epuc0xkC/9dtjMoOd45sIMt4gOwThINnnEHK8EgHgrxzU3Paz+S548022JH0NuJenNcR zXnGvaGh6eFVmF1lrHbEG7mS2IWTyQseAt6Ta/9ES1P+Y4UUXWvpLS1CfUkWJ76s2UZq qVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Vtjd35BPZakeIT6rdGzEIxB/QlMjv0TxGabTZRgNM8I=; b=OAZaRP2R/b5uSLYuqc/rPCCSQ3d7lXQWjxODiLOfjDs8HHh5mvuSA4xoKOW0gjyy9+ leJK+0KGyJzMr4Y1f13EQyoXOY1r4Tt/69EUNPuSyxUVDeHDXj5TP1aYdnV0rcgQYP1Z GKB+wKFEDgIZ2YjM4RsWzuiD/VVfFsHjrHhYNjc6nvyj2hjRab/ay17eBRAzpvbonD1g xVAHSJ5pPA92VB//AhVylOku5LqJ1LqByw5PWKxIkh93zOn+Ox2eVq2CAmdrhsvNoyr5 Hbh2cy0D694vbNE+wF783qYs5brz97mihyp2OWOJExxcR82N2zmuEabyF6DTNebjCewx H/iQ== X-Gm-Message-State: APjAAAWXoA57vDlhCsNxjRdaexatSCfrD6AUwsPbDj6LMc1MlJShMQYF LQU6GBfyArGpvY+YdUc3bXBAdkgd7uElQA== X-Received: by 2002:a0c:fca4:: with SMTP id h4mr1292690qvq.236.1568313060542; Thu, 12 Sep 2019 11:31:00 -0700 (PDT) Received: from localhost.localdomain ([67.69.50.154]) by smtp.gmail.com with ESMTPSA id t26sm11314116qkt.10.2019.09.12.11.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2019 11:30:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 12 Sep 2019 14:30:58 -0400 Message-Id: <20190912183058.17947-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::842 Subject: [Qemu-devel] [PATCH] target/arm: Fix sign-extension for SMLAL* X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The 32-bit product should be sign-extended, not zero-extended. Fixes: ea96b374641b Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.17.1 Tested-by: Laurent Desnogues Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/arm/translate.c b/target/arm/translate.c index 34bb280e3d..fd2f0e3048 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8045,7 +8045,9 @@ static bool op_smlaxxx(DisasContext *s, arg_rrrr *a, case 2: tl = load_reg(s, a->ra); th = load_reg(s, a->rd); - t1 = tcg_const_i32(0); + /* Sign-extend the 32-bit product to 64 bits. */ + t1 = tcg_temp_new_i32(); + tcg_gen_sari_i32(t1, t0, 31); tcg_gen_add2_i32(tl, th, tl, th, t0, t1); tcg_temp_free_i32(t0); tcg_temp_free_i32(t1);