From patchwork Fri Oct 25 11:39:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 177718 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp3567813ill; Fri, 25 Oct 2019 04:40:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFhaz5cggyHP/qseEMOiAiv+7S4MVJzlvbDHfQZDVwg/CAhxW9C30x2+0JbXWkrrGgdaLx X-Received: by 2002:a37:f905:: with SMTP id l5mr665141qkj.90.1572003627498; Fri, 25 Oct 2019 04:40:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572003627; cv=none; d=google.com; s=arc-20160816; b=AVE+vw/MJvrNrEnMALzXJugvf42cFz0qH05DE191OBaVXIPLjqNOzFdTryypl5cfkT xihsPLLbDtXApBsNFe6v4lcyZZeVBuCTqbMnVV1K32flB/eTsfqZ8It3NIUz/4Q3iJuX sW/u2wkY/0NwizPxCAMtZQD62EhZiZcRQVLdvRRdsUWJzlDFsRfdpg0xgD0R1TMoUuvq mU5RIvWAHlZSdnJUz17r9WUHS5+7yLA8GJbB03XdyZfq5xne+YDU2luIpyATX0+6VpXh Pw7OrIR/KYiZ8t5sHi3RbPkFixB5mYsV0TBiFFGfaTuNDnYUXSMIO0kUGCBXqjppHI2u wvcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=RPOooG/qzrYvwV59r2e90DUXAtJHgbXT1XUOCv1dvV0=; b=lN6QRZqHwkJ1NZGy1RrmWZQZ6h+f9i3EnqB6T1zZJ5CvsyF6olxtULjlqDOCCfboIy sOLkJ+FGye1FD6qLFF8pr6UjUlWiI+Z7VHrrPAfeGjZYpTqL9mEs22W9YikAtSY1dMVY UEmY+G33Uxp0P5UBm0RyfFV8cjhF/lgtIftbwOM0rBDqq/cjZ4IrAHKSW/Mey3nyeSe3 Ro5H9bGCbahbjPOfj9AjUkYYaMwFJIQYN+8Sn2/TGmrzmKmuHGQv47shu0TrjbOSntz9 OCc3h4wcOCYuNL2VPluXWYPsUecg/YJPgHbgGcouG7ItT3+l247NjRUwhblUqZU9ipkf MKzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cV1M6LmQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u61si1223355qtd.273.2019.10.25.04.40.26 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Oct 2019 04:40:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cV1M6LmQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNxxC-0006aK-7r for patch@linaro.org; Fri, 25 Oct 2019 07:40:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNxwK-0006P3-Fl for qemu-devel@nongnu.org; Fri, 25 Oct 2019 07:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNxwI-0006bz-Dl for qemu-devel@nongnu.org; Fri, 25 Oct 2019 07:39:31 -0400 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]:46897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNxwF-0006aB-4Q for qemu-devel@nongnu.org; Fri, 25 Oct 2019 07:39:28 -0400 Received: by mail-qt1-x843.google.com with SMTP id u22so2655588qtq.13 for ; Fri, 25 Oct 2019 04:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RPOooG/qzrYvwV59r2e90DUXAtJHgbXT1XUOCv1dvV0=; b=cV1M6LmQloVXfRNGHYBEq9bDKP2ivRdJ6N+l3OuK1HiIU3y4jGzYiDX8DtK90JJx+s wbCWHRhjced+ZAQB2xM6CCqv/CUM+DvQYt779ygR68lu78mF54CHRO8CXKzEOmP6WC0l oqXzU/nWrIXpWl9TWOUYW52UD+STUeLAdA65TqArbYNZ2rvzo+R60sDEwgJ5EDEPa8n9 gO+RkeKbx6KzxrrImNfWCP+ywn7PJM8WivhweEUUAHjlWqSAhoM1RyM3qpJkBGAWm4GL e4O7AWOqhbPUvn7G0zvAvRmd0mrLJKGEK1jrEMLM+BjHsLmIHJEwLJAb0H96rDUmCBoJ c5hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RPOooG/qzrYvwV59r2e90DUXAtJHgbXT1XUOCv1dvV0=; b=LMwgb+RtvNGNC1H0cfjF5CGATKi/cuga0p9zRq1YcMUUQByb5300kpvYvsX6mMU2ie MsoL5oADZCJRpBpGARkPcDwaJk80s6/VQ26aAjgVgiUZ+UJSCrtR0GF9HJwl8RR8vEH9 QQE6K7YU3PnQsAOSLfu8VGjqw+U4x8g7r0vt+B2uW6v5gc4JNzn6SVw7EPPzO/e/BjKK T6jgHrjE27q2V8aeun+sogm7OCxf27S1fu/0L6vSYPSslV8uQml1DrTlKHexqP7YeBPi qlTAx9UxbWEb+YjMuWkc/XtyFEF5hx0xhKIxaihyDS6XozGTY0cY/svyzg8Z5Y8yNt1W 3Tpg== X-Gm-Message-State: APjAAAWQ6fv/u7+tYQYrD+JkZsgfwZola73nunlWCjL4qiFjB7tlfVTQ Hrj5CB1kg0+6eJJBalLF0aYFquUw12I= X-Received: by 2002:a0c:e60e:: with SMTP id z14mr2787832qvm.124.1572003564979; Fri, 25 Oct 2019 04:39:24 -0700 (PDT) Received: from localhost.localdomain (rrcs-172-254-253-50.nyc.biz.rr.com. [172.254.253.50]) by smtp.gmail.com with ESMTPSA id x38sm1473335qtc.64.2019.10.25.04.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 04:39:24 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat Date: Fri, 25 Oct 2019 07:39:11 -0400 Message-Id: <20191025113921.9412-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191025113921.9412-1-richard.henderson@linaro.org> References: <20191025113921.9412-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::843 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The error indicator for this syscall is -1, not 0. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- tests/tcg/multiarch/linux-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index fa4243fc04..673d7c8a1c 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -503,8 +503,9 @@ static void test_shm(void) shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); ptr = shmat(shmid, NULL, 0); - if (!ptr) + if (ptr == (void *)-1) { error("shmat"); + } memset(ptr, 0, SHM_SIZE);