From patchwork Fri May 15 17:08:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 282597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF2BC433E0 for ; Fri, 15 May 2020 17:13:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E88EB206C0 for ; Fri, 15 May 2020 17:13:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S1k3BOs8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E88EB206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZdtO-000883-4Q for qemu-devel@archiver.kernel.org; Fri, 15 May 2020 13:13:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZdpF-00088N-Tw for qemu-devel@nongnu.org; Fri, 15 May 2020 13:08:45 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38652 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZdpE-00030a-TN for qemu-devel@nongnu.org; Fri, 15 May 2020 13:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589562524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5ITVoQ1ZbyJY3869Qz0QJKhcD0XsDNN4PZcYvj6FH84=; b=S1k3BOs8jR0RETtGS4vLGGVJsTiWwt+PEDj1qaBRANdwjNyeOa8EXSu1UV5QoXxmdMwu6Z pT/m0pXl2zmBvq7w49TYM3DctU8tHVlETbIILbgzr6fsbNs+wERhiaC2jQSn1EZlqAsM0V lD0gYaRLG+5BG9ztC+Nhk8UZ70NVdAI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-xIrDdNRZOnS5UxqkYJquaQ-1; Fri, 15 May 2020 13:08:42 -0400 X-MC-Unique: xIrDdNRZOnS5UxqkYJquaQ-1 Received: by mail-wr1-f70.google.com with SMTP id d16so1461765wrv.18 for ; Fri, 15 May 2020 10:08:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ITVoQ1ZbyJY3869Qz0QJKhcD0XsDNN4PZcYvj6FH84=; b=JGizm3nz2YKW63MMbtt/bp8AlCemn1/D2Y0iAiVNTHu5x8WJ2roEtiLWyM7mObeqDE wygW1PDSyWD8zHjIFHaykJ8GKyFJW2C0dqtRx4zIwx66NLGCda31fzkttQ+mbioOeYJe sQEJimA5z0GiM7onrvM4s6ttA6emIVWIjZV4N7ubM/qtoHrb3LGLDACQrLMnWrry8ZlU zy7KUQMnavFPATvzeZaKLyQEx8r/GCwqny91MUqVyBicttDTRbfRlgi6zhXb32GDd00u LYHw5RrQGgWFYyy3pOOl0d757Uq7mOyejOgH7LlcA50/65GJ+dtwptkFI85DQGQA1u4x sHBQ== X-Gm-Message-State: AOAM5312UK0r8hFbKTUxb30zX4/9cVvm2xIiajXM0yRbBvUN271WD93/ 0cjW0gds8ynAJ92zvgenH6Uk/ULXPQsexXwwslpjwu3u3qFsT7OXvyH+lKfvC3gTeyuGtpIbewO CwN+RX6mZ344jKW4= X-Received: by 2002:a1c:b354:: with SMTP id c81mr4963870wmf.136.1589562521312; Fri, 15 May 2020 10:08:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmx+ZO2tfR2y8eEMofGp0DBekFYHDX4bY/GfboFJ/NDQMoQkIi+Tv5ej2TCEVaoDExRhm5BA== X-Received: by 2002:a1c:b354:: with SMTP id c81mr4963827wmf.136.1589562520987; Fri, 15 May 2020 10:08:40 -0700 (PDT) Received: from x1w.redhat.com (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id h20sm4351735wma.6.2020.05.15.10.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 10:08:40 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 06/10] Makefile: Write MINIKCONF variables as one entry per line Date: Fri, 15 May 2020 19:08:00 +0200 Message-Id: <20200515170804.5707-7-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200515170804.5707-1-philmd@redhat.com> References: <20200515170804.5707-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 00:07:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Peter Maydell , Thomas Huth , qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann , Chris Wulff , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Max Filippov , Aleksandar Markovic , qemu-arm@nongnu.org, Palmer Dabbelt , Michael Walle , Paolo Bonzini , Alistair Francis , Aleksandar Rikalo , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 84453789f9..665900d5c8 100644 --- a/Makefile +++ b/Makefile @@ -418,12 +418,15 @@ MINIKCONF_ARGS = \ CONFIG_LINUX=$(CONFIG_LINUX) \ CONFIG_PVRDMA=$(CONFIG_PVRDMA) -MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig -MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig) +MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \ + $(SRC_PATH)/hw/Kconfig +MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \ + $(wildcard $(SRC_PATH)/hw/*/Kconfig) MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak - $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp") + $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) \ + > $@.tmp, "GEN", "$@.tmp") $(call quiet-command, if test -f $@; then \ if cmp -s $@.old $@; then \ mv $@.tmp $@; \