From patchwork Fri Jun 5 17:58:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 281242 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38AAAC433E0 for ; Fri, 5 Jun 2020 18:05:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04CAB2077D for ; Fri, 5 Jun 2020 18:05:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J9yYzJ2L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04CAB2077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhGiw-0006ki-79 for qemu-devel@archiver.kernel.org; Fri, 05 Jun 2020 14:05:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhGcS-0005Yg-50 for qemu-devel@nongnu.org; Fri, 05 Jun 2020 13:59:04 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:34804 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jhGcR-0000Vw-Ba for qemu-devel@nongnu.org; Fri, 05 Jun 2020 13:59:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591379942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPfSgBN6V2tVMS8P3LJc7AXq2ATI7aQPyqGZHft5RHs=; b=J9yYzJ2L1JlVnGudclqT11EWopFvV2Iznw/Gk0Eo0a30EYa4Nc1u9NAMm5tMCsisAB4Ulx eYkjKndfSK3OZdksUoexLS3YC6Zz3NXqiiZNI6q76yjVzZ6tpiIbT+JPBvKAFeaS8/2FRC AFhsXMD989V66Y/3dDLqv4P58Si7THQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-oFROrpgcOWOITrHXo0gRxw-1; Fri, 05 Jun 2020 13:59:00 -0400 X-MC-Unique: oFROrpgcOWOITrHXo0gRxw-1 Received: by mail-wr1-f69.google.com with SMTP id o1so4044826wrm.17 for ; Fri, 05 Jun 2020 10:59:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GPfSgBN6V2tVMS8P3LJc7AXq2ATI7aQPyqGZHft5RHs=; b=MQi9mcZZR9a273b7kpTf409T3jXNX4nY6xYRU70jj/FAKWBbXg+6Dha4hYN0oYOxWh 8vg7ufYoL1mxN3pTEYRcFrbOEBk91gEcGF+hby9NZECPkt3PtuqYgo1EcmPnBVymjfCm slStEggom3qsetohQ8NA9ct7Jn5I0u6fDO5dS7OkP78lynoIwGcIJgHRET1uZb58bmEZ nViTh1nP6AOrPPeeTy6bicRg5jiui5D3TCuQeLBG+YHSMg1BAh3NOwj5GDaf+LkHvtm0 KnAgNbpJXVTxQjRIbiGctF8IrUwbe0uU266BK7v6pAwTzPnIFF3PcP0EQCIZCjZhM16A mlnA== X-Gm-Message-State: AOAM532jG17uonO9MeTGi74pFBoastktumFSborXQ1YTUEspUgItiKcO +r/FHM8kegvpDtQDyYuQa18aM0ktOUEXR6dJHlPgRLMaT3qgFopXwIEiO+XySt1mv/96NWDyrFs efKPhBa5EyITZZlM= X-Received: by 2002:a5d:4987:: with SMTP id r7mr10555676wrq.316.1591379939245; Fri, 05 Jun 2020 10:58:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvIbTz7xMgsdT1OJNoupD4qxipXie3Rspw0xyPt1Jd2nlrOOhTJ+k6e8Zu5N7u72AqZRBs0g== X-Received: by 2002:a5d:4987:: with SMTP id r7mr10555663wrq.316.1591379939038; Fri, 05 Jun 2020 10:58:59 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id u3sm11966493wmg.38.2020.06.05.10.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 10:58:58 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v7 07/11] Makefile: Write MINIKCONF variables as one entry per line Date: Fri, 5 Jun 2020 19:58:17 +0200 Message-Id: <20200605175821.20926-8-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200605175821.20926-1-philmd@redhat.com> References: <20200605175821.20926-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/05 03:35:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 6c9d718b2c..7666f81e8a 100644 --- a/Makefile +++ b/Makefile @@ -418,12 +418,15 @@ MINIKCONF_ARGS = \ CONFIG_LINUX=$(CONFIG_LINUX) \ CONFIG_PVRDMA=$(CONFIG_PVRDMA) -MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig -MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig) +MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \ + $(SRC_PATH)/hw/Kconfig +MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \ + $(wildcard $(SRC_PATH)/hw/*/Kconfig) MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak - $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp") + $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) \ + > $@.tmp, "GEN", "$@.tmp") $(call quiet-command, if test -f $@; then \ if cmp -s $@.old $@; then \ mv $@.tmp $@; \