From patchwork Mon Oct 12 09:57:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 303130 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E6CC433DF for ; Mon, 12 Oct 2020 09:59:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6880A208B6 for ; Mon, 12 Oct 2020 09:59:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Afke2oLk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6880A208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRucF-0001RO-Ch for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 05:59:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRuaz-0008O0-1X for qemu-devel@nongnu.org; Mon, 12 Oct 2020 05:58:21 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:38385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kRuax-0002ko-HZ for qemu-devel@nongnu.org; Mon, 12 Oct 2020 05:58:20 -0400 Received: by mail-wr1-x442.google.com with SMTP id n18so18449601wrs.5 for ; Mon, 12 Oct 2020 02:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PwcUcNfmDXAXz3ZdCfHv1ZWyP4lS5DeJuKN8TDRFEM0=; b=Afke2oLk84c/91f8ro6BCV6WqmOKymh5A9C9pxGLZVplAHfTK+uHHYHxsFtcu7sxiN WNhgCsMGi1YdT1B7XD/HuShdNkLokctrEJubWgsgBOvSPk4ckjMktiDCLg/ha/Yw/3Tl B77N0+Ppsdlu7T5e64PXdlEKow7zGC7Bu+UesustIbT+1h+lU2CPEczlBrPNNJ7ZaAYh /mvtsMcgEZbXZAEpaFdbjoxC6osOM8Hk2I2OZ4/c4AazCrBhKIrThylw6+4lMiTYrbOa qnbwKpq8vpjiJSlRSFfotYs0Vtc4XvO5+hCLt6A4pPoYO6mVOf8xll7FaIeOHL4+003Z 9caA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PwcUcNfmDXAXz3ZdCfHv1ZWyP4lS5DeJuKN8TDRFEM0=; b=Sf26mv4NVtMyzaM5Yc1Xy7jpNB4vkKMdDqfUngwVe+oVpZV7kZ7tZ3B41PwKG/wTBu QmUwqwRSyy58yWcVp2npHvZPAcmPqwhgppKm1hXve3AhRWXyTap4ukiNO/wTjn93pBe1 fuwL02K7oRtHZVK/Dj0o4TCLjBTIhR5nOtqY2ZXe8wXaUAkspczDTpF9k/aeOOp/bPx8 VHCaaFqjOuLY4/5ie67ZAvyUh33oXB555zBDfhRB7Acyp6b4o1fQuMhCbeTaZL4UfleN aOUz2/hfBx4ILmVngJOlS7lHIlecoD/WFJLfkz4K/DRaQGG8ni9kpaDQVETdMsB7kdP6 LNZA== X-Gm-Message-State: AOAM533gCt1aOH9jhfJvTORPoGyi2d5SSYZTPN8/5IrQJcFvs1kvvM9f YqHREabgew49yp7l9bEV03vSEnM1e+M= X-Google-Smtp-Source: ABdhPJy13cIQCD/UZGSJtlwqhG7e9HriF9Jph7dReRID8RnEZqd/dyxWDAgPo5aQLYvqMjip1biS7w== X-Received: by 2002:adf:f247:: with SMTP id b7mr2966826wrp.56.1602496697864; Mon, 12 Oct 2020 02:58:17 -0700 (PDT) Received: from localhost.localdomain (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id f63sm22951584wme.38.2020.10.12.02.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 02:58:17 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 02/21] qdev-monitor: Display frequencies scaled to SI unit Date: Mon, 12 Oct 2020 11:57:45 +0200 Message-Id: <20201012095804.3335117-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201012095804.3335117-1-f4bug@amsat.org> References: <20201012095804.3335117-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Huacai Chen , Aleksandar Rikalo , Luc Michel , Eduardo Habkost , Paul Burton , =?utf-8?q?Daniel_P=2E_Berrang?= =?utf-8?b?w6k=?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Herv=C3=A9_Poussineau?= , Huacai Chen , Paolo Bonzini , Alistair Francis , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Since commit 9f2ff99c7f2 ("qdev-monitor: print the device's clock with info qtree") we can display the clock frequencies in the monitor. Use the recently introduced freq_to_str() to display the frequencies using the closest SI unit (human friendlier). Before: (qemu) info qtree [...] dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=3.333333e+07 mmio 00000000f8000000/0000000000001000 After: dev: xilinx,zynq_slcr, id "" clock-in "ps_clk" freq_hz=33.3 MHz mmio 00000000f8000000/0000000000001000 Reviewed-by: Luc Michel Reviewed-by: Damien Hedde Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- qdev-monitor.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e9b7228480d..a0301cfca81 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -747,11 +747,13 @@ static void qdev_print(Monitor *mon, DeviceState *dev, int indent) } } QLIST_FOREACH(ncl, &dev->clocks, node) { - qdev_printf("clock-%s%s \"%s\" freq_hz=%e\n", + g_autofree char *freq = NULL; + + freq = freq_to_str(clock_get_hz(ncl->clock)); + qdev_printf("clock-%s%s \"%s\" freq_hz=%s\n", ncl->output ? "out" : "in", ncl->alias ? " (alias)" : "", - ncl->name, - CLOCK_PERIOD_TO_HZ(1.0 * clock_get(ncl->clock))); + ncl->name, freq); } class = object_get_class(OBJECT(dev)); do {