From patchwork Tue Nov 15 13:34:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 624835 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2979660pvb; Tue, 15 Nov 2022 05:40:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf41LTSe7c/Tr1c0tx3TzCm7noZJ1eBXn4lez/JinxYnuPZ18mM9Mbp1cFVM3gv2K8DWleUI X-Received: by 2002:ad4:5a41:0:b0:4b1:b4fe:fb2 with SMTP id ej1-20020ad45a41000000b004b1b4fe0fb2mr16829834qvb.70.1668519603456; Tue, 15 Nov 2022 05:40:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668519603; cv=none; d=google.com; s=arc-20160816; b=yE+L8Hp3+7SvnKUxqj1BKfo22QeZRRUmDZoNT/kL/geymT954FgZOzn4UsEex3Iw5v p9AHxI5QtVSykP57P8IY/z3jjIkeDzZqNF6A71Za/KigPlUs/Ws5wmeUhxvrPZanq/0a Q+4xKvmvkqTvakNH6+xTggjp48WsDz9n8aICvPC/HsTU/b32KIatTWR5Va5Eqo8X40ot ay/weQf1MA28P5e933Z9xaf25KUrL7pP6OOMc1kKTHEQDNfb/zTcsmJeSsmtpYrbb9Y+ AfkKp0xKitF2D6vaE4FlTowRRJgKAqCz8IFoKp9oPG4wUZkrqNMDGcASIZpVx5BrDKhy KeiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aRZ/eD6ZaUedeEXWQl7NVWa5eF5sUkL83SXNmlmtL6M=; b=XNNAxVGWSfv94V3Vua2BXOZ3NuSdFvCh6NZLRWM9WuLiCdFkeTOJm6vmhUijG49uS2 RDbgurbZzulGxY6x4jsy+nRBOwx0OM2Vh/ftym+Se7EPQeMuio41Kt+aYEB06RG/WGXd GosNum1NjpGisEgncc/wLSYUhYxROgEorhe9b0hkHOwMouwQxbBYgr2JM3qvOC28CzNn 3XhQObtuvuYW0BONsyvRMtI6bPf0h70AmJsebwHNtcmVPXytiGfwg6CL8pGNyJfs3nh8 xCZbddgRkJu5S5Si5KXwe5LBzxOOeL5JIX9sJor3xNVDyY/etIXdMx0sOOtq4JMLCe5Y npRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rnEokUju; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bt7-20020ac86907000000b003a573ba0b6asi7687912qtb.761.2022.11.15.05.40.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Nov 2022 05:40:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rnEokUju; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6n-0006rX-SF; Tue, 15 Nov 2022 08:36:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5Y-0006JF-0u for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:58 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5W-0004LV-1L for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:55 -0500 Received: by mail-wm1-x32c.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso13122183wme.5 for ; Tue, 15 Nov 2022 05:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aRZ/eD6ZaUedeEXWQl7NVWa5eF5sUkL83SXNmlmtL6M=; b=rnEokUju9x1/kOw2T+ajwmb79WymaOYNfjgU3wpdoW1bf2srEF6jqXxE1cJ3gjduas 55iBpdr01tqskVYjSeTk0ZuPCkq1GGlDuPqktegNe0yu8ggC//Crzzx54XPaRCbXIDdn julCoznnbK007JwVUzwj/UsuVYVcAWe7kY6DKBOKUekV5QAKvzQC6hODg6s5hW1V6IKi Z6EAB/3Xkvx3sQ3YWvdNP3/f01vN49xRfUJ/tWGbJTn1541KbFFrBNJdKmPZ9SNFrDIT ANf94hcdnZqIFmCrwX2+hq4WkuktrXa16cYIlm+bqSBxQyTiQMjJBwruZ4S8xtbOCWRP 6Ejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aRZ/eD6ZaUedeEXWQl7NVWa5eF5sUkL83SXNmlmtL6M=; b=rRzprAJy7pRZCIZrEoVhaGefsaA9G92epitcInua2JUO5I5YMfYEt7WRQmEFmEg0TU PoYlods14yLXAB+a1uvG+rwwVfCAqvJIBNJb/OGxRzntEIPXeVfiFk3u5bF+xfERiAMY +5P9JAu3ZaJn0oS2AB9+U6R0f00J9kKfaxMxgtFCEwBJ1FgbK28XLCfr51Cwi/DGa6yB HCPp1t4Yskd5F7aqmni8OVB7insTvEZ0MQyAdP51Gh3BQhgpj6YxeOjxymSGEPY/9gzz Fteb58oIDCUPoXt+hrle0hejhNetf2MGGhMM66W4jD3a6nt1s1gEVwxrpHNaUjTCgzRe eEYQ== X-Gm-Message-State: ANoB5pn9NzLJZHSGww2j+pEWZr6JnSQxgdAFzy6ESdn43m68rnTrJlAB hSbewF0Golfil9o4vshYQQ7gWg== X-Received: by 2002:a1c:f204:0:b0:3cf:6fe0:b16a with SMTP id s4-20020a1cf204000000b003cf6fe0b16amr514899wmc.28.1668519291557; Tue, 15 Nov 2022 05:34:51 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id fc18-20020a05600c525200b003b49bd61b19sm23605563wmb.15.2022.11.15.05.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 119911FFC0; Tue, 15 Nov 2022 13:34:40 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Markus Armbruster , Paolo Bonzini Subject: [PULL 08/10] docs/devel: try and improve the language around patch review Date: Tue, 15 Nov 2022 13:34:37 +0000 Message-Id: <20221115133439.2348929-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org It is important that contributors take the review process seriously and we collaborate in a respectful way while avoiding personal attacks. Try and make this clear in the language. Signed-off-by: Alex Bennée Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-9-alex.bennee@linaro.org> diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 1f2bde0625..80e8693bb6 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner approach, or even just point out code style issues or commit message typos. You'll need to respond to these, and then send a second version of your patches with the issues fixed. This takes a little time and effort on your part, but -if you don't do it then your changes will never get into QEMU. It's also -just polite -- it is quite disheartening for a developer to spend time -reviewing your code and suggesting improvements, only to find that -you're not going to do anything further and it was all wasted effort. +if you don't do it then your changes will never get into QEMU. + +Remember that a maintainer is under no obligation to take your +patches. If someone has spent the time reviewing your code and +suggesting improvements and you simply re-post without either +addressing the comment directly or providing additional justification +for the change then it becomes wasted effort. You cannot demand others +merge and then fix up your code after the fact. When replying to comments on your patches **reply to all and not just the sender** -- keeping discussion on the mailing list means everybody -can follow it. +can follow it. Remember the spirit of the :ref:`code_of_conduct` and +keep discussions respectful and collaborative and avoid making +personal comments. .. _pay_attention_to_review_comments: