diff mbox series

[v1,07/10] includes: add new gdbstub include directory

Message ID 20221216112206.3171578-8-alex.bennee@linaro.org
State New
Headers show
Series split user and system code in gdbstub | expand

Commit Message

Alex Bennée Dec. 16, 2022, 11:22 a.m. UTC 
To avoid having a messy set of include files containing system and
user APIs lets prepare for a cleaner layout.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 include/gdbstub/common.h | 14 ++++++++++++++
 include/gdbstub/user.h   | 14 ++++++++++++++
 MAINTAINERS              |  1 +
 3 files changed, 29 insertions(+)
 create mode 100644 include/gdbstub/common.h
 create mode 100644 include/gdbstub/user.h

Comments

Richard Henderson Dec. 16, 2022, 8:37 p.m. UTC | #1 
On 12/16/22 03:22, Alex Bennée wrote:
> To avoid having a messy set of include files containing system and
> user APIs lets prepare for a cleaner layout.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   include/gdbstub/common.h | 14 ++++++++++++++
>   include/gdbstub/user.h   | 14 ++++++++++++++
>   MAINTAINERS              |  1 +
>   3 files changed, 29 insertions(+)
>   create mode 100644 include/gdbstub/common.h
>   create mode 100644 include/gdbstub/user.h
> 
> diff --git a/include/gdbstub/common.h b/include/gdbstub/common.h
> new file mode 100644
> index 0000000000..f928dbc487
> --- /dev/null
> +++ b/include/gdbstub/common.h
> @@ -0,0 +1,14 @@
> +/*
> + * gdbstub common APIs
> + *
> + * Copyright (c) 2022 Linaro Ltd
> + *
> + * SPDX-License-Identifier: LGPL-2.0+
> + */
> +
> +#ifndef GDBSTUB_COMMON_H
> +#define GDBSTUB_COMMON_H
> +
> +
> +
> +#endif /* GDBSTUB_COMMON_H */

I don't see any point in creating these headers separately from the patch that populates them.

Not keen on the name "common".  From the later patch, I think it may be at least 3 
separate headers: gdb syscalls, start/stop, xml.


r~
diff mbox series

Patch

diff --git a/include/gdbstub/common.h b/include/gdbstub/common.h
new file mode 100644
index 0000000000..f928dbc487
--- /dev/null
+++ b/include/gdbstub/common.h
@@ -0,0 +1,14 @@ 
+/*
+ * gdbstub common APIs
+ *
+ * Copyright (c) 2022 Linaro Ltd
+ *
+ * SPDX-License-Identifier: LGPL-2.0+
+ */
+
+#ifndef GDBSTUB_COMMON_H
+#define GDBSTUB_COMMON_H
+
+
+
+#endif /* GDBSTUB_COMMON_H */
diff --git a/include/gdbstub/user.h b/include/gdbstub/user.h
new file mode 100644
index 0000000000..53baba65ff
--- /dev/null
+++ b/include/gdbstub/user.h
@@ -0,0 +1,14 @@ 
+/*
+ * gdbstub user-mode only APIs
+ *
+ * Copyright (c) 2022 Linaro Ltd
+ *
+ * SPDX-License-Identifier: LGPL-2.0+
+ */
+
+#ifndef GDBSTUB_USER_H
+#define GDBSTUB_USER_H
+
+
+
+#endif /* GDBSTUB_USER_H */
diff --git a/MAINTAINERS b/MAINTAINERS
index 6966490c94..c84d9299c3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2698,6 +2698,7 @@  R: Philippe Mathieu-Daudé <philmd@linaro.org>
 S: Maintained
 F: gdbstub/*
 F: include/exec/gdbstub.h
+F: include/gdbstub/*
 F: gdb-xml/
 F: tests/tcg/multiarch/gdbstub/
 F: scripts/feature_to_c.sh