From patchwork Wed Mar 1 15:15:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 657804 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp3543816wrb; Wed, 1 Mar 2023 07:17:25 -0800 (PST) X-Google-Smtp-Source: AK7set8/wOm8RnwiGtXS9tFAQfBjeYkhLiGA3MnamGgacEm72D/6bvU9fLatt1RT60XOWzCCMq1v X-Received: by 2002:a05:6214:f29:b0:56e:ac97:85da with SMTP id iw9-20020a0562140f2900b0056eac9785damr13539164qvb.30.1677683844832; Wed, 01 Mar 2023 07:17:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677683844; cv=none; d=google.com; s=arc-20160816; b=mKmW8tbERJuFuQcSew1BgyKnaDMEeq6hrwt5AQyZB01p3O+MFmsgh8uI6YXilpVTmA YuzPrbgF7GcRvwZ4F999huPjFjqCBxAHv6m6urbSNNq9+jOheqJy5tEpyBjQednzX7eV Z314KDSXg7bzIMelHe4ApbSWyvG1lWEYtB1iFlanfZsjUu7s89mAcUgbuN1dfCSm10KE ID7DR6oUdUwLzhny6XjN9O0eAcnNmbvGUtH9yieLvAKeRw15WNjY9j4+nXq5gbRGM8s3 vrx9oA6S9yNr2JM7zUkblLhGPmbN3cG40BefT9kPjQOtRHfE+YJ0Kw3p3dwIbM9mvfMD Swhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Je6tHmMsXrx/D8pW2bDpgfBjKMVcTzo9CyJE47d842I=; b=WkAOPDNL12f9RuQbfR0n5HhfylAkdLMtUXP17IW86TYqhS1Wc2Wu+NOVGIIP6AXB7M uEHXcc4MHaW2JWwUphZvD1yotIKW589osnyFSPuPWaq1UlTT2won7xL6OCw5CxOOVOcR qsISSJfEpTSE8If5RAhTYuxy1VGrdaNP5K98vWFGMfE9K+p01sAk0DleE4ugtVe9p3Ck 7rfh558Gb3Fyqf+pQ18ne7lxA0WB4SLJhJKqTTK2sSz/Qzd5RYxEX5yCcAkQRHrMjp5q enSsRi/8lfJyeIlvGPuhneKwyLojtCYsxzej/OGeni32LBSRPN1E31PMDIIw0hCCF/GX LErA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a40aRi47; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t6-20020a0cde06000000b004ad5edaeeb5si10487120qvk.357.2023.03.01.07.17.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Mar 2023 07:17:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a40aRi47; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXOCG-0000Ew-Lw; Wed, 01 Mar 2023 10:16:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOBk-0008B6-5J for qemu-devel@nongnu.org; Wed, 01 Mar 2023 10:16:16 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXOBh-0007cj-BE for qemu-devel@nongnu.org; Wed, 01 Mar 2023 10:16:15 -0500 Received: by mail-wm1-x32d.google.com with SMTP id k37so8847651wms.0 for ; Wed, 01 Mar 2023 07:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Je6tHmMsXrx/D8pW2bDpgfBjKMVcTzo9CyJE47d842I=; b=a40aRi47JeD+hkOWZHV4njEIrarvuldyqEyTgCl4bfRu7Nbm522jqAESZfC+mGzgJo 4bq6msVaHEs7ROuSLlSP/Vwxq9yS4WK2Y4aGj9D9DCJLmrcUbKBYbkOXBpYU98sAY7Vf ijXEYPzts/aNPndlyBfJTB0JUNjZKzFiT1BQsqZ7hl7tTp5mXLxQNg4X9Esp1UDIYOPI aYObWG+wBSdfOmE41Fp5idOELzXQ/wsMOAdMAmJSnrS4JpBiAvyYVCGUXvjIpvY6aCIX gi+qfO4oQKRzY77lcUvT+4CiCc0aJ3geQjVIP9/o3GadKoG+/LcYIKKJVJ4nz38weAYO Qg/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Je6tHmMsXrx/D8pW2bDpgfBjKMVcTzo9CyJE47d842I=; b=CBOM35BMv45AOkl9Jl3cmT0zG6yanJ9aw9Rcfz+sOI0tKQ34r3aY9yjfQ5Um/lFl5R uY6yvyYRIGuTK4/h3BavhI1SfBX2kNJYfbbi0xSdNfkjlepZXohujkm5Po5BQxh9pgUb q10VRnMwggCbsSXPGgZWR6fqyymxZepcszMgrLnTwCoaND+unSQFD/C+buMh0svFEnEM AuG1CgjA9cTvDCIL5eP7z7cwEFFByZbj3NZdwFchDoD7epvbJ7eqAC7f1YEEEzXJxmIH 9/GT62id7gl6T8felXBH/VRSnV9qI5pQ7Vx9/F1w+u+jel8khwa/HWfbGpKV9IlwcX3h XzYQ== X-Gm-Message-State: AO0yUKXIs2U4Iys3iZ0J6QwGthHY9QMCA3CmpHQ9SNwoUAFX23hrrryx TQLd/RFg6bzdQ0reXILb5fkfLw== X-Received: by 2002:a05:600c:444f:b0:3eb:1ba8:7cfc with SMTP id v15-20020a05600c444f00b003eb1ba87cfcmr5518288wmn.30.1677683771732; Wed, 01 Mar 2023 07:16:11 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id o25-20020a05600c511900b003dfe549da4fsm21962851wms.18.2023.03.01.07.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 07:16:07 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6819A1FFBF; Wed, 1 Mar 2023 15:16:05 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PULL v2 07/24] tests: don't run benchmarks for the tsan build Date: Wed, 1 Mar 2023 15:15:47 +0000 Message-Id: <20230301151604.1948813-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230301151604.1948813-1-alex.bennee@linaro.org> References: <20230301151604.1948813-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org All we are really doing here is checking that TSAN builds compile and are therefor a tool available to developers. The benchmarks are not representative of QEMU's actual threading behaviour and they burn precious CI time. Indeed switching to check-unit reveals many unaddressed issues which have been logged at: https://gitlab.com/qemu-project/qemu/-/issues/1496 So for now disable the make check and make this a build only test. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20230228190653.1602033-8-alex.bennee@linaro.org> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index d903c42798..7b92767689 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -463,7 +463,6 @@ tsan-build: CONFIGURE_ARGS: --enable-tsan --cc=clang-10 --cxx=clang++-10 --enable-trace-backends=ust --disable-slirp TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user - MAKE_CHECK_ARGS: bench V=1 # gcov is a GCC features gcov: