From patchwork Mon Mar 20 10:10:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 665190 Delivered-To: patch@linaro.org Received: by 2002:a5d:5602:0:0:0:0:0 with SMTP id l2csp1037135wrv; Mon, 20 Mar 2023 03:12:51 -0700 (PDT) X-Google-Smtp-Source: AK7set+QUk6QRMkSfMrJhaztKKmoEJRZbGpFfmS73tEcSalKifebyr8KBjYKbqXJZ2H6gMhxR3XG X-Received: by 2002:a05:6214:258e:b0:5ad:13a6:b45b with SMTP id fq14-20020a056214258e00b005ad13a6b45bmr32846613qvb.11.1679307171329; Mon, 20 Mar 2023 03:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679307171; cv=none; d=google.com; s=arc-20160816; b=K8cae9ibi+/N+S7+ks6svEptsElbuPjOxscpaAPREwUHlpFDRyBpNlTbyj1JdVjvhv iD4cy7l1vZrXbtUqS+7yU+n7qY4knJmV9334lDsB5wRatX8TVMO4jSxQ0H3nX5qXqCi6 Ncv2EaA9hUvMb9+cuRu+zrVd3yS1SYkiJglYAENEfEHl1eVVQb8xhqoPEeJ2Vw2xNvIo 1leIYq1u57LkO/x27vYZZ5usUTARHa/9k0Qdy2RDuaZqzMaA+3TCJDVDi0efSnZUWeCA qE7PTf3v9nkbRn5c1sOMyaSLRC5nICGnw8GdHI9Bat4l5d9H3rLxjjBPkmom53Vs4Q9n dH4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LUMw8RA1BNOCtad0CWVcs2eZdBZ6IcdOa6VvbiYXoBQ=; b=JtxDGh6SOqWf8bYN0CiV4kA5gqfUWanldj9tDSWy8C9jb5/8qMCtVIYHRsgkKiYUCp PnY0r+pFqfUo48L7YZc3RON/uQJLWCQ6YFEJKXpzFr2Ti32mSkPi5OyseqvhhNXFTRuS lp4Cxt3Io5HgWBILlZECbBtDQn8cEMrxz7JD/y5i51PSCNRZhl/rwkZPyPjLKwy+tRiX BxG6Kns12lTE5xZ7Sk1HjcLgNhhqmUjPPzrH0QR8KhOpPOU0XLTzMZb7tNK51S6IfLyo 0wuXD9bEDUsp/wZ5OsELUZiPUBRv0spsA+PiqDcMrPyT9UidvC52RJE2D8eFYOVmoChz Opzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cWh0kIiq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j18-20020a0cf9d2000000b0056f0822fd3esi5294517qvo.224.2023.03.20.03.12.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Mar 2023 03:12:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cWh0kIiq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peCTd-0003nN-8Q; Mon, 20 Mar 2023 06:10:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peCTT-0003kx-9i for qemu-devel@nongnu.org; Mon, 20 Mar 2023 06:10:44 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peCTP-0000CT-OG for qemu-devel@nongnu.org; Mon, 20 Mar 2023 06:10:41 -0400 Received: by mail-wm1-x330.google.com with SMTP id o40-20020a05600c512800b003eddedc47aeso1706028wms.3 for ; Mon, 20 Mar 2023 03:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679307038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LUMw8RA1BNOCtad0CWVcs2eZdBZ6IcdOa6VvbiYXoBQ=; b=cWh0kIiq7/X1M52vBzGqfQwvnc/3V/91/jXSLKShOjVzIerO7SzbtSqFpVXpu2SVoL v5pbE4qEK9ithzYge01DZI0S/5DYbcdoQ14v8eTjj7sA4uB8dBARfbsleYZnrOOHlAXQ bJHzy6UrfHjfBBWzlqlB8H5epdAASKLZj93BZFNCjgAGSdHgtH/+pGDMqoQT8mU73v2w lo2IBy2Fef3WESNIO96NPQ8nsFEeSuuUfIruhHlmYgh5myoMpEVcpebvgPjH6C5/gUSD aGM6Y714CUiTOOXIdI/JKMA9WPKk6yHVpcy5QJJRsbhlvNuB3l0BSUwfc4bSjiKjhOy5 cz/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679307038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LUMw8RA1BNOCtad0CWVcs2eZdBZ6IcdOa6VvbiYXoBQ=; b=RNlNbx+glxDZbAukkU+FiVp86kgdeOysDBNdrSi/N041npUqU7UXtCOG52kJ9Yf6CK ZdfiSOosrhNCDLc4+J3zG2mLiFEVUSOkqcy1UbY0ql4XMNJlVlDAjLHNicxR1yzaVY6A kVG69uEIxLvZRq0xm2JJm5ELxUldgn4O7k3OiAkreSbhDh8yOYVH/4Qbu2roT+leTN8T ypv01resh3MSvAtIu1NpU9m9J1m5wLBhrN4m85xh95qUSBzEIT8g6OPwfVM8CnBE2iEo xzeeR0spSZofNT5cgDUCFW5Edoj+7vJ/3Ek89688EIKEaWGJbUVrLdsvXhACN9ilL2CY LK8Q== X-Gm-Message-State: AO0yUKWVOJZoOmvjRKbKEk4imCnFLdHoowCncmMNN7WE5pWSWqpebPLt OrOtAyhbpZShk8rFrcC7S012Vg== X-Received: by 2002:a05:600c:3b8e:b0:3ed:290b:dc68 with SMTP id n14-20020a05600c3b8e00b003ed290bdc68mr23772731wms.12.1679307038198; Mon, 20 Mar 2023 03:10:38 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id bg7-20020a05600c3c8700b003eb2e33f327sm27320431wmb.2.2023.03.20.03.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 03:10:36 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4124B1FFBC; Mon, 20 Mar 2023 10:10:36 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: Alessandro Di Federico , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , Eduardo Habkost , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH 04/10] accel/tcg: don't bother with ifdef for CPU_DUMP_CCOP Date: Mon, 20 Mar 2023 10:10:29 +0000 Message-Id: <20230320101035.2214196-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320101035.2214196-1-alex.bennee@linaro.org> References: <20230320101035.2214196-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While only i386 dumps anything useful for the flag it could potentially be used by others. Front ends that don't understand the flag will ignore it anyway. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- accel/tcg/cpu-exec.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 5e5906e199..f883be197f 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -309,14 +309,11 @@ static void log_cpu_exec(target_ulong pc, CPUState *cpu, if (qemu_loglevel_mask(CPU_LOG_TB_CPU)) { FILE *logfile = qemu_log_trylock(); if (logfile) { - int flags = 0; + int flags = CPU_DUMP_CCOP;; if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) { flags |= CPU_DUMP_FPU; } -#if defined(TARGET_I386) - flags |= CPU_DUMP_CCOP; -#endif cpu_dump_state(cpu, logfile, flags); qemu_log_unlock(logfile); }