| Message ID | 20230627160943.2956928-5-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | maintainer omnibus: testing, fuzz, plugins, documentation, gdbstub (pre-PR) | expand |
On 27/6/23 18:09, Alex Bennée wrote: > From: Ani Sinha <anisinha@redhat.com> > > When new dependencies and packages are added to containers, its important to > run CI container generation pipelines on gitlab to make sure that there are no > obvious conflicts between packages that are being added and those that are > already present. Running CI container pipelines will make sure that there are > no such breakages before we commit the change updating the containers. Add a > line in the documentation reminding developers to run the pipeline before > submitting the change. It will also ease the life of the maintainers. > > Signed-off-by: Ani Sinha <anisinha@redhat.com> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > Message-Id: <20230506072012.10350-1-anisinha@redhat.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > docs/devel/testing.rst | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 203facb417..8f18052ba7 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project: `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation page on how to trigger gitlab CI pipelines on your change. + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``.