| Message ID | 20240427155714.53669-11-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | exec: Rework around CPUState user fields | expand |
On 4/27/24 08:57, Philippe Mathieu-Daudé wrote: > System emulation shouldn't use "user/syscall-trace.h". > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/user/syscall-trace.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h > index b48b2b2d0a..6926434d9a 100644 > --- a/include/user/syscall-trace.h > +++ b/include/user/syscall-trace.h > @@ -10,6 +10,10 @@ > #ifndef SYSCALL_TRACE_H > #define SYSCALL_TRACE_H > > +#ifndef CONFIG_USER_ONLY > +#error Cannot include this header from system emulation > +#endif > + > #include "exec/user/abitypes.h" > #include "gdbstub/user.h" > #include "qemu/plugin.h" Are we really going to do this for all include/user/ headers? r~
On 28/4/24 20:32, Richard Henderson wrote: > On 4/27/24 08:57, Philippe Mathieu-Daudé wrote: >> System emulation shouldn't use "user/syscall-trace.h". >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> --- >> include/user/syscall-trace.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h >> index b48b2b2d0a..6926434d9a 100644 >> --- a/include/user/syscall-trace.h >> +++ b/include/user/syscall-trace.h >> @@ -10,6 +10,10 @@ >> #ifndef SYSCALL_TRACE_H >> #define SYSCALL_TRACE_H >> +#ifndef CONFIG_USER_ONLY >> +#error Cannot include this header from system emulation >> +#endif >> + >> #include "exec/user/abitypes.h" >> #include "gdbstub/user.h" >> #include "qemu/plugin.h" > > Are we really going to do this for all include/user/ headers? I'd like to, there are only 2 more files left, user/tswap-target.h and user/thunk.h.
diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h index b48b2b2d0a..6926434d9a 100644 --- a/include/user/syscall-trace.h +++ b/include/user/syscall-trace.h @@ -10,6 +10,10 @@ #ifndef SYSCALL_TRACE_H #define SYSCALL_TRACE_H +#ifndef CONFIG_USER_ONLY +#error Cannot include this header from system emulation +#endif + #include "exec/user/abitypes.h" #include "gdbstub/user.h" #include "qemu/plugin.h"
System emulation shouldn't use "user/syscall-trace.h". Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/user/syscall-trace.h | 4 ++++ 1 file changed, 4 insertions(+)