| Message ID | 20241108162909.4080314-3-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | trace: Minor cleanups to trace header includes | expand |
On 8/11/24 16:29, Peter Maydell wrote: > The documentation for trace events says that every subdirectory which > has trace events should have a trace.h header, whose only content is > an include of the trace/trace-<subdir>.h file. > > When we added the trace events in target/arm/hvf/ we forgot to create > this file and instead hvf.c directly includes > trace/trace-target_arm_hvf.h. > > Create the standard trace.h file to bring this into line with the > convention. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/arm/hvf/trace.h | 1 + > target/arm/hvf/hvf.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > create mode 100644 target/arm/hvf/trace.h Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/target/arm/hvf/trace.h b/target/arm/hvf/trace.h new file mode 100644 index 00000000000..04a19c1d752 --- /dev/null +++ b/target/arm/hvf/trace.h @@ -0,0 +1 @@ +#include "trace/trace-target_arm_hvf.h" diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 6cea483d422..ca7ea92774a 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -31,7 +31,7 @@ #include "target/arm/internals.h" #include "target/arm/multiprocessing.h" #include "target/arm/gtimer.h" -#include "trace/trace-target_arm_hvf.h" +#include "trace.h" #include "migration/vmstate.h" #include "gdbstub/enums.h"
The documentation for trace events says that every subdirectory which has trace events should have a trace.h header, whose only content is an include of the trace/trace-<subdir>.h file. When we added the trace events in target/arm/hvf/ we forgot to create this file and instead hvf.c directly includes trace/trace-target_arm_hvf.h. Create the standard trace.h file to bring this into line with the convention. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/hvf/trace.h | 1 + target/arm/hvf/hvf.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 target/arm/hvf/trace.h