From patchwork Sat Nov 9 10:13:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 842074 Delivered-To: patch@linaro.org Received: by 2002:a5d:6307:0:b0:381:e71e:8f7b with SMTP id i7csp2081902wru; Sat, 9 Nov 2024 02:18:07 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCX+m8BPIcrP7Pfvhflrt800FMscfF93Fsqte6tK5wc5/qaTb2gBkhc5Cz4edFpvQ48jcHku+w==@linaro.org X-Google-Smtp-Source: AGHT+IGUIVXe39Y/dyS8HhI5odOdGIGi1zooGPxMwXkImCEMTDfwnZfAf1O3kW6ANOcfTtS8E/Vx X-Received: by 2002:a05:620a:4686:b0:7b1:5763:4ba2 with SMTP id af79cd13be357-7b331f21c19mr657080685a.40.1731147487126; Sat, 09 Nov 2024 02:18:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731147487; cv=none; d=google.com; s=arc-20240605; b=l1GRKTsILzvPG6PqxF4T4+d694/abT0vjfaKcMNbvSgC+CO/UtZh8lw4InPPD5/7xk ZH6RoL3TABGvYdGdObdGfnhcx0CqdhX2lqiyR7QMCk5199kiPLhDflBejqfW17PW0u/S sIQ+YwSxBF6lUj9VWj44j4L7YKRS0hBXpZ62l7/KOI1n/UnzffY47Zxc/HOnk2CagNbe XPyLCwwfTa+XqEVgetFhRz0tJZ04NIPTAQ8HFzR2SGs4Pp16EC99VEBqb2snT+8FYDh2 P2SvzTh60NRZDRg1D5xYjdmrXY8IuJ5udSf5j6UOpRdxyvrc38qFhIn0EsJADtqjDhtb 7JkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=hTtPJSlftZLk1owsbIWiP20Lw6uJMHavy4TySeEyx1A=; fh=a0EThkoET2zX5h0F1tWE+vzAO6qNrt0J8z9IjVZ9J14=; b=XdY1MZCFEf/CgrMUoT8lnmwy9glo8trAYwSECscZ7nGDXus2gE13ilBll2DQSY0niD zVA37awEoIKTt7vTz5nz/66/t+xuzDac3WCgd+/rX2NCV3xBwi8flitceg2cpveB28+z po9qLT9z/dnF05yTCoj/TkfHq2oZumdywcmnfWToOTLkMTm7RxZqJ+YDmlmiUUf9ZPbF H4GFoaFB4XZFcTTAqj4AFIzPEm9nzgnSuukB+HZzUsFa0iLlvR5jCeN6+4ftKQy3UNI9 qHoI0aNWjp4RCeDQ1p7aYK+RDDXmLwGoUoVmpLoCtAoEQiJdIx50J+LKYzaz9jMVDKg2 knkA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b32ad21db1si615611485a.626.2024.11.09.02.18.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Nov 2024 02:18:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9iUl-0004Bd-Om; Sat, 09 Nov 2024 05:15:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9iUW-0003q1-9j; Sat, 09 Nov 2024 05:14:52 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9iUU-0007WF-NS; Sat, 09 Nov 2024 05:14:52 -0500 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 38AFAA13E6; Sat, 9 Nov 2024 13:13:49 +0300 (MSK) Received: from think4mjt.tls.msk.ru (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id D8D10167ED2; Sat, 9 Nov 2024 13:14:43 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Peter Maydell , Marcin Juszkiewicz , Richard Henderson , Michael Tokarev Subject: [Stable-8.2.8 02/49] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1 Date: Sat, 9 Nov 2024 13:13:53 +0300 Message-Id: <20241109101443.312701-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell The Neoverse-V1 TRM is a bit confused about the layout of the ID_AA64ISAR1_EL1 register, and so its table 3-6 has the wrong value for this ID register. Trust instead section 3.2.74's list of which fields are set. This means that we stop incorrectly reporting FEAT_XS as present, and now report the presence of FEAT_BF16. Cc: qemu-stable@nongnu.org Reported-by: Marcin Juszkiewicz Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20240917161337.3012188-1-peter.maydell@linaro.org (cherry picked from commit 8676007eff04bb4e454bcdf92fab3f855bcc59b3) Signed-off-by: Michael Tokarev diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index fcda99e158..dfc0ebb796 100644 --- a/target/arm/tcg/cpu64.c +++ b/target/arm/tcg/cpu64.c @@ -678,7 +678,7 @@ static void aarch64_neoverse_v1_initfn(Object *obj) cpu->isar.id_aa64dfr0 = 0x000001f210305519ull; cpu->isar.id_aa64dfr1 = 0x00000000; cpu->isar.id_aa64isar0 = 0x1011111110212120ull; /* with FEAT_RNG */ - cpu->isar.id_aa64isar1 = 0x0111000001211032ull; + cpu->isar.id_aa64isar1 = 0x0011100001211032ull; cpu->isar.id_aa64mmfr0 = 0x0000000000101125ull; cpu->isar.id_aa64mmfr1 = 0x0000000010212122ull; cpu->isar.id_aa64mmfr2 = 0x0220011102101011ull;