From patchwork Tue Dec 10 16:17:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 848844 Delivered-To: patch@linaro.org Received: by 2002:adf:ec08:0:b0:385:e875:8a9e with SMTP id x8csp419060wrn; Tue, 10 Dec 2024 08:24:57 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWgZxg/mnM6ZqgqeEGsIPEdYV0hphyBZy546ROyUzeq0cth1hiLxwKKLjClJR2ycVTPQQy9Mw==@linaro.org X-Google-Smtp-Source: AGHT+IGBfSSFUe6NDbezVtl/F8R7LUm0is7Ylw1QYgorwKQV5tB1VtVrSHh8K4OtlpMQVD7eycEx X-Received: by 2002:a05:6102:b0b:b0:4af:f275:e747 with SMTP id ada2fe7eead31-4b1161cd149mr5984690137.22.1733847896818; Tue, 10 Dec 2024 08:24:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733847896; cv=none; d=google.com; s=arc-20240605; b=iNnPYXqeSVZ1KUsJM3RiRPP6uEKkyOoO9rf0phBAz2byPAEUjps0fyjkHAcuE1rVY3 ASPt2dkctoGjQ+THKAt1ir0tBufh1byQ8Y2synj3zQQaSYMFtg2fMkRMmgQOHtJhlilO QpH+SJHUFW/9rDWbWKUVgQIH4ApB0MaEemQrpjsst4eZScb6a81HO9nNUPgDmMxVNDbz T8gtxnFg62IUDflC906ozcaMT7qRk3B9XZm6DNXGM18UMSBuBC/yrK/ltlv7Fjsr5tGT LHkXkKMK9cstGoC+bqRByYlh8WN99q+ANqL889nq8HE0iW87plRgHxt6PD5hSG4J9l8Y D6Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NjJ6yNZWB0Ib9R3vyjGZylRzzND6ZWaBRLDVA9KvYvo=; fh=ZhBia3nL9o1nuf7SbgdYn/0pDmAeja6gisyWXi2cqYE=; b=FzhHHKIZOxsi/Gd7eS8BiUBP5dPh1qSzquvzCTrC00O9BW7PFp7IOEdFdUtz6NQvNv 5N6pmOduSYkoCggCNPe+XqkTuTUMCeaf//FaDFi9Me7UlC92Js2DFcaX9OgJ9CF3mpde eHHYtVr5T/1/gUml6ACNSUyiDaqzhmk3x28kgbr9sMIFpgZntOE60OEboX5kAJYw2Z3c 1WMvbrAky57Ls6LJmAY8XelMy9prQFVjwJr6G1s3N8kF9rUAIcVtqGQQRLB6jFhf9Snx ndY7a6xdqaRaGLQq5iqJYklWF8wx/BqaKUQNW6WUURJX8yFIBocwlM/76Hto9fWFFCyJ JcbQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lWNEBztZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4b11198f77fsi926438137.78.2024.12.10.08.24.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Dec 2024 08:24:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lWNEBztZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tL31b-00060Q-Jd; Tue, 10 Dec 2024 11:23:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tL31O-0004zs-7U for qemu-devel@nongnu.org; Tue, 10 Dec 2024 11:23:39 -0500 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tL31M-0007N1-CV for qemu-devel@nongnu.org; Tue, 10 Dec 2024 11:23:37 -0500 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-3022598e213so20344981fa.0 for ; Tue, 10 Dec 2024 08:23:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733847815; x=1734452615; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NjJ6yNZWB0Ib9R3vyjGZylRzzND6ZWaBRLDVA9KvYvo=; b=lWNEBztZYLCb64kyI/v+XzOtegyvsbRJLza3YPV0hCZfA7ATrjPO+3+EWrSzutgJET tTAwPX6RI3RJCR/kTYhuy90FjchU66iGyndfR6uwgDS2/DZiQaeiILDZ4s8OU3FpMQub oRA6//5sqjSOCbx+Gm1IFWfUINAtnCp+yM9UxVK6fv0OH/cn5G+J+N08BnJboJAgb4dr 9g3Y7uQHwI9TR5aoNcX0ywbgH+6z6HHBWO4me5S5ug31+PFJhzBe7sEqkI3fGzOR4gkg s6gNlMyTKoOOy/momY2PJFNqt22v9MbAH/nsR2+4dr/9ogZ1a+DuDV7xRb/J5U/TzOKS r7Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733847815; x=1734452615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NjJ6yNZWB0Ib9R3vyjGZylRzzND6ZWaBRLDVA9KvYvo=; b=Q67TquWuw0VJMOfLd++g1qekrX7CRGF4OHuxMoI0cbnCOE47UZPgZGqjmYYjJqfG5b SnjslTPOJ2eTf4D0H2+k1CSObx8NeNuxgFXSirLoYcbUbXAlh8r/SaTn37EsAi2sTObD qHJdy9aAlOk10UitvBu717iW/D4ZrMje7tGkWcHMmN6YhSytFRzveBPn/GFTwpXxRyH8 XntgWkm8eN9MwgPmMR+OckYhm3JbiRv5BLS2vdEdFVH8iy93qOc0EkJaHOjcAB8zF1lk 6Aw1Z/ouvhQCKMgEx0RgBlD9ztlCn1Yz7tSsj0mkZ1xVagwjJGqLh+9D1xXTYJ9QyO56 5ZpQ== X-Gm-Message-State: AOJu0YwUJweDDHUFxl59U6wcavRm19cg+dwLplo3sfaFahpttu0uB3az EL8HY+R01tGpXUHKxkf3uaqFt2hqXPXi8mWM3J9H0GvkzZIhZjfBjWJYWD5NpIHMjqSXUDGQnmS BpdIKlExP X-Gm-Gg: ASbGnctPAnPCyxEjAaDUMaXlrIsy7yOug6mzFVpSnCZA9FHFcX1g2nh8aj576gyHCUs n80Y+D+QjImiX9SciFt5jRxfxzkXXnYUBEEHM1PEKIlH5fNYvC17wO/62g4E3rYIDzDVHBnziOw T8p5rkOiy1iJTNBc3WqcURjrDVUQG80G1peSz69ylKUpKJJ+5orpCvBefjRj+vUPtYgN+Wl0Z5n JuZqLK78XIg2nOuHvZuDUp1ljB/xJtKFXLaASzT7q/imGAtRdPyvtjL1o4= X-Received: by 2002:a05:6512:4022:b0:53d:ed4e:e5af with SMTP id 2adb3069b0e04-540240d3308mr1820561e87.33.1733847814694; Tue, 10 Dec 2024 08:23:34 -0800 (PST) Received: from stoup.. ([91.209.212.80]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5402960b0absm26024e87.102.2024.12.10.08.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 08:23:33 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell Subject: [PATCH v2 42/69] target/arm: Introduce gen_gvec_rev{16,32,64} Date: Tue, 10 Dec 2024 10:17:06 -0600 Message-ID: <20241210161733.1830573-43-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241210161733.1830573-1-richard.henderson@linaro.org> References: <20241210161733.1830573-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=richard.henderson@linaro.org; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/tcg/translate.h | 6 +++ target/arm/tcg/gengvec.c | 58 ++++++++++++++++++++++ target/arm/tcg/translate-neon.c | 88 +++++++-------------------------- 3 files changed, 81 insertions(+), 71 deletions(-) diff --git a/target/arm/tcg/translate.h b/target/arm/tcg/translate.h index cb8e1b2586..342ebedafc 100644 --- a/target/arm/tcg/translate.h +++ b/target/arm/tcg/translate.h @@ -586,6 +586,12 @@ void gen_gvec_cnt(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, uint32_t opr_sz, uint32_t max_sz); void gen_gvec_rbit(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, uint32_t opr_sz, uint32_t max_sz); +void gen_gvec_rev16(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, + uint32_t opr_sz, uint32_t max_sz); +void gen_gvec_rev32(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, + uint32_t opr_sz, uint32_t max_sz); +void gen_gvec_rev64(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, + uint32_t opr_sz, uint32_t max_sz); /* * Forward to the isar_feature_* tests given a DisasContext pointer. diff --git a/target/arm/tcg/gengvec.c b/target/arm/tcg/gengvec.c index 85a0b50496..33c0a94958 100644 --- a/target/arm/tcg/gengvec.c +++ b/target/arm/tcg/gengvec.c @@ -2409,3 +2409,61 @@ void gen_gvec_rbit(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, tcg_gen_gvec_2_ool(rd_ofs, rn_ofs, opr_sz, max_sz, 0, gen_helper_gvec_rbit_b); } + +void gen_gvec_rev16(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, + uint32_t opr_sz, uint32_t max_sz) +{ + assert(vece == MO_8); + tcg_gen_gvec_rotli(MO_16, rd_ofs, rn_ofs, 8, opr_sz, max_sz); +} + +static void gen_bswap32_i64(TCGv_i64 d, TCGv_i64 n) +{ + tcg_gen_bswap64_i64(d, n); + tcg_gen_rotli_i64(d, d, 32); +} + +void gen_gvec_rev32(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, + uint32_t opr_sz, uint32_t max_sz) +{ + static const GVecGen2 g = { + .fni8 = gen_bswap32_i64, + .fni4 = tcg_gen_bswap32_i32, + .prefer_i64 = TCG_TARGET_REG_BITS == 64, + .vece = MO_32 + }; + + switch (vece) { + case MO_16: + tcg_gen_gvec_rotli(MO_32, rd_ofs, rn_ofs, 16, opr_sz, max_sz); + break; + case MO_8: + tcg_gen_gvec_2(rd_ofs, rn_ofs, opr_sz, max_sz, &g); + break; + default: + g_assert_not_reached(); + } +} + +void gen_gvec_rev64(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, + uint32_t opr_sz, uint32_t max_sz) +{ + static const GVecGen2 g[] = { + { .fni8 = tcg_gen_bswap64_i64, + .vece = MO_64 }, + { .fni8 = tcg_gen_hswap_i64, + .vece = MO_64 }, + }; + + switch (vece) { + case MO_32: + tcg_gen_gvec_rotli(MO_64, rd_ofs, rn_ofs, 32, opr_sz, max_sz); + break; + case MO_8: + case MO_16: + tcg_gen_gvec_2(rd_ofs, rn_ofs, opr_sz, max_sz, &g[vece]); + break; + default: + g_assert_not_reached(); + } +} diff --git a/target/arm/tcg/translate-neon.c b/target/arm/tcg/translate-neon.c index 50d0bf7753..ca6f5578b4 100644 --- a/target/arm/tcg/translate-neon.c +++ b/target/arm/tcg/translate-neon.c @@ -2565,58 +2565,6 @@ static bool trans_VDUP_scalar(DisasContext *s, arg_VDUP_scalar *a) return true; } -static bool trans_VREV64(DisasContext *s, arg_VREV64 *a) -{ - int pass, half; - TCGv_i32 tmp[2]; - - if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { - return false; - } - - /* UNDEF accesses to D16-D31 if they don't exist. */ - if (!dc_isar_feature(aa32_simd_r32, s) && - ((a->vd | a->vm) & 0x10)) { - return false; - } - - if ((a->vd | a->vm) & a->q) { - return false; - } - - if (a->size == 3) { - return false; - } - - if (!vfp_access_check(s)) { - return true; - } - - tmp[0] = tcg_temp_new_i32(); - tmp[1] = tcg_temp_new_i32(); - - for (pass = 0; pass < (a->q ? 2 : 1); pass++) { - for (half = 0; half < 2; half++) { - read_neon_element32(tmp[half], a->vm, pass * 2 + half, MO_32); - switch (a->size) { - case 0: - tcg_gen_bswap32_i32(tmp[half], tmp[half]); - break; - case 1: - gen_swap_half(tmp[half], tmp[half]); - break; - case 2: - break; - default: - g_assert_not_reached(); - } - } - write_neon_element32(tmp[1], a->vd, pass * 2, MO_32); - write_neon_element32(tmp[0], a->vd, pass * 2 + 1, MO_32); - } - return true; -} - static bool do_2misc_pairwise(DisasContext *s, arg_2misc *a, NeonGenWidenFn *widenfn, NeonGenTwo64OpFn *opfn, @@ -3122,6 +3070,7 @@ DO_2MISC_VEC(VCGE0, gen_gvec_cge0) DO_2MISC_VEC(VCLT0, gen_gvec_clt0) DO_2MISC_VEC(VCLS, gen_gvec_cls) DO_2MISC_VEC(VCLZ, gen_gvec_clz) +DO_2MISC_VEC(VREV64, gen_gvec_rev64) static bool trans_VMVN(DisasContext *s, arg_2misc *a) { @@ -3139,6 +3088,22 @@ static bool trans_VCNT(DisasContext *s, arg_2misc *a) return do_2misc_vec(s, a, gen_gvec_cnt); } +static bool trans_VREV16(DisasContext *s, arg_2misc *a) +{ + if (a->size != 0) { + return false; + } + return do_2misc_vec(s, a, gen_gvec_rev16); +} + +static bool trans_VREV32(DisasContext *s, arg_2misc *a) +{ + if (a->size != 0 && a->size != 1) { + return false; + } + return do_2misc_vec(s, a, gen_gvec_rev32); +} + #define WRAP_2M_3_OOL_FN(WRAPNAME, FUNC, DATA) \ static void WRAPNAME(unsigned vece, uint32_t rd_ofs, \ uint32_t rm_ofs, uint32_t oprsz, \ @@ -3218,25 +3183,6 @@ static bool do_2misc(DisasContext *s, arg_2misc *a, NeonGenOneOpFn *fn) return true; } -static bool trans_VREV32(DisasContext *s, arg_2misc *a) -{ - static NeonGenOneOpFn * const fn[] = { - tcg_gen_bswap32_i32, - gen_swap_half, - NULL, - NULL, - }; - return do_2misc(s, a, fn[a->size]); -} - -static bool trans_VREV16(DisasContext *s, arg_2misc *a) -{ - if (a->size != 0) { - return false; - } - return do_2misc(s, a, gen_rev16); -} - static void gen_VABS_F(unsigned vece, uint32_t rd_ofs, uint32_t rm_ofs, uint32_t oprsz, uint32_t maxsz) {