From patchwork Wed Dec 11 23:03:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 849301 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:2c4:b0:385:e875:8a9e with SMTP id o4csp610459wry; Wed, 11 Dec 2024 15:05:35 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWxqOREvPZdPNHmTp5B/nv2v8TiMaI6XVn9d6xTS77MEJJoyEV+YprEm427wY0/0ExYvIXu1A==@linaro.org X-Google-Smtp-Source: AGHT+IH5cwclnKSA3dZaCJuC68E3W25RV4qkXO8+Ism+tSwvW+74Pa4zA+Guy39HIYJAtvF7l+bn X-Received: by 2002:a05:620a:1a85:b0:7b6:e20c:1a0e with SMTP id af79cd13be357-7b6f25a7906mr142494685a.51.1733958335488; Wed, 11 Dec 2024 15:05:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733958335; cv=none; d=google.com; s=arc-20240605; b=CBxpBfg667WkVJ+j62t6G39IcG48MUs3WyKZQxD/IyOyTO3dXHdZ5foeqRW1Lly67L eSclSi5rIOeL36hnHEgEHN1YPUXmNjELQiiXxA/tOlhkJLcNS3+F1y/SxRkFho++iQvA bBqk7DIaqr2KoRlEBAT87NByH7a/0sl7Yn+GEC4CO7/uyVaAAQZ5eDVxOARZYW3WUkEp pf1VEtMsflDnzNJIUHiwp/cjvcVqsWBZa80NFGXaeaE4Dc3tMrxini/M2xhgmdEN6HjO rr1l44aP7edQGFKEBcdeQ88ZhgNC+gATp8yxcUfC1uI/yHIGlIl6llEMNFQS1kDpBvDf 8H8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e1gkSU7M75EFdbW95JvRzZevk5diVkYdExWvAc1of60=; fh=OjCkG1+zFAHgM8ka22zpdQBeTIhfVPLMh2IbVRbLBUc=; b=R+KeIUxzCIBjz7/EcZZVNmQ0OJHJ8FAaZWZDG1b9zzZ7K3GT1B6iD5qxp+hRtMk4eO 2kwUJ38mNoav8/UBMwf3+raljWFFNOyZf3s8s2Zd5oPI0VISwLz1EfflbhpXZPw+05u2 mJWMGx4keUf5ST1MPGXgBPN3EfGxctzpSoOeBqrNHy8ZUmYPaQEZXs2i0+0W+7ta3Tu+ tjWqf/YXUKcELNWqUsmV9JxPa1ahuz3GSgwDY87XN8M34vy7cs8KkUL/cOJHGY4on82b tub55L5NbHA1a0vIP7ep6yPROHQ+pmbq2LxglvCPk0OJ4bNjiIvH6F4yzN97IVlSV9Gt iuZg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="R/eBWH5z"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b6e97598b7si398011985a.65.2024.12.11.15.05.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Dec 2024 15:05:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="R/eBWH5z"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLVku-00035A-E9; Wed, 11 Dec 2024 18:04:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLVkr-00031V-UN for qemu-devel@nongnu.org; Wed, 11 Dec 2024 18:04:29 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLVkp-00023S-FN for qemu-devel@nongnu.org; Wed, 11 Dec 2024 18:04:29 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-436202dd7f6so9679795e9.0 for ; Wed, 11 Dec 2024 15:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733958266; x=1734563066; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e1gkSU7M75EFdbW95JvRzZevk5diVkYdExWvAc1of60=; b=R/eBWH5z2dx6cjzsEN6u3+idu3vFuwzErwO8oX11xXUX49xg7u3+co4bLtb8Lwtojd 5NHmmaixLvtSXFqWCc2Jgbd40xh+tbLlPsc251PbFJ9YmL8Q2NXnPExaZcudXcqXOu/j 3HOJ5ZQeVfiblEkwyYcKRDfEEduHeHlE9GFVeQ4VeMTyHH/XoCh8GIx3eDq4QLBAcagv zAxyQs58tKFEF1Zf1vJ+6Z6uU9+1pMMeT9e3DP0+KHzEiflCuXTUtTyO4dDnkAnGt8Wi jTd6vixOeaHcpuPvX0SG2FSGxAGhAa4Anwj4I9VDP4et61vZCi0Emut8HYBzWO7qlTzY 0syw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733958266; x=1734563066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e1gkSU7M75EFdbW95JvRzZevk5diVkYdExWvAc1of60=; b=AUk8Kp3o+2R71Cu7UkZoaL0MvrffSlmQi2LUSkpaksoRUwhzWdFDPnDM1lTcoUbvaZ JdJ8vLcE6Ej5mxarcscZUiGGFGA7DmdUGANcVRcu3PHuULR1sYVjSo0JcHOVBoH78OLx lgTDvnXw0W2gFUrM+HWvfF5LOnnN7vlImzaIg9zEgXyHiXyFyoAkDYVCIeyxjSPLVD+p pwHFvUNdt1Ogceq7ZogS2fAHKuUH/waV9VAsvLjstAZ9AQGep53wjOSQVuok0d44VrR0 Afj35d3naaSJPGyCQovLJJjMYDvcbdn+ww01ajpJpcIlVV4hyxr4K50h6fUEBWkqV6yF e+Cw== X-Gm-Message-State: AOJu0YzfpOGomkAkuLdgtCDh67FQKQFGRuXmvg9ESaMSgSjq9OJZZblT 7GL83uJtes+fk4QSoJ2A2yNWxDOCofMvXQTR5iU11ayt/DctMz7/v/VGEG8nIq8ybBgnJeffODN n X-Gm-Gg: ASbGnctPFhUcdsXqrpiOgk3tuuP1D5m/UkamQE/J4bs/xB15SuPvrE5aVfz81na+rOF PLaTpiu4LcXZoVUexBuMxXeRmnMbljH+2Wx6TYbZQpcQOsppUFC1jF4A4hIpHrQU4ecyZsCyOtT NKxZ0EQey7QaGhqSqUYtvzPttDmn7hJT+N1uIqByr0yemd3BA4X/+o8h9kQsHrueJlb0mhZ986v RK5UFtGjKZLgk7IS5+0Vot7GHpOAhia49L0OZuCB4lRcTXzJLMqwTJy6/BIJq/3zG06qtPL3pMk iQVqQvtRH4bNty1OjZh8V6C9cDHuRAaItA== X-Received: by 2002:a05:600c:46c6:b0:434:f9c4:a850 with SMTP id 5b1f17b1804b1-43622833224mr13851425e9.10.1733958265695; Wed, 11 Dec 2024 15:04:25 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434f981880csm117938685e9.44.2024.12.11.15.04.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 11 Dec 2024 15:04:24 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 5/9] hw/ppc: Include missing 'exec/tswap.h' header Date: Thu, 12 Dec 2024 00:03:53 +0100 Message-ID: <20241211230357.97036-6-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211230357.97036-1-philmd@linaro.org> References: <20241211230357.97036-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Some files indirectly get "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: hw/ppc/virtex_ml507.c:123:19: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 123 | env->gpr[6] = tswap32(EPAPR_MAGIC); | ^ hw/ppc/sam460ex.c:238:23: error: call to undeclared function 'tswap32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 238 | env->gpr[6] = tswap32(EPAPR_MAGIC); | ^ hw/ppc/spapr.c:1617:13: error: call to undeclared function 'tswap64'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 1617 | DIRTY_HPTE(HPTE(spapr->htab, i)); | ^ hw/ppc/spapr.c:1406:55: note: expanded from macro 'DIRTY_HPTE' 1406 | #define DIRTY_HPTE(_hpte) ((*(uint64_t *)(_hpte)) |= tswap64(HPTE64_V_HPTE_DIRTY)) | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/ppc/sam460ex.c | 1 + hw/ppc/spapr.c | 1 + hw/ppc/virtex_ml507.c | 1 + 3 files changed, 3 insertions(+) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 78e2a46e753..3bbab263ae8 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@ -22,6 +22,7 @@ #include "sysemu/device_tree.h" #include "sysemu/block-backend.h" #include "exec/page-protection.h" +#include "exec/tswap.h" #include "hw/loader.h" #include "elf.h" #include "exec/memory.h" diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 0d4efaa0c09..02136b3295a 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -90,6 +90,7 @@ #include "hw/ppc/spapr_numa.h" #include +#include "exec/tswap.h" /* SLOF memory layout: * diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index f378e5c4a90..0e9a2469599 100644 --- a/hw/ppc/virtex_ml507.c +++ b/hw/ppc/virtex_ml507.c @@ -26,6 +26,7 @@ #include "qemu/datadir.h" #include "qemu/units.h" #include "exec/page-protection.h" +#include "exec/tswap.h" #include "cpu.h" #include "hw/sysbus.h" #include "hw/char/serial-mm.h"