From patchwork Fri Dec 13 17:31:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 850138 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:2c4:b0:385:e875:8a9e with SMTP id o4csp1638005wry; Fri, 13 Dec 2024 09:34:02 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWR4VnmUE9YUF0GRm3eA56UCYCbxtE08L0fm/X8gK9LN1CZbQyOb68JLa/D0TWy6PKCr6w03A==@linaro.org X-Google-Smtp-Source: AGHT+IHHxwHdnGYvDHff3oJlyKAcd45SFIcnrUD/BLF//cIH9mmQCUhu+kBJ5emOE+6RFosTMTZ+ X-Received: by 2002:a05:622a:481b:b0:467:5e1c:1ab6 with SMTP id d75a77b69052e-467a578f2admr67426641cf.24.1734111242461; Fri, 13 Dec 2024 09:34:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734111242; cv=none; d=google.com; s=arc-20240605; b=jSklzxdXK2D5gL4NN6xtxDv4qoD+yf5iqdcwdTJm7dWc2KCMXd2cet4X/F3m+znO5p xfo4CNFWSDNo1H4EtbrpG9/xd334d3S0HQ9JYLh2kOV9kyqKEu1CmY3mZOaH5DBtB+MO v3Q1H8IcH2fa3yc7cSwdbwfR2asiCw6UZ+VQ6yzOf3ohjw8i2miMcEryEy0aNdqf/2c1 zrYbhGkQWX4GYS86Rn9SSud6OpSzE6mREkv+RwVeOBLyjwN1+9+WB+0mThbPOPGdcYsd hulTXDvZR3BYHllcIYtjwSscPSOC5aFiryKxkRhthxPwZw0Cvub9iA2RWYMVQonCW62c HkHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Ua6+mxEWQ1r/2XhLkCgBi1H+Sl0jSzIsEgqRdsyvm3M=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=kKoY3B2sejX9gE0gzPdIu5/+z4NkS+o1+YWb4NyTTa4ouod58EhFB6NEr7vR9QmHfn Lcq0x+u7Q0UYVT37GWEq2hoG/PPlz6nTY/vQ/vZtFeXL+V8za5ExmbnaVdtGWwpfUmJb qwcouuqNe4E+u8Vopqc/ntw9Xffj8V57ZH+e9TY7vy/HLpknd9MQ8BLxD0rtW3WwcA47 F5FSX8C5iKeTCbxM4LC/lvay1bRaZ47qZbC2u7IXW7WF4/y4wQnTTSbuyMI3LMyGwUac +6SEbu917bGYNcsSR8zWcifUfyU6qU25yEKdoi7cEQ1hYYCAMI0NP3V6CM44nNLzeZrv a3Tg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P9RuLjWs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46796d2cf3fsi61982291cf.131.2024.12.13.09.34.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Dec 2024 09:34:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=P9RuLjWs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tM9Xh-0007ir-4D; Fri, 13 Dec 2024 12:33:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tM9XD-00074t-Fr for qemu-devel@nongnu.org; Fri, 13 Dec 2024 12:33:04 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tM9XA-0001XT-HE for qemu-devel@nongnu.org; Fri, 13 Dec 2024 12:33:03 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4361c705434so14792435e9.3 for ; Fri, 13 Dec 2024 09:32:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734111179; x=1734715979; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ua6+mxEWQ1r/2XhLkCgBi1H+Sl0jSzIsEgqRdsyvm3M=; b=P9RuLjWs85451jV7rrCyban757iRrOxXqwp+l5/Jtc8ENjD8vad9GFz1m3Ki6F+SaR mBsQaU++yOIkDAogE02dc6jK5LsNwHlWR05FiQ15icl76Uaj7yPBKFmb/TfeufJ6G0YS JAGaBzU1V+dYMiMty3AOmbV1ZJdnFiQN3JrYGKG3XAEbiroi+z4VCFEqFTMVn8mTeI74 DifDPgY7LCQhN8t5j1PftaBNMbd+YoKBZbjKh7pd9XHU5BvrHEUq7WeLvSguVWURcnX7 w2Y0kBkvAquJ+BnScrohqXfguPnC5QTTLwTj8OQyszaOMAKRtJ4nTELQ90c52f4wEhDl EraA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734111179; x=1734715979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ua6+mxEWQ1r/2XhLkCgBi1H+Sl0jSzIsEgqRdsyvm3M=; b=r/VwsnXKFQvtdUxNsjiYKquXP95+Dcgcw3EryqoWQjsBu2NX+x1xdYty08QNlTo1xb 1AxwkM+RedlMojr3AyJgb5b2ucb4TQYlwufEHiL7FTtXoiJ18FDt0dRWUnUYkwt8v7dB WKlgUfGbpEW2moUHVgQCla/tXXGanlc8zL9SZWzR0e2FSWfzjwgayjSYViElLngHSc2u oXebKoaklNYTiaM5S+mcmOmDUVtM2u/i9PTKj7iTdgISQFiRfpiq8ybcNTs+yf/9ioCQ RIBaVEIiBfKKWdit+CLwJZj+rmw3gJgPxysjRONuM+uuyUTF5ahXv9+OpWWYY7msCd9q IJqQ== X-Gm-Message-State: AOJu0YwQFFTBVY8phCJI5bonnz0WfaCDdlaMoeeE/KuspJLsgAA2uYuY tQD62qybFwbhzRSzr7xHf5UvAAiftuJpgJqN8kNcXBZgEmjgbLeW6BOO6m/DFt9WJMYv+0+j164 W X-Gm-Gg: ASbGncuOUEvzQ3SrPmp+EAV9oHI1iymy0+Zh3syXq/TSiQ+OWka11+Se8snext9Howt IRa0FS2SlmS//uyLskhPlzAtArECqhMWkuz4iFw9ZZpmtXar1dyXaPN9Zxp1aaGKT9GfptyYkRZ cu0j55pcuxp05bOHAmerOlkuDw1wWodlg4kQVm5LsZRXROeVN/n7jyz3aBoL5ShCra/iyzRTYAz 7J97ljmt5ZOVSM9EbHzCxnqLvXNT0mi6gu+aUj1HllIuEgetEhDjbELJUGMaA== X-Received: by 2002:a5d:5f43:0:b0:385:f5b6:9c9d with SMTP id ffacd0b85a97d-38880ae0fc4mr2558873f8f.33.1734111178884; Fri, 13 Dec 2024 09:32:58 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c80162ddsm87026f8f.37.2024.12.13.09.32.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 09:32:58 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 26/85] target/arm: Remove helper_sqrt_f16 Date: Fri, 13 Dec 2024 17:31:30 +0000 Message-Id: <20241213173229.3308926-27-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241213173229.3308926-1-peter.maydell@linaro.org> References: <20241213173229.3308926-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson This function is identical with helper_vfp_sqrth. Replace all uses. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-27-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-a64.h | 1 - target/arm/tcg/helper-a64.c | 11 ----------- target/arm/tcg/translate-a64.c | 4 ++-- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/target/arm/tcg/helper-a64.h b/target/arm/tcg/helper-a64.h index 481007bf397..203b7b7ac82 100644 --- a/target/arm/tcg/helper-a64.h +++ b/target/arm/tcg/helper-a64.h @@ -80,7 +80,6 @@ DEF_HELPER_2(advsimd_rinth_exact, f16, f16, ptr) DEF_HELPER_2(advsimd_rinth, f16, f16, ptr) DEF_HELPER_2(advsimd_f16tosinth, i32, f16, ptr) DEF_HELPER_2(advsimd_f16touinth, i32, f16, ptr) -DEF_HELPER_2(sqrt_f16, f16, f16, ptr) DEF_HELPER_2(exception_return, void, env, i64) DEF_HELPER_FLAGS_2(dc_zva, TCG_CALL_NO_WG, void, env, i64) diff --git a/target/arm/tcg/helper-a64.c b/target/arm/tcg/helper-a64.c index 8f42a28d07b..3f4d7b9aba6 100644 --- a/target/arm/tcg/helper-a64.c +++ b/target/arm/tcg/helper-a64.c @@ -915,17 +915,6 @@ illegal_return: "resuming execution at 0x%" PRIx64 "\n", cur_el, env->pc); } -/* - * Square Root and Reciprocal square root - */ - -uint32_t HELPER(sqrt_f16)(uint32_t a, void *fpstp) -{ - float_status *s = fpstp; - - return float16_sqrt(a, s); -} - void HELPER(dc_zva)(CPUARMState *env, uint64_t vaddr_in) { uintptr_t ra = GETPC(); diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index cfc73b8506d..2a5cb704752 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -8354,7 +8354,7 @@ static void handle_fp_1src_half(DisasContext *s, int opcode, int rd, int rn) switch (opcode) { case 0x3: /* FSQRT */ fpst = fpstatus_ptr(FPST_FPCR_F16); - gen_helper_sqrt_f16(tcg_res, tcg_op, fpst); + gen_helper_vfp_sqrth(tcg_res, tcg_op, fpst); break; case 0x8: /* FRINTN */ case 0x9: /* FRINTP */ @@ -10978,7 +10978,7 @@ static void disas_simd_two_reg_misc_fp16(DisasContext *s, uint32_t insn) gen_helper_rsqrte_f16(tcg_res, tcg_op, tcg_fpstatus); break; case 0x7f: /* FSQRT */ - gen_helper_sqrt_f16(tcg_res, tcg_op, tcg_fpstatus); + gen_helper_vfp_sqrth(tcg_res, tcg_op, tcg_fpstatus); break; default: g_assert_not_reached();