From patchwork Fri Dec 13 17:32:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 850188 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:2c4:b0:385:e875:8a9e with SMTP id o4csp1641832wry; Fri, 13 Dec 2024 09:42:01 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU51GlpCYSaJKsGIv2RK+IquYYnK1Sim1nAk2dkGjsbvCTkvCuTzOHkDd4H7n9sfSFHRwB6Lw==@linaro.org X-Google-Smtp-Source: AGHT+IEHsqxrbNx/mrTlHvZ/IvYZWBInNX+aNCUJ80V9BeEE+kzEkMxgaPOjFvHcy83BZPWxWqoi X-Received: by 2002:a05:6000:71d:b0:382:45db:6a1e with SMTP id ffacd0b85a97d-388c366d199mr2900927f8f.14.1734111721596; Fri, 13 Dec 2024 09:42:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734111721; cv=none; d=google.com; s=arc-20240605; b=kXOPSEC7TZsKltTfjR3794lVm3vk0K0eo2/7L3k6hLV/etYjlA+8+HKw+qlGkE6zfU dxf0Gvh4qoVhHWM9RqQXC+LGwxjYLf0JDexw0mzJN+qk65SkTRj9HG4nS1MG8QG09m9J MPWwFCiqO1aYw09kyMZ38FFm/+AhqcBpqXx1OvfP6BE+JvGzGba9a7JNrxX5VrDya6If PGP3O+ngVbhV8334R1CEJP79fwLXYj3bIemt9RAmpJ5zkK3uYgGB9YE1TAOLtHHQaM2e 2r2uEg16KC4JuiDnSKt9zzpsncjQXwekc5txr3SQCCFcjKtFpJIdyGx0mlZPePsR4I9x rZxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=59ZvNHRjbkXZRNQSQ5QVDZjUuqRFFa7W8p2pL9z93/k=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=aVq93J1nDPXKNJUp0NCB6K/IGG6iyq6lmT8m+L2r8D6PB2ygYO03WQJVUr3hEbaYxg gsmIdJ09itl0Mr61HfvBHyv1dNG/4NwlmRcw5mwC93XElNloIIl52ckAcA3NvcfmHNlh uKoy/SshsBEJTfG+7ci0xpteAZaykYPbrAuEFMK5ojnD3feXDmbzgPhWrmSgjcS7SyHX +x/nQMmQo8ji8JxHvnFvBmv1GcFBcTV8jsPTODR4x3ZhoTQyzQeChvChFYAD3LLYDJ0S JtGxBLzJl4akoXJUe9u1Yj8JY5ViYvjkLqo8/RdYiOyZnW3BogAm9578e9hJQghoN8/U GsDA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LHlbrTei; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ffacd0b85a97d-388c807b53asi27758f8f.984.2024.12.13.09.42.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Dec 2024 09:42:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LHlbrTei; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tM9Zc-0007CR-1Q; Fri, 13 Dec 2024 12:35:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tM9Xm-0007rd-I2 for qemu-devel@nongnu.org; Fri, 13 Dec 2024 12:33:39 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tM9Xk-0001h3-Ov for qemu-devel@nongnu.org; Fri, 13 Dec 2024 12:33:38 -0500 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3862d16b4f5so1352034f8f.0 for ; Fri, 13 Dec 2024 09:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734111215; x=1734716015; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=59ZvNHRjbkXZRNQSQ5QVDZjUuqRFFa7W8p2pL9z93/k=; b=LHlbrTei4tFAJmJiwrlX8p+3Qq9kv1Hj4DdZzT9w4toaIW4j16nmp0CsNBrYM9DCqc 3pI2GgS/F8g62KAxMnZMK8w8gShT3LqeNNtX54i0CpfgxSCBl0oZhnfuBLnU1br09nIw PJ6EL/D/bbD3r5VhQflHilK1yd7gl6JvTxCvbAnvw+4GfYQkbCbGT4LibxTA6SSHoPeU 8il9CaHVtjmFhu+XzqG7PYN8MxFgYM8ovDJJKHPmra7cCEpFm0Y9JNlbF7Pi3bHUsrTA MyZCcxLyU27bdm/YBYhxqVU3T1WBkpOFgxpPrMQHJJXBae1yQm83x3A91Cm9YccpZZFO ljDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734111215; x=1734716015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59ZvNHRjbkXZRNQSQ5QVDZjUuqRFFa7W8p2pL9z93/k=; b=nKpGCE+dHyZHNWrdmfhs7R48oSNJZzM9kqUNTkmb7ZUvYlktl+KynPvgK3++NTP2cE 8YDiIdL3js2tjc71HwL7i6Ah5GHsm8zArCKkmceG/z1sj+CsBn01yegXzMlc6lojQc9F MHMFTfC4vNmXWowjAPa54yWhtUpBAZ0xFykWl7i8yQ1xHtwHb0ZwwtykqJV34URfHpe7 ATI5MLJk+s0g4/FtFGG6FZ12Mp+ZaII+FaZiZHzW6pyGcRVNSacypg+xCxoMdeDQtbDa D6qL5aDGbAK/p3Vynv0kOp9aJOjHNoJXqeIhLmIU++b8PHH/s63RuHz0VjXRFu5mm1Cs xk2w== X-Gm-Message-State: AOJu0Yy5vBzpirf3irZ2aQYsfNO6oY5HtiHDnjCh77KXxDtkUAnpyPOY eBulNar8etAw2Y/Ohe6SGNb4H/hax4njXQtImkEQhbGfo8PLhodaOmpFYkAvxpAKQrQ0oPJKEcc A X-Gm-Gg: ASbGncs0HO8mBV32kBj7Ggq5v5RwnwZ5Eau8gdh41h7tqPssNmltgvGM2rQ0Ba+J6Ho nooljAEowp0S4FRTIwsz/uc+FNTeFk8qVfgvpXghj8ndfAVGDbd92QiiWXISy1TbIS0YiOgaLwS XuJvPxEi5YszV+2xrzihlTsyAsRaHEFiCqCTUZ9ua928KNofsUBQNpekUfJqGCqxeVF5MKsW4aS hgdpvygaq0q8Hj86MeWY3EqXY75XdubSuhe1a/mnPNuJDhVINSUAxOBKz4V7Q== X-Received: by 2002:a05:6000:1fad:b0:386:42b1:d7e4 with SMTP id ffacd0b85a97d-3878884729bmr6676477f8f.19.1734111215378; Fri, 13 Dec 2024 09:33:35 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c80162ddsm87026f8f.37.2024.12.13.09.33.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 09:33:34 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 60/85] target/arm: Convert [US]CVTF (vector, fixed-point) scalar to decodetree Date: Fri, 13 Dec 2024 17:32:04 +0000 Message-Id: <20241213173229.3308926-61-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241213173229.3308926-1-peter.maydell@linaro.org> References: <20241213173229.3308926-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson Remove disas_simd_scalar_shift_imm as these were the last insns decoded by that function. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20241211163036.2297116-61-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 8 ++++++ target/arm/tcg/translate-a64.c | 47 ---------------------------------- 2 files changed, 8 insertions(+), 47 deletions(-) diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode index 146500d9c4b..30e1834d998 100644 --- a/target/arm/tcg/a64.decode +++ b/target/arm/tcg/a64.decode @@ -1699,6 +1699,14 @@ FCVTAU_f 0111 1110 0.1 00001 11001 0 ..... ..... @icvt_sd @fcvt_fixed_d .... .... . 1 ...... ...... rn:5 rd:5 \ &fcvt sf=0 esz=3 shift=%fcvt_f_sh_d +SCVTF_f 0101 1111 0 ....... 111001 ..... ..... @fcvt_fixed_h +SCVTF_f 0101 1111 0 ....... 111001 ..... ..... @fcvt_fixed_s +SCVTF_f 0101 1111 0 ....... 111001 ..... ..... @fcvt_fixed_d + +UCVTF_f 0111 1111 0 ....... 111001 ..... ..... @fcvt_fixed_h +UCVTF_f 0111 1111 0 ....... 111001 ..... ..... @fcvt_fixed_s +UCVTF_f 0111 1111 0 ....... 111001 ..... ..... @fcvt_fixed_d + FCVTZS_f 0101 1111 0 ....... 111111 ..... ..... @fcvt_fixed_h FCVTZS_f 0101 1111 0 ....... 111111 ..... ..... @fcvt_fixed_s FCVTZS_f 0101 1111 0 ....... 111111 ..... ..... @fcvt_fixed_d diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 6e9d040ebfb..08f24908a45 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -9531,52 +9531,6 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar, gen_restore_rmode(tcg_rmode, tcg_fpstatus); } -/* AdvSIMD scalar shift by immediate - * 31 30 29 28 23 22 19 18 16 15 11 10 9 5 4 0 - * +-----+---+-------------+------+------+--------+---+------+------+ - * | 0 1 | U | 1 1 1 1 1 0 | immh | immb | opcode | 1 | Rn | Rd | - * +-----+---+-------------+------+------+--------+---+------+------+ - * - * This is the scalar version so it works on a fixed sized registers - */ -static void disas_simd_scalar_shift_imm(DisasContext *s, uint32_t insn) -{ - int rd = extract32(insn, 0, 5); - int rn = extract32(insn, 5, 5); - int opcode = extract32(insn, 11, 5); - int immb = extract32(insn, 16, 3); - int immh = extract32(insn, 19, 4); - bool is_u = extract32(insn, 29, 1); - - if (immh == 0) { - unallocated_encoding(s); - return; - } - - switch (opcode) { - case 0x1c: /* SCVTF, UCVTF */ - handle_simd_shift_intfp_conv(s, true, false, is_u, immh, immb, - opcode, rn, rd); - break; - default: - case 0x00: /* SSHR / USHR */ - case 0x02: /* SSRA / USRA */ - case 0x04: /* SRSHR / URSHR */ - case 0x06: /* SRSRA / URSRA */ - case 0x08: /* SRI */ - case 0x0a: /* SHL / SLI */ - case 0x0c: /* SQSHLU */ - case 0x0e: /* SQSHL, UQSHL */ - case 0x10: /* SQSHRUN */ - case 0x11: /* SQRSHRUN */ - case 0x12: /* SQSHRN, UQSHRN */ - case 0x13: /* SQRSHRN, UQRSHRN */ - case 0x1f: /* FCVTZS, FCVTZU */ - unallocated_encoding(s); - break; - } -} - static void handle_2misc_64(DisasContext *s, int opcode, bool u, TCGv_i64 tcg_rd, TCGv_i64 tcg_rn, TCGv_i32 tcg_rmode, TCGv_ptr tcg_fpstatus) @@ -10476,7 +10430,6 @@ static const AArch64DecodeTable data_proc_simd[] = { { 0x0e200800, 0x9f3e0c00, disas_simd_two_reg_misc }, { 0x0f000400, 0x9f800400, disas_simd_shift_imm }, { 0x5e200800, 0xdf3e0c00, disas_simd_scalar_two_reg_misc }, - { 0x5f000400, 0xdf800400, disas_simd_scalar_shift_imm }, { 0x0e780800, 0x8f7e0c00, disas_simd_two_reg_misc_fp16 }, { 0x00000000, 0x00000000, NULL } };